From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id D7637C32772 for ; Thu, 18 Aug 2022 20:11:42 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S239522AbiHRULl (ORCPT ); Thu, 18 Aug 2022 16:11:41 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48978 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1346095AbiHRUKx (ORCPT ); Thu, 18 Aug 2022 16:10:53 -0400 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 04EA4D83EF for ; Thu, 18 Aug 2022 13:06:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1660853135; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=ekfMu/NlgHnoEql9XLmlRVPwjxrh2EoMdj4w3IuDChw=; b=gIkfl+iIskONqH2P9sOLoVhnZDRWp/4eW7oQX4jqBSHTaVgMEXgkhLJo+xewgheH/h+Y6V lrF1SRkrIaO6tOjCbT0Y9nVJWt1rfWbkZQ1peC5p9JvegID9sgy1sImbk5H+bSFlOC8TiQ ro+2als5gfsMmQtJQNQBKkBwdOhp5yU= Received: from mail-qk1-f200.google.com (mail-qk1-f200.google.com [209.85.222.200]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-317-CDjaxWnmN729FTRYTWLvFg-1; Thu, 18 Aug 2022 16:05:34 -0400 X-MC-Unique: CDjaxWnmN729FTRYTWLvFg-1 Received: by mail-qk1-f200.google.com with SMTP id bm11-20020a05620a198b00b006bb2388ef0cso2263244qkb.5 for ; Thu, 18 Aug 2022 13:05:34 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc; bh=ekfMu/NlgHnoEql9XLmlRVPwjxrh2EoMdj4w3IuDChw=; b=2q9ujuJNxNLBIGTswTmvdzD9MTqqWoOgZU8rVNsv8yq6vCTwtSyDvuOKRMRo7nLIdq PIJnBdJEPJL9I4LDIIIxK7o5H/CrI3rGGYnbKJrfZE9PDmx4iUkDOa1cpUyNXUFA4Lzn N/3QYrjUBOFroQPg7JBXwk2BRcdD9RAPzfJiGQ8RFDw2JlPY6My04sADps+N8x5I6mOv 8nBT/0N7p6C71DoJtHf9U9vi7W+2e1gHI6z+KppJv7gqLtWYoS28fBLUUdAq/C5+c2wf /h10MrHWAfRPPSWQIO+T1cYKZ7HP8FDkiDzJ7yGtYe/41VwtH8UYzk8xq+hhYG9oXEs4 2F3g== X-Gm-Message-State: ACgBeo39eKfWiUunCZDXyD2N4Ad4RZ8z45UJyHMdW+Gx58YbUA4oPs1h dA8mSvluMzy2r/rfUGX0tl04+n/G0kq0U/y1jcPBzRHAgn/Py3YR6qCaRh8XxbRLMHhHuGwr5AC lf+i/4QOQGedBayx8aMstvQ== X-Received: by 2002:a05:6214:20cb:b0:496:ae48:d2e8 with SMTP id 11-20020a05621420cb00b00496ae48d2e8mr3767808qve.113.1660853134089; Thu, 18 Aug 2022 13:05:34 -0700 (PDT) X-Google-Smtp-Source: AA6agR7dHzQ3nxL/TMyb38jqS9VwCzXhHQeOQHvaHmUhUqlkC39MNQ5tbo9wHlGuZ25bF1KoAQmfWw== X-Received: by 2002:a05:6214:20cb:b0:496:ae48:d2e8 with SMTP id 11-20020a05621420cb00b00496ae48d2e8mr3767788qve.113.1660853133830; Thu, 18 Aug 2022 13:05:33 -0700 (PDT) Received: from halaneylaptop ([2600:1700:1ff0:d0e0::1e]) by smtp.gmail.com with ESMTPSA id bb27-20020a05622a1b1b00b00342f917444csm1551151qtb.85.2022.08.18.13.05.32 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 18 Aug 2022 13:05:33 -0700 (PDT) Date: Thu, 18 Aug 2022 15:05:30 -0500 From: Andrew Halaney To: Lorenzo Pieralisi Cc: Johan Hovold , Brian Masney , Johan Hovold , Bjorn Helgaas , Stanimir Varbanov , Rob Herring , Krzysztof Kozlowski , Andy Gross , Bjorn Andersson , Konrad Dybcio , Krzysztof =?utf-8?Q?Wilczy=C5=84ski?= , Dmitry Baryshkov , Manivannan Sadhasivam , linux-arm-msm@vger.kernel.org, linux-pci@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 8/8] PCI: qcom: Sort device-id table Message-ID: <20220818200530.lab2zlcaetekcclq@halaneylaptop> References: <20220714071348.6792-1-johan+linaro@kernel.org> <20220714071348.6792-9-johan+linaro@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org Hi Lorenzo, On Tue, Aug 16, 2022 at 06:06:21PM +0200, Lorenzo Pieralisi wrote: > On Fri, Jul 15, 2022 at 09:43:36AM +0200, Johan Hovold wrote: > > On Thu, Jul 14, 2022 at 10:27:23AM -0400, Brian Masney wrote: > > > On Thu, Jul 14, 2022 at 09:13:48AM +0200, Johan Hovold wrote: > > > > Sort the device-id table entries alphabetically by compatible string to > > > > make it easier to find entries and add new ones. > > > > > > > > Signed-off-by: Johan Hovold > > > > --- > > > > drivers/pci/controller/dwc/pcie-qcom.c | 12 ++++++------ > > > > 1 file changed, 6 insertions(+), 6 deletions(-) > > > > > > > > diff --git a/drivers/pci/controller/dwc/pcie-qcom.c b/drivers/pci/controller/dwc/pcie-qcom.c > > > > index 8dddb72f8647..fea921cca8fa 100644 > > > > --- a/drivers/pci/controller/dwc/pcie-qcom.c > > > > +++ b/drivers/pci/controller/dwc/pcie-qcom.c > > > > @@ -1749,24 +1749,24 @@ static int qcom_pcie_remove(struct platform_device *pdev) > > > > } > > > > > > > > static const struct of_device_id qcom_pcie_match[] = { > > > > + { .compatible = "qcom,pcie-apq8064", .data = &cfg_2_1_0 }, > > > > { .compatible = "qcom,pcie-apq8084", .data = &cfg_1_0_0 }, > > > > + { .compatible = "qcom,pcie-ipq6018", .data = &cfg_2_9_0 }, > > > > { .compatible = "qcom,pcie-ipq8064", .data = &cfg_2_1_0 }, > > > > { .compatible = "qcom,pcie-ipq8064-v2", .data = &cfg_2_1_0 }, > > > > - { .compatible = "qcom,pcie-apq8064", .data = &cfg_2_1_0 }, > > > > - { .compatible = "qcom,pcie-msm8996", .data = &cfg_2_3_2 }, > > > > { .compatible = "qcom,pcie-ipq8074", .data = &cfg_2_3_3 }, > > > > { .compatible = "qcom,pcie-ipq4019", .data = &cfg_2_4_0 }, > > > > > > qcom,pcie-ipq4019 should be moved up above qcom,pcie-ipq6018. > > > > If we only had some sort of machine that could sort strings for us... ;) > > I'll rely on vim for this from now on. > > > > Perhaps Bjorn H can fix that up when applying unless I'll be sending a > > v3 for some other reason. This series still depends on the MSI rework to > > be applied first. > > I can do it while applying. A link to the lore archive for the MSI > rework please (I don't think it was merged for v6.0) ? I was away for > two months, catching up with threads. I don't see a reply to this, so here I am following up out of interest for getting this in mainline for my x13s laptop to use. It appears the MSI rework[0] (which is in the cover letter here so I know I grabbed the right thing) was applied in 6.0: ahalaney@halaneylaptop ~/git/linux (git)-[remotes/upstream/HEAD] % git log --oneline --abbrev=12 --grep=2436629 v6.0-rc1 -- drivers/pci/controller/dwc/ cd761378e62c PCI: dwc: Handle MSIs routed to multiple GIC interrupts db388348acff PCI: dwc: Convert struct pcie_port.msi_irq to an array 226ec087497a PCI: dwc: Split MSI IRQ parsing/allocation to a separate function 3c62f878a969 PCI: dwc: Correct msi_irq condition in dw_pcie_free_msi() ahalaney@halaneylaptop ~/git/linux (git)-[remotes/upstream/HEAD] % Just a friendly FYI, hope that helps! [0] https://lore.kernel.org/all/20220707134733.2436629-6-dmitry.baryshkov@linaro.org/ Thanks, Andrew > > Thanks, > Lorenzo > > > Thanks for reviewing. > > > > Johan