From: Shawn Guo <shawnguo@kernel.org>
To: haibo.chen@nxp.com
Cc: robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org,
s.hauer@pengutronix.de, kernel@pengutronix.de,
festevam@gmail.com, linux-imx@nxp.com,
devicetree@vger.kernel.org
Subject: Re: [PATCH] arm: dts: imx7d-sdb: config the max pressure for tsc2046
Date: Sun, 21 Aug 2022 16:38:53 +0800 [thread overview]
Message-ID: <20220821083853.GV149610@dragon> (raw)
In-Reply-To: <1658744182-570-1-git-send-email-haibo.chen@nxp.com>
On Mon, Jul 25, 2022 at 06:16:22PM +0800, haibo.chen@nxp.com wrote:
> From: Haibo Chen <haibo.chen@nxp.com>
>
> Use the general touchscreen method to config the max pressure for
> touch tsc2046(data sheet suggest 8 bit pressure), otherwise, for
> ABS_PRESSURE, when config the same max and min value, weston will
> meet the following issue,
>
> [17:19:39.183] event1 - ADS7846 Touchscreen: is tagged by udev as: Touchscreen
> [17:19:39.183] event1 - ADS7846 Touchscreen: kernel bug: device has min == max on ABS_PRESSURE
> [17:19:39.183] event1 - ADS7846 Touchscreen: was rejected
> [17:19:39.183] event1 - not using input device '/dev/input/event1'
>
> This will then cause the APP weston-touch-calibrator can't list touch devices.
>
> root@imx6ul7d:~# weston-touch-calibrator
> could not load cursor 'dnd-move'
> could not load cursor 'dnd-copy'
> could not load cursor 'dnd-none'
> No devices listed.
>
> And accroding to binding Doc, "ti,x-max", "ti,y-max", "ti,pressure-max"
> belong to the deprecated properties, so remove them. Also for "ti,x-min",
> "ti,y-min", "ti,x-plate-ohms", the value set in dts equal to the default
> value in driver, so are redundant, also remove here.
>
> Signed-off-by: Haibo Chen <haibo.chen@nxp.com>
Applied, thanks!
prev parent reply other threads:[~2022-08-21 8:39 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-25 10:16 [PATCH] arm: dts: imx7d-sdb: config the max pressure for tsc2046 haibo.chen
2022-08-21 8:38 ` Shawn Guo [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220821083853.GV149610@dragon \
--to=shawnguo@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=festevam@gmail.com \
--cc=haibo.chen@nxp.com \
--cc=kernel@pengutronix.de \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-imx@nxp.com \
--cc=robh+dt@kernel.org \
--cc=s.hauer@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).