* [PATCH v2] arm64: dts: rockchip: fix upper usb port on BPI-R2-Pro
@ 2022-08-21 12:19 Frank Wunderlich
2022-08-23 12:36 ` Heiko Stuebner
0 siblings, 1 reply; 2+ messages in thread
From: Frank Wunderlich @ 2022-08-21 12:19 UTC (permalink / raw)
To: linux-rockchip
Cc: Frank Wunderlich, Rob Herring, Krzysztof Kozlowski,
Heiko Stuebner, devicetree, linux-arm-kernel, linux-kernel
From: Frank Wunderlich <frank-w@public-files.de>
- extcon is no more needed in 5.19 - so drop it
commit 51a9b2c03dd3 ("phy: rockchip-inno-usb2: Handle ID IRQ")
- dr_mode was changed from host to otg in rk356x.dtsi
commit bc405bb3eeee ("arm64: dts: rockchip: enable otg/drd
operation of usb_host0_xhci in rk356x")
change it back on board level as id-pin on r2pro is not connected
Signed-off-by: Frank Wunderlich <frank-w@public-files.de>
---
for hostmode to work this fix is needed:
https://patchwork.kernel.org/project/linux-rockchip/patch/20220708061434.38115-1-samuel@sholland.org/
---
arch/arm64/boot/dts/rockchip/rk3568-bpi-r2-pro.dts | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm64/boot/dts/rockchip/rk3568-bpi-r2-pro.dts b/arch/arm64/boot/dts/rockchip/rk3568-bpi-r2-pro.dts
index 5e34bd0b214d..93d383b8be87 100644
--- a/arch/arm64/boot/dts/rockchip/rk3568-bpi-r2-pro.dts
+++ b/arch/arm64/boot/dts/rockchip/rk3568-bpi-r2-pro.dts
@@ -678,7 +678,7 @@ &usb_host0_ohci {
};
&usb_host0_xhci {
- extcon = <&usb2phy0>;
+ dr_mode = "host";
status = "okay";
};
--
2.34.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH v2] arm64: dts: rockchip: fix upper usb port on BPI-R2-Pro
2022-08-21 12:19 [PATCH v2] arm64: dts: rockchip: fix upper usb port on BPI-R2-Pro Frank Wunderlich
@ 2022-08-23 12:36 ` Heiko Stuebner
0 siblings, 0 replies; 2+ messages in thread
From: Heiko Stuebner @ 2022-08-23 12:36 UTC (permalink / raw)
To: linux-rockchip, Frank Wunderlich
Cc: Heiko Stuebner, Krzysztof Kozlowski, Rob Herring,
linux-arm-kernel, Frank Wunderlich, devicetree, linux-kernel
On Sun, 21 Aug 2022 14:19:29 +0200, Frank Wunderlich wrote:
> - extcon is no more needed in 5.19 - so drop it
> commit 51a9b2c03dd3 ("phy: rockchip-inno-usb2: Handle ID IRQ")
> - dr_mode was changed from host to otg in rk356x.dtsi
> commit bc405bb3eeee ("arm64: dts: rockchip: enable otg/drd
> operation of usb_host0_xhci in rk356x")
> change it back on board level as id-pin on r2pro is not connected
Applied, thanks!
[1/1] arm64: dts: rockchip: fix upper usb port on BPI-R2-Pro
commit: 388f9f0a7ff84b7890a24499a3a1fea0cad21373
Best regards,
--
Heiko Stuebner <heiko@sntech.de>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-08-23 16:16 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-08-21 12:19 [PATCH v2] arm64: dts: rockchip: fix upper usb port on BPI-R2-Pro Frank Wunderlich
2022-08-23 12:36 ` Heiko Stuebner
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).