From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0BD3CC28D13 for ; Mon, 22 Aug 2022 06:01:09 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229758AbiHVGBG (ORCPT ); Mon, 22 Aug 2022 02:01:06 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52024 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229499AbiHVGBF (ORCPT ); Mon, 22 Aug 2022 02:01:05 -0400 Received: from esa.microchip.iphmx.com (esa.microchip.iphmx.com [68.232.153.233]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 144501F61B; Sun, 21 Aug 2022 23:01:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=microchip.com; i=@microchip.com; q=dns/txt; s=mchp; t=1661148063; x=1692684063; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=06z1Sp4leSqz/xK8Xz8b0aRfqzDx5qUAH0KwCoR1bYk=; b=VfkQJ4owSztDk8idF3knm4ahXBhMH5W4KaKuNBncFap8GGFqJB1jX45I QkI2hJtUY29pko7zxW3BwxDq1CVg3Jwrr4iAgp8NQLyDGuD7avgJxQ2Mo dQD4MSygS4S2hhQ3WHjHCJNEGDLBJ8Z91xs9h8xSJ7hdtgl4ejN/OlVkq JuZjspwfxV5MNgXdcbSC/6panPncFz1Os7fb3vaxY2zllo1m5R+0CphRK pXhEPzNOw93yFr8d4xqY6OYxYtnZIjwFCXX+UxKW75Qpm9zliPLuISord Xq4KKR+g9eN2Gn4evGeNekyUq7RZNd9ajhrt+eRxUx7xAIsxRhS6xu/lZ A==; X-IronPort-AV: E=Sophos;i="5.93,254,1654585200"; d="scan'208";a="177314448" Received: from unknown (HELO email.microchip.com) ([170.129.1.10]) by esa3.microchip.iphmx.com with ESMTP/TLS/AES256-SHA256; 21 Aug 2022 23:01:03 -0700 Received: from chn-vm-ex02.mchp-main.com (10.10.85.144) by chn-vm-ex01.mchp-main.com (10.10.85.143) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.12; Sun, 21 Aug 2022 23:00:43 -0700 Received: from localhost (10.10.115.15) by chn-vm-ex02.mchp-main.com (10.10.85.144) with Microsoft SMTP Server id 15.1.2507.12 via Frontend Transport; Sun, 21 Aug 2022 23:00:43 -0700 Date: Mon, 22 Aug 2022 08:04:56 +0200 From: Horatiu Vultur To: Krzysztof Kozlowski CC: , , , , Subject: Re: [PATCH 1/2] dt-bindings: lan966x-otpc: document Lan966X OTPC Message-ID: <20220822060456.sl343a3a3uifini7@soft-dev3-1.localhost> References: <20220818164405.1953698-1-horatiu.vultur@microchip.com> <20220818164405.1953698-2-horatiu.vultur@microchip.com> <550e652e-4541-c1e6-33a7-d5555f0cb266@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Disposition: inline In-Reply-To: <550e652e-4541-c1e6-33a7-d5555f0cb266@linaro.org> Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org The 08/19/2022 09:52, Krzysztof Kozlowski wrote: Hi Krzysztof, > > On 18/08/2022 19:44, Horatiu Vultur wrote: > > Document Lan966x OTP controller. > > > > + > > +properties: > > + compatible: > > + items: > > + - const: microchip,lan966x-otpc > > No wildcards in compatible (which will also affect the file name as it > should match the compatible). Ok, I will replace lan966x with lan966 as the SoC is defined (SOC_LAN966) > > > + - const: syscon > > Is OTP controller also system controller register region? This is a bit > odd and looks like hack not to use nvmem subsystem. That was a copy paste mistake. The OTP controller is not a system controller register region. > > > + > > + reg: > > + maxItems: 1 > > + > > +required: > > + - compatible > > + - reg > > + > > +unevaluatedProperties: false > > + > > +examples: > > + - | > > + otpc: otp@e0021000 { > > + compatible = "microchip,lan966x-otpc", "syscon"; > > + reg = <0xe0021000 0x300>; > > + }; > > + > > +... > > > Best regards, > Krzysztof -- /Horatiu