From: Serge Semin <Sergey.Semin@baikalelectronics.ru>
To: Damien Le Moal <damien.lemoal@opensource.wdc.com>,
Hans de Goede <hdegoede@redhat.com>, Jens Axboe <axboe@kernel.dk>,
Hannes Reinecke <hare@suse.de>
Cc: Serge Semin <Sergey.Semin@baikalelectronics.ru>,
Serge Semin <fancer.lancer@gmail.com>,
Alexey Malahov <Alexey.Malahov@baikalelectronics.ru>,
Pavel Parkhomenko <Pavel.Parkhomenko@baikalelectronics.ru>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
<linux-ide@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
<devicetree@vger.kernel.org>
Subject: [PATCH v7 12/23] ata: libahci: Extend port-cmd flags set with port capabilities
Date: Mon, 22 Aug 2022 21:37:17 +0300 [thread overview]
Message-ID: <20220822183728.24434-13-Sergey.Semin@baikalelectronics.ru> (raw)
In-Reply-To: <20220822183728.24434-1-Sergey.Semin@baikalelectronics.ru>
Currently not all of the Port-specific capabilities listed in the
PORT_CMD-enumeration. Let's extend that set with the Cold Presence
Detection and Mechanical Presence Switch attached to the Port flags [1] so
to closeup the set of the platform-specific port-capabilities flags. Note
these flags are supposed to be set by the platform firmware if there is
one. Alternatively as we are about to do they can be set by means of the
OF properties.
While at it replace PORT_IRQ_DEV_ILCK with PORT_IRQ_DMPS and fix the
comment there. In accordance with [2] that IRQ flag is supposed to
indicate the state of the signal coming from the Mechanical Presence
Switch.
[1] Serial ATA AHCI 1.3.1 Specification, p.27
[2] Serial ATA AHCI 1.3.1 Specification, p.24, p.88
Signed-off-by: Serge Semin <Sergey.Semin@baikalelectronics.ru>
Reviewed-by: Hannes Reinecke <hare@suse.de>
---
Changelog v4:
- Fix the DMPS macros name in the patch log. (@Sergei Shtylyov)
Changelog v5:
- Add a comment regarding the PORT_CMD_CAP enum entity purpose. (@Damien)
---
drivers/ata/ahci.h | 8 +++++++-
1 file changed, 7 insertions(+), 1 deletion(-)
diff --git a/drivers/ata/ahci.h b/drivers/ata/ahci.h
index 7d834deefeb9..27cab4e909a5 100644
--- a/drivers/ata/ahci.h
+++ b/drivers/ata/ahci.h
@@ -138,7 +138,7 @@ enum {
PORT_IRQ_BAD_PMP = (1 << 23), /* incorrect port multiplier */
PORT_IRQ_PHYRDY = (1 << 22), /* PhyRdy changed */
- PORT_IRQ_DEV_ILCK = (1 << 7), /* device interlock */
+ PORT_IRQ_DMPS = (1 << 7), /* mechanical presence status */
PORT_IRQ_CONNECT = (1 << 6), /* port connect change status */
PORT_IRQ_SG_DONE = (1 << 5), /* descriptor processed */
PORT_IRQ_UNK_FIS = (1 << 4), /* unknown FIS rx'd */
@@ -166,6 +166,8 @@ enum {
PORT_CMD_ATAPI = (1 << 24), /* Device is ATAPI */
PORT_CMD_FBSCP = (1 << 22), /* FBS Capable Port */
PORT_CMD_ESP = (1 << 21), /* External Sata Port */
+ PORT_CMD_CPD = (1 << 20), /* Cold Presence Detection */
+ PORT_CMD_MPSP = (1 << 19), /* Mechanical Presence Switch */
PORT_CMD_HPCP = (1 << 18), /* HotPlug Capable Port */
PORT_CMD_PMP = (1 << 17), /* PMP attached */
PORT_CMD_LIST_ON = (1 << 15), /* cmd list DMA engine running */
@@ -181,6 +183,10 @@ enum {
PORT_CMD_ICC_PARTIAL = (0x2 << 28), /* Put i/f in partial state */
PORT_CMD_ICC_SLUMBER = (0x6 << 28), /* Put i/f in slumber state */
+ /* PORT_CMD capabilities mask */
+ PORT_CMD_CAP = PORT_CMD_HPCP | PORT_CMD_MPSP |
+ PORT_CMD_CPD | PORT_CMD_ESP | PORT_CMD_FBSCP,
+
/* PORT_FBS bits */
PORT_FBS_DWE_OFFSET = 16, /* FBS device with error offset */
PORT_FBS_ADO_OFFSET = 12, /* FBS active dev optimization offset */
--
2.35.1
next prev parent reply other threads:[~2022-08-22 18:38 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-22 18:37 [PATCH v7 00/23] ata: ahci: Add DWC/Baikal-T1 AHCI SATA support Serge Semin
2022-08-22 18:37 ` [PATCH v7 01/23] dt-bindings: ata: ahci-platform: Move dma-coherent to sata-common.yaml Serge Semin
2022-08-22 18:37 ` [PATCH v7 02/23] dt-bindings: ata: ahci-platform: Detach common AHCI bindings Serge Semin
2022-08-22 18:37 ` [PATCH v7 03/23] dt-bindings: ata: ahci-platform: Clarify common AHCI props constraints Serge Semin
2022-08-22 18:37 ` [PATCH v7 04/23] dt-bindings: ata: sata: Extend number of SATA ports Serge Semin
2022-08-22 18:37 ` [PATCH v7 05/23] dt-bindings: ata: sata-brcm: Apply common AHCI schema Serge Semin
2022-08-22 18:37 ` [PATCH v7 06/23] ata: libahci_platform: Convert to using platform devm-ioremap methods Serge Semin
2022-08-22 18:37 ` [PATCH v7 07/23] ata: libahci_platform: Convert to using devm bulk clocks API Serge Semin
2022-08-23 23:42 ` kernel test robot
2022-08-24 23:19 ` Damien Le Moal
2022-08-25 5:53 ` Serge Semin
2022-08-22 18:37 ` [PATCH v7 08/23] ata: libahci_platform: Sanity check the DT child nodes number Serge Semin
2022-08-22 18:37 ` [PATCH v7 09/23] ata: libahci_platform: Parse ports-implemented property in resources getter Serge Semin
2022-08-22 18:37 ` [PATCH v7 10/23] ata: libahci_platform: Introduce reset assertion/deassertion methods Serge Semin
2022-08-22 18:37 ` [PATCH v7 11/23] dt-bindings: ata: ahci: Add platform capability properties Serge Semin
2022-08-22 18:37 ` Serge Semin [this message]
2022-08-22 18:37 ` [PATCH v7 13/23] ata: libahci: Discard redundant force_port_map parameter Serge Semin
2022-08-22 18:37 ` [PATCH v7 14/23] ata: libahci: Don't read AHCI version twice in the save-config method Serge Semin
2022-08-22 18:37 ` [PATCH v7 15/23] ata: ahci: Convert __ahci_port_base to accepting hpriv as arguments Serge Semin
2022-08-22 18:37 ` [PATCH v7 16/23] ata: ahci: Introduce firmware-specific caps initialization Serge Semin
2022-08-22 18:37 ` [PATCH v7 17/23] dt-bindings: ata: ahci: Add DWC AHCI SATA controller DT schema Serge Semin
2022-08-22 18:37 ` [PATCH v7 18/23] ata: libahci_platform: Add function returning a clock-handle by id Serge Semin
2022-08-22 18:37 ` [PATCH v7 19/23] ata: ahci: Add DWC AHCI SATA controller support Serge Semin
2022-09-04 0:34 ` kernel test robot
2022-09-07 18:25 ` Serge Semin
2022-08-22 18:37 ` [PATCH v7 20/23] dt-bindings: ata: ahci: Add Baikal-T1 AHCI SATA controller DT schema Serge Semin
2022-08-22 18:37 ` [PATCH v7 21/23] ata: ahci-dwc: Add platform-specific quirks support Serge Semin
2022-08-22 18:37 ` [PATCH v7 22/23] ata: ahci-dwc: Add Baikal-T1 AHCI SATA interface support Serge Semin
2022-08-22 18:37 ` [PATCH v7 23/23] MAINTAINERS: Add maintainers for DWC AHCI SATA driver Serge Semin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220822183728.24434-13-Sergey.Semin@baikalelectronics.ru \
--to=sergey.semin@baikalelectronics.ru \
--cc=Alexey.Malahov@baikalelectronics.ru \
--cc=Pavel.Parkhomenko@baikalelectronics.ru \
--cc=axboe@kernel.dk \
--cc=damien.lemoal@opensource.wdc.com \
--cc=devicetree@vger.kernel.org \
--cc=fancer.lancer@gmail.com \
--cc=hare@suse.de \
--cc=hdegoede@redhat.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-ide@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).