Re: [PATCH V7 4/6] soc: imx: add i.MX93 media blk ctrl driver

[kernel test robot <lkp@intel.com>]

Hi "Peng,

Thank you for the patch! Yet something to improve:

[auto build test ERROR on shawnguo/for-next]
[also build test ERROR on linus/master v6.0-rc2 next-20220822]
[cannot apply to robh/for-next]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/Peng-Fan-OSS/imx-support-i-MX93-SRC-and-mediamix-blk-ctrl/20220822-163300
base:   https://git.kernel.org/pub/scm/linux/kernel/git/shawnguo/linux.git for-next
config: sh-allmodconfig (https://download.01.org/0day-ci/archive/20220822/202208221843.9zfKWQu1-lkp@intel.com/config)
compiler: sh4-linux-gcc (GCC) 12.1.0
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://github.com/intel-lab-lkp/linux/commit/7b6c02f1e51855f1a4b862f3b638721cd64077d4
        git remote add linux-review https://github.com/intel-lab-lkp/linux
        git fetch --no-tags linux-review Peng-Fan-OSS/imx-support-i-MX93-SRC-and-mediamix-blk-ctrl/20220822-163300
        git checkout 7b6c02f1e51855f1a4b862f3b638721cd64077d4
        # save the config file
        mkdir build_dir && cp config build_dir/.config
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0 make.cross W=1 O=build_dir ARCH=sh SHELL=/bin/bash drivers/soc/imx/

If you fix the issue, kindly add following tag where applicable
Reported-by: kernel test robot <lkp@intel.com>

All errors (new ones prefixed by >>):

   drivers/soc/imx/imx93-blk-ctrl.c: In function 'imx93_blk_ctrl_probe':
>> drivers/soc/imx/imx93-blk-ctrl.c:214:35: error: 'SZ_4K' undeclared (first use in this function)
     214 |                 .max_register   = SZ_4K,
         |                                   ^~~~~
   drivers/soc/imx/imx93-blk-ctrl.c:214:35: note: each undeclared identifier is reported only once for each function it appears in


vim +/SZ_4K +214 drivers/soc/imx/imx93-blk-ctrl.c

   198	
   199	static int imx93_blk_ctrl_probe(struct platform_device *pdev)
   200	{
   201		struct device *dev = &pdev->dev;
   202		const struct imx93_blk_ctrl_data *bc_data = of_device_get_match_data(dev);
   203		const struct imx93_blk_ctrl_domain_data *bus = bc_data->bus;
   204		struct imx93_blk_ctrl *bc;
   205		void __iomem *base;
   206		int i, ret;
   207	
   208		struct regmap_config regmap_config = {
   209			.reg_bits	= 32,
   210			.val_bits	= 32,
   211			.reg_stride	= 4,
   212			.rd_table	= bus->reg_access_table,
   213			.wr_table	= bus->reg_access_table,
 > 214			.max_register   = SZ_4K,
   215		};
   216	
   217		bc = devm_kzalloc(dev, sizeof(*bc), GFP_KERNEL);
   218		if (!bc)
   219			return -ENOMEM;
   220	
   221		bc->dev = dev;
   222	
   223		base = devm_platform_ioremap_resource(pdev, 0);
   224		if (IS_ERR(base))
   225			return PTR_ERR(base);
   226	
   227		bc->regmap = devm_regmap_init_mmio(dev, base, &regmap_config);
   228		if (IS_ERR(bc->regmap))
   229			return dev_err_probe(dev, PTR_ERR(bc->regmap),
   230					     "failed to init regmap\n");
   231	
   232		bc->domains = devm_kcalloc(dev, bc_data->num_domains + 1,
   233					   sizeof(struct imx93_blk_ctrl_domain),
   234					   GFP_KERNEL);
   235		if (!bc->domains)
   236			return -ENOMEM;
   237	
   238		bc->onecell_data.num_domains = bc_data->num_domains;
   239		bc->onecell_data.xlate = imx93_blk_ctrl_xlate;
   240		bc->onecell_data.domains =
   241			devm_kcalloc(dev, bc_data->num_domains,
   242				     sizeof(struct generic_pm_domain *), GFP_KERNEL);
   243		if (!bc->onecell_data.domains)
   244			return -ENOMEM;
   245	
   246		for (i = 0; i < bus->num_clks; i++)
   247			bc->clks[i].id = bus->clk_names[i];
   248		bc->num_clks = bus->num_clks;
   249	
   250		ret = devm_clk_bulk_get(dev, bc->num_clks, bc->clks);
   251		if (ret) {
   252			dev_err_probe(dev, ret, "failed to get bus clock\n");
   253			return ret;
   254		}
   255	
   256		for (i = 0; i < bc_data->num_domains; i++) {
   257			const struct imx93_blk_ctrl_domain_data *data = &bc_data->domains[i];
   258			struct imx93_blk_ctrl_domain *domain = &bc->domains[i];
   259			int j;
   260	
   261			domain->data = data;
   262	
   263			for (j = 0; j < data->num_clks; j++)
   264				domain->clks[j].id = data->clk_names[j];
   265	
   266			ret = devm_clk_bulk_get(dev, data->num_clks, domain->clks);
   267			if (ret) {
   268				dev_err_probe(dev, ret, "failed to get clock\n");
   269				goto cleanup_pds;
   270			}
   271	
   272			domain->genpd.name = data->name;
   273			domain->genpd.power_on = imx93_blk_ctrl_power_on;
   274			domain->genpd.power_off = imx93_blk_ctrl_power_off;
   275			domain->bc = bc;
   276	
   277			ret = pm_genpd_init(&domain->genpd, NULL, true);
   278			if (ret) {
   279				dev_err_probe(dev, ret, "failed to init power domain\n");
   280				goto cleanup_pds;
   281			}
   282	
   283			bc->onecell_data.domains[i] = &domain->genpd;
   284		}
   285	
   286		pm_runtime_enable(dev);
   287	
   288		ret = of_genpd_add_provider_onecell(dev->of_node, &bc->onecell_data);
   289		if (ret) {
   290			dev_err_probe(dev, ret, "failed to add power domain provider\n");
   291			goto cleanup_pds;
   292		}
   293	
   294		dev_set_drvdata(dev, bc);
   295	
   296		return 0;
   297	
   298	cleanup_pds:
   299		for (i--; i >= 0; i--)
   300			pm_genpd_remove(&bc->domains[i].genpd);
   301	
   302		return ret;
   303	}
   304	

-- 
0-DAY CI Kernel Test Service
https://01.org/lkp