devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH 0/3] Fix ti,sci-inta/intr and mmc dtbs_check warnings for TI K3 platforms
@ 2022-08-19 19:07 Apurva Nandan
  2022-08-19 19:07 ` [PATCH 1/3] dt-bindings: irqchip: ti,sci-inta: Fix warning '#interrupt-cells' was unexpected Apurva Nandan
                   ` (2 more replies)
  0 siblings, 3 replies; 8+ messages in thread
From: Apurva Nandan @ 2022-08-19 19:07 UTC (permalink / raw)
  To: Nishanth Menon, Tero Kristo, Santosh Shilimkar, Thomas Gleixner,
	Marc Zyngier, Rob Herring, Krzysztof Kozlowski, Ulf Hansson,
	linux-arm-kernel, linux-kernel, devicetree, linux-mmc
  Cc: Apurva Nandan, Hari Nagalla

This series fixes the following warnings common across all TI K3
platforms:

k3-j721e-common-proc-board.dtb: interrupt-controller@33d00000: Unevaluated properties are not allowed ('#interrupt-cells' was unexpected)
From schema: linux/Documentation/devicetree/bindings/interrupt-controller/ti,sci-inta.yaml

k3-j721s2-common-proc-board.dtb: mmc@4f80000: Unevaluated properties are not allowed ('dma-coherent' was unexpected)
From schema: linux/Documentation/devicetree/bindings/mmc/sdhci-am654.yaml

k3-j721s2-common-proc-board.dtb: interrupt-controller@310e0000: Unevaluated properties are not allowed ('reg' was unexpected)
From schema: linux/Documentation/devicetree/bindings/interrupt-controller/ti,sci-intr.yaml

Apurva Nandan (3):
  dt-bindings: irqchip: ti, sci-intr/inta: Fix warning
    '#interrupt-cells' was unexpected
  dt-bindings: mmc: Fix 'dma-coherent' was unexpected
  dt-bindings: interrupt-controller: Fix 'reg' was unexpected

 .../devicetree/bindings/interrupt-controller/ti,sci-inta.yaml  | 3 +++
 .../devicetree/bindings/interrupt-controller/ti,sci-intr.yaml  | 3 +++
 Documentation/devicetree/bindings/mmc/sdhci-am654.yaml         | 3 +++
 3 files changed, 9 insertions(+)

-- 
2.17.1


^ permalink raw reply	[flat|nested] 8+ messages in thread

* [PATCH 1/3] dt-bindings: irqchip: ti,sci-inta: Fix warning '#interrupt-cells' was unexpected
  2022-08-19 19:07 [PATCH 0/3] Fix ti,sci-inta/intr and mmc dtbs_check warnings for TI K3 platforms Apurva Nandan
@ 2022-08-19 19:07 ` Apurva Nandan
  2022-08-22 19:14   ` Rob Herring
  2022-08-19 19:07 ` [PATCH 2/3] dt-bindings: mmc: Fix 'dma-coherent' " Apurva Nandan
  2022-08-19 19:07 ` [PATCH 3/3] dt-bindings: interrupt-controller: Fix 'reg' " Apurva Nandan
  2 siblings, 1 reply; 8+ messages in thread
From: Apurva Nandan @ 2022-08-19 19:07 UTC (permalink / raw)
  To: Nishanth Menon, Tero Kristo, Santosh Shilimkar, Thomas Gleixner,
	Marc Zyngier, Rob Herring, Krzysztof Kozlowski, Ulf Hansson,
	linux-arm-kernel, linux-kernel, devicetree, linux-mmc
  Cc: Apurva Nandan, Hari Nagalla

#interrupt-cells = <0> property is required in device tree for
ti,sci-inta nodes, or else we will have following warning when building
device tree files with W=2 warning level.

arch/arm64/boot/dts/ti/k3-j721e-main.dtsi:147.51-156.5: Warning (interrupt_provider): /bus@100000/main-navss/interrupt-controller@33d00000: Missing #interrupt-cells in interrupt provider

And further, #interrupt-cells is required to be in yaml bindings as well
to prevent following schema warnings:

k3-j721e-common-proc-board.dtb: interrupt-controller@33d00000: Unevaluated properties are not allowed ('#interrupt-cells' was unexpected)
From schema: linux/Documentation/devicetree/bindings/interrupt-controller/ti,sci-inta.yaml

Add #interrupt-cells property in ti,sci-inta.yaml

Signed-off-by: Apurva Nandan <a-nandan@ti.com>
---
 .../devicetree/bindings/interrupt-controller/ti,sci-inta.yaml  | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/Documentation/devicetree/bindings/interrupt-controller/ti,sci-inta.yaml b/Documentation/devicetree/bindings/interrupt-controller/ti,sci-inta.yaml
index 88c46e61732e..1151518859bd 100644
--- a/Documentation/devicetree/bindings/interrupt-controller/ti,sci-inta.yaml
+++ b/Documentation/devicetree/bindings/interrupt-controller/ti,sci-inta.yaml
@@ -59,6 +59,9 @@ properties:
 
   interrupt-controller: true
 
+  '#interrupt-cells':
+    const: 0
+
   msi-controller: true
 
   ti,interrupt-ranges:
-- 
2.17.1


^ permalink raw reply related	[flat|nested] 8+ messages in thread

* [PATCH 2/3] dt-bindings: mmc: Fix 'dma-coherent' was unexpected
  2022-08-19 19:07 [PATCH 0/3] Fix ti,sci-inta/intr and mmc dtbs_check warnings for TI K3 platforms Apurva Nandan
  2022-08-19 19:07 ` [PATCH 1/3] dt-bindings: irqchip: ti,sci-inta: Fix warning '#interrupt-cells' was unexpected Apurva Nandan
@ 2022-08-19 19:07 ` Apurva Nandan
  2022-08-22 19:16   ` Rob Herring
  2022-08-26  9:16   ` Ulf Hansson
  2022-08-19 19:07 ` [PATCH 3/3] dt-bindings: interrupt-controller: Fix 'reg' " Apurva Nandan
  2 siblings, 2 replies; 8+ messages in thread
From: Apurva Nandan @ 2022-08-19 19:07 UTC (permalink / raw)
  To: Nishanth Menon, Tero Kristo, Santosh Shilimkar, Thomas Gleixner,
	Marc Zyngier, Rob Herring, Krzysztof Kozlowski, Ulf Hansson,
	linux-arm-kernel, linux-kernel, devicetree, linux-mmc
  Cc: Apurva Nandan, Hari Nagalla

dma-coherent is mentioned in almost all TI K3 platform mmc
nodes. Fix warning generated due to its missing match in
yaml schema.

Signed-off-by: Apurva Nandan <a-nandan@ti.com>
---
 Documentation/devicetree/bindings/mmc/sdhci-am654.yaml | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/Documentation/devicetree/bindings/mmc/sdhci-am654.yaml b/Documentation/devicetree/bindings/mmc/sdhci-am654.yaml
index 0ab07759b472..ea9121fb188d 100644
--- a/Documentation/devicetree/bindings/mmc/sdhci-am654.yaml
+++ b/Documentation/devicetree/bindings/mmc/sdhci-am654.yaml
@@ -51,6 +51,9 @@ properties:
 
   sdhci-caps-mask: true
 
+  dma-coherent:
+    type: boolean
+
   # PHY output tap delays:
   # Used to delay the data valid window and align it to the sampling clock.
   # Binding needs to be provided for each supported speed mode otherwise the
-- 
2.17.1


^ permalink raw reply related	[flat|nested] 8+ messages in thread

* [PATCH 3/3] dt-bindings: interrupt-controller: Fix 'reg' was unexpected
  2022-08-19 19:07 [PATCH 0/3] Fix ti,sci-inta/intr and mmc dtbs_check warnings for TI K3 platforms Apurva Nandan
  2022-08-19 19:07 ` [PATCH 1/3] dt-bindings: irqchip: ti,sci-inta: Fix warning '#interrupt-cells' was unexpected Apurva Nandan
  2022-08-19 19:07 ` [PATCH 2/3] dt-bindings: mmc: Fix 'dma-coherent' " Apurva Nandan
@ 2022-08-19 19:07 ` Apurva Nandan
  2022-08-22 19:16   ` Rob Herring
  2 siblings, 1 reply; 8+ messages in thread
From: Apurva Nandan @ 2022-08-19 19:07 UTC (permalink / raw)
  To: Nishanth Menon, Tero Kristo, Santosh Shilimkar, Thomas Gleixner,
	Marc Zyngier, Rob Herring, Krzysztof Kozlowski, Ulf Hansson,
	linux-arm-kernel, linux-kernel, devicetree, linux-mmc
  Cc: Apurva Nandan, Hari Nagalla

Fix the following warning in dtbs_check
interrupt-controller@a00000: Unevaluated properties are not allowed ('reg' was unexpected)

Add the reg property in the schema.

Signed-off-by: Apurva Nandan <a-nandan@ti.com>
---
 .../devicetree/bindings/interrupt-controller/ti,sci-intr.yaml  | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/Documentation/devicetree/bindings/interrupt-controller/ti,sci-intr.yaml b/Documentation/devicetree/bindings/interrupt-controller/ti,sci-intr.yaml
index e12aee42b126..c99cc7323c71 100644
--- a/Documentation/devicetree/bindings/interrupt-controller/ti,sci-intr.yaml
+++ b/Documentation/devicetree/bindings/interrupt-controller/ti,sci-intr.yaml
@@ -58,6 +58,9 @@ properties:
         1 = If intr supports edge triggered interrupts.
         4 = If intr supports level triggered interrupts.
 
+  reg:
+    maxItems: 1
+
   interrupt-controller: true
 
   '#interrupt-cells':
-- 
2.17.1


^ permalink raw reply related	[flat|nested] 8+ messages in thread

* Re: [PATCH 1/3] dt-bindings: irqchip: ti,sci-inta: Fix warning '#interrupt-cells' was unexpected
  2022-08-19 19:07 ` [PATCH 1/3] dt-bindings: irqchip: ti,sci-inta: Fix warning '#interrupt-cells' was unexpected Apurva Nandan
@ 2022-08-22 19:14   ` Rob Herring
  0 siblings, 0 replies; 8+ messages in thread
From: Rob Herring @ 2022-08-22 19:14 UTC (permalink / raw)
  To: Apurva Nandan
  Cc: Santosh Shilimkar, linux-kernel, Nishanth Menon, linux-arm-kernel,
	devicetree, Tero Kristo, Krzysztof Kozlowski, Marc Zyngier,
	Hari Nagalla, Rob Herring, linux-mmc, Thomas Gleixner,
	Ulf Hansson

On Sat, 20 Aug 2022 00:37:27 +0530, Apurva Nandan wrote:
> #interrupt-cells = <0> property is required in device tree for
> ti,sci-inta nodes, or else we will have following warning when building
> device tree files with W=2 warning level.
> 
> arch/arm64/boot/dts/ti/k3-j721e-main.dtsi:147.51-156.5: Warning (interrupt_provider): /bus@100000/main-navss/interrupt-controller@33d00000: Missing #interrupt-cells in interrupt provider
> 
> And further, #interrupt-cells is required to be in yaml bindings as well
> to prevent following schema warnings:
> 
> k3-j721e-common-proc-board.dtb: interrupt-controller@33d00000: Unevaluated properties are not allowed ('#interrupt-cells' was unexpected)
> From schema: linux/Documentation/devicetree/bindings/interrupt-controller/ti,sci-inta.yaml
> 
> Add #interrupt-cells property in ti,sci-inta.yaml
> 
> Signed-off-by: Apurva Nandan <a-nandan@ti.com>
> ---
>  .../devicetree/bindings/interrupt-controller/ti,sci-inta.yaml  | 3 +++
>  1 file changed, 3 insertions(+)
> 

Acked-by: Rob Herring <robh@kernel.org>

^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: [PATCH 2/3] dt-bindings: mmc: Fix 'dma-coherent' was unexpected
  2022-08-19 19:07 ` [PATCH 2/3] dt-bindings: mmc: Fix 'dma-coherent' " Apurva Nandan
@ 2022-08-22 19:16   ` Rob Herring
  2022-08-26  9:16   ` Ulf Hansson
  1 sibling, 0 replies; 8+ messages in thread
From: Rob Herring @ 2022-08-22 19:16 UTC (permalink / raw)
  To: Apurva Nandan
  Cc: linux-arm-kernel, Nishanth Menon, Ulf Hansson, devicetree,
	Thomas Gleixner, Santosh Shilimkar, Tero Kristo,
	Krzysztof Kozlowski, Marc Zyngier, linux-mmc, Rob Herring,
	linux-kernel, Hari Nagalla

On Sat, 20 Aug 2022 00:37:28 +0530, Apurva Nandan wrote:
> dma-coherent is mentioned in almost all TI K3 platform mmc
> nodes. Fix warning generated due to its missing match in
> yaml schema.
> 
> Signed-off-by: Apurva Nandan <a-nandan@ti.com>
> ---
>  Documentation/devicetree/bindings/mmc/sdhci-am654.yaml | 3 +++
>  1 file changed, 3 insertions(+)
> 

Acked-by: Rob Herring <robh@kernel.org>

^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: [PATCH 3/3] dt-bindings: interrupt-controller: Fix 'reg' was unexpected
  2022-08-19 19:07 ` [PATCH 3/3] dt-bindings: interrupt-controller: Fix 'reg' " Apurva Nandan
@ 2022-08-22 19:16   ` Rob Herring
  0 siblings, 0 replies; 8+ messages in thread
From: Rob Herring @ 2022-08-22 19:16 UTC (permalink / raw)
  To: Apurva Nandan
  Cc: Marc Zyngier, devicetree, Rob Herring, linux-mmc, Nishanth Menon,
	Krzysztof Kozlowski, Santosh Shilimkar, linux-arm-kernel,
	Tero Kristo, Ulf Hansson, linux-kernel, Hari Nagalla,
	Thomas Gleixner

On Sat, 20 Aug 2022 00:37:29 +0530, Apurva Nandan wrote:
> Fix the following warning in dtbs_check
> interrupt-controller@a00000: Unevaluated properties are not allowed ('reg' was unexpected)
> 
> Add the reg property in the schema.
> 
> Signed-off-by: Apurva Nandan <a-nandan@ti.com>
> ---
>  .../devicetree/bindings/interrupt-controller/ti,sci-intr.yaml  | 3 +++
>  1 file changed, 3 insertions(+)
> 

Acked-by: Rob Herring <robh@kernel.org>

^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: [PATCH 2/3] dt-bindings: mmc: Fix 'dma-coherent' was unexpected
  2022-08-19 19:07 ` [PATCH 2/3] dt-bindings: mmc: Fix 'dma-coherent' " Apurva Nandan
  2022-08-22 19:16   ` Rob Herring
@ 2022-08-26  9:16   ` Ulf Hansson
  1 sibling, 0 replies; 8+ messages in thread
From: Ulf Hansson @ 2022-08-26  9:16 UTC (permalink / raw)
  To: Apurva Nandan
  Cc: Nishanth Menon, Tero Kristo, Santosh Shilimkar, Thomas Gleixner,
	Marc Zyngier, Rob Herring, Krzysztof Kozlowski, linux-arm-kernel,
	linux-kernel, devicetree, linux-mmc, Hari Nagalla

On Fri, 19 Aug 2022 at 21:07, Apurva Nandan <a-nandan@ti.com> wrote:
>
> dma-coherent is mentioned in almost all TI K3 platform mmc
> nodes. Fix warning generated due to its missing match in
> yaml schema.
>
> Signed-off-by: Apurva Nandan <a-nandan@ti.com>

Applied for next, thanks!

Kind regards
Uffe


> ---
>  Documentation/devicetree/bindings/mmc/sdhci-am654.yaml | 3 +++
>  1 file changed, 3 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/mmc/sdhci-am654.yaml b/Documentation/devicetree/bindings/mmc/sdhci-am654.yaml
> index 0ab07759b472..ea9121fb188d 100644
> --- a/Documentation/devicetree/bindings/mmc/sdhci-am654.yaml
> +++ b/Documentation/devicetree/bindings/mmc/sdhci-am654.yaml
> @@ -51,6 +51,9 @@ properties:
>
>    sdhci-caps-mask: true
>
> +  dma-coherent:
> +    type: boolean
> +
>    # PHY output tap delays:
>    # Used to delay the data valid window and align it to the sampling clock.
>    # Binding needs to be provided for each supported speed mode otherwise the
> --
> 2.17.1
>

^ permalink raw reply	[flat|nested] 8+ messages in thread

end of thread, other threads:[~2022-08-26  9:17 UTC | newest]

Thread overview: 8+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-08-19 19:07 [PATCH 0/3] Fix ti,sci-inta/intr and mmc dtbs_check warnings for TI K3 platforms Apurva Nandan
2022-08-19 19:07 ` [PATCH 1/3] dt-bindings: irqchip: ti,sci-inta: Fix warning '#interrupt-cells' was unexpected Apurva Nandan
2022-08-22 19:14   ` Rob Herring
2022-08-19 19:07 ` [PATCH 2/3] dt-bindings: mmc: Fix 'dma-coherent' " Apurva Nandan
2022-08-22 19:16   ` Rob Herring
2022-08-26  9:16   ` Ulf Hansson
2022-08-19 19:07 ` [PATCH 3/3] dt-bindings: interrupt-controller: Fix 'reg' " Apurva Nandan
2022-08-22 19:16   ` Rob Herring

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).