From: Rob Herring <robh@kernel.org>
To: Andrew Lunn <andrew@lunn.ch>
Cc: Gregory Clement <gregory.clement@bootlin.com>,
arm-soc <arm@kernel.org>,
Device Tree <devicetree@vger.kernel.org>
Subject: Re: [PATCH 03/11] DT: pinctrl: Convert marvell,kirkwood-pintctrl to YAML
Date: Mon, 22 Aug 2022 16:16:49 -0500 [thread overview]
Message-ID: <20220822211649.GC808626-robh@kernel.org> (raw)
In-Reply-To: <20220820194804.3352415-4-andrew@lunn.ch>
On Sat, Aug 20, 2022 at 09:47:56PM +0200, Andrew Lunn wrote:
> Convert the text description to YAML. To keep the YAML versions
> readable, add a file per compatible.
>
> Signed-off-by: Andrew Lunn <andrew@lunn.ch>
> ---
> .../pinctrl/marvell,88f6180-pinctrl.yaml | 73 ++++
> .../pinctrl/marvell,88f6190-pinctrl.yaml | 73 ++++
> .../pinctrl/marvell,88f6192-pinctrl.yaml | 73 ++++
> .../pinctrl/marvell,88f6281-pinctrl.yaml | 74 ++++
> .../pinctrl/marvell,88f6282-pinctrl.yaml | 74 ++++
> .../pinctrl/marvell,98dx1135-pinctrl.yaml | 72 ++++
> .../pinctrl/marvell,98dx4122-pinctrl.yaml | 71 ++++
> .../bindings/pinctrl/marvell,ac5-pinctrl.yaml | 14 +-
> .../pinctrl/marvell,kirkwood-pinctrl.txt | 359 ------------------
> 9 files changed, 517 insertions(+), 366 deletions(-)
> create mode 100644 Documentation/devicetree/bindings/pinctrl/marvell,88f6180-pinctrl.yaml
> create mode 100644 Documentation/devicetree/bindings/pinctrl/marvell,88f6190-pinctrl.yaml
> create mode 100644 Documentation/devicetree/bindings/pinctrl/marvell,88f6192-pinctrl.yaml
> create mode 100644 Documentation/devicetree/bindings/pinctrl/marvell,88f6281-pinctrl.yaml
> create mode 100644 Documentation/devicetree/bindings/pinctrl/marvell,88f6282-pinctrl.yaml
> create mode 100644 Documentation/devicetree/bindings/pinctrl/marvell,98dx1135-pinctrl.yaml
> create mode 100644 Documentation/devicetree/bindings/pinctrl/marvell,98dx4122-pinctrl.yaml
> delete mode 100644 Documentation/devicetree/bindings/pinctrl/marvell,kirkwood-pinctrl.txt
>
> diff --git a/Documentation/devicetree/bindings/pinctrl/marvell,88f6180-pinctrl.yaml b/Documentation/devicetree/bindings/pinctrl/marvell,88f6180-pinctrl.yaml
> new file mode 100644
> index 000000000000..c3c679f95274
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/pinctrl/marvell,88f6180-pinctrl.yaml
> @@ -0,0 +1,73 @@
> +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/pinctrl/marvell,88f6180-pinctrl.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Marvell Kirkwood 88f6180 pin controller
> +
> +maintainers:
> + - Andrew Lunn <andrew@lunn.ch>
> +
> +description:
> + Bindings for Marvell's Kirkwood 88F6180 memory-mapped pin controller.
> +
> +properties:
> + compatible:
> + items:
> + - const: marvell,88f6180-pinctrl
> +
> + reg:
> + maxItems: 1
> +
> +patternProperties:
> + '^pmx-.*$':
> + type: object
> + $ref: pinmux-node.yaml#
What from this schema applies here? Looks like nothing to me.
You need:
additionalProperties: false
Or 'unevaluatedProperties: false' if properties from pinmux-node.yaml
apply.
> +
> + properties:
> + marvell,function:
> + $ref: "/schemas/types.yaml#/definitions/string"
> + description:
> + Indicates the function to select.
> + enum: [ audio, gpio, gpo, mii, nand, pex, ptp, ptp-1, ptp-2, sdio,
> + spi, sysrst, twsi0, uart0, uart1 ]
> +
> + marvell,pins:
> + $ref: /schemas/types.yaml#/definitions/string-array
> + description:
> + Array of MPP pins to be used for the given function.
> + minItems: 1
> + items:
> + enum: [ mpp0, mpp1, mpp2, mpp3, mpp4, mpp5, mpp6, mpp7, mpp8, mpp9,
> + mpp10, mpp11, mpp12, mpp13, mpp14, mpp15, mpp16, mpp17,
> + mpp18, mpp19, mpp20, mpp21, mpp22, mpp23, mpp24, mpp25,
> + mpp26, mpp27, mpp28, mpp29, mpp30, mpp31, mpp32, mpp33,
> + mpp34, mpp35, mpp36, mpp37, mpp38, mpp39, mpp40, mpp41,
> + mpp42, mpp43, mpp44 ]
pattern: '^mpp([0-9]|[1-3][0-9]|4[0-4])$'
Surely one or both of these properties are required?
Similar comments on the rest.
> +
> +allOf:
> + - $ref: "pinctrl.yaml#"
> +
> +required:
> + - compatible
> + - reg
> +
> +additionalProperties: false
> +
> +examples:
> + - |
> + pinctrl@80020100 {
> + compatible = "marvell,88f6180-pinctrl";
> + reg = <0x80020100 0x20>;
> +
> + pmx_spi: pmx-spidc {
> + marvell,pins = "mpp0", "mpp1", "mpp2", "mpp3";
> + marvell,function = "spi";
> + };
> +
> + pmx_spic_gpio: pmx-gpio-spi {
> + marvell,pins = "mpp26", "mpp27";
> + marvell,function = "gpio";
> + };
> + };
> diff --git a/Documentation/devicetree/bindings/pinctrl/marvell,88f6190-pinctrl.yaml b/Documentation/devicetree/bindings/pinctrl/marvell,88f6190-pinctrl.yaml
> new file mode 100644
> index 000000000000..46f0e61c3730
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/pinctrl/marvell,88f6190-pinctrl.yaml
> @@ -0,0 +1,73 @@
> +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/pinctrl/marvell,88f6190-pinctrl.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Marvell Kirkwood 88f6190 pin controller
> +
> +maintainers:
> + - Andrew Lunn <andrew@lunn.ch>
> +
> +description:
> + Bindings for Marvell's Kirkwood 88F6190 memory-mapped pin controller.
> +
> +properties:
> + compatible:
> + items:
> + - const: marvell,88f6190-pinctrl
> +
> + reg:
> + maxItems: 1
> +
> +patternProperties:
> + 'pmx-.*$':
> + type: object
> + $ref: pinmux-node.yaml#
> +
> + properties:
> + marvell,function:
> + $ref: "/schemas/types.yaml#/definitions/string"
> + description:
> + Indicates the function to select.
> + enum: [ ge1, gpio, gpo, mii, mii-1, nand, pex, ptp, ptp-1, ptp-2,
> + sata0, sdio, spi, sysrst, twsi0, uart0, uart1 ]
> +
> + marvell,pins:
> + $ref: /schemas/types.yaml#/definitions/string-array
> + description:
> + Array of MPP pins to be used for the given function.
> + minItems: 1
> + items:
> + enum: [ mpp0, mpp1, mpp2, mpp3, mpp4, mpp5, mpp6, mpp7, mpp8, mpp9,
> + mpp10, mpp11, mpp12, mpp13, mpp14, mpp15, mpp16, mpp17,
> + mpp18, mpp19, mpp20, mpp21, mpp22, mpp23, mpp24, mpp25,
> + mpp26, mpp27, mpp28, mpp29, mpp30, mpp31, mpp32, mpp33,
> + mpp34, mpp35, mpp36, mpp37, mpp38, mpp39, mpp40, mpp41,
> + mpp42, mpp43, mpp44 ]
> +
> +allOf:
> + - $ref: "pinctrl.yaml#"
> +
> +required:
> + - compatible
> + - reg
> +
> +additionalProperties: false
> +
> +examples:
> + - |
> + pinctrl@80020100 {
> + compatible = "marvell,88f6180-pinctrl";
> + reg = <0x80020100 0x20>;
> +
> + pmx_spi: pmx-spidc {
> + marvell,pins = "mpp0", "mpp1", "mpp2", "mpp3";
> + marvell,function = "spi";
> + };
> +
> + pmx_spi_gpio: pmx-gpio-spi {
> + marvell,pins = "mpp26", "mpp27";
> + marvell,function = "gpio";
> + };
> + };
> diff --git a/Documentation/devicetree/bindings/pinctrl/marvell,88f6192-pinctrl.yaml b/Documentation/devicetree/bindings/pinctrl/marvell,88f6192-pinctrl.yaml
> new file mode 100644
> index 000000000000..82f8ce528d13
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/pinctrl/marvell,88f6192-pinctrl.yaml
> @@ -0,0 +1,73 @@
> +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/pinctrl/marvell,88f6192-pinctrl.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Marvell Kirkwood 88f6192 pin controller
> +
> +maintainers:
> + - Andrew Lunn <andrew@lunn.ch>
> +
> +description:
> + Bindings for Marvell's Kirkwood 88F6192 memory-mapped pin controller.
> +
> +properties:
> + compatible:
> + items:
> + - const: marvell,88f6192-pinctrl
> +
> + reg:
> + maxItems: 1
> +
> +patternProperties:
> + '^pmx-.*$':
> + type: object
> + $ref: pinmux-node.yaml#
> +
> + properties:
> + marvell,function:
> + $ref: "/schemas/types.yaml#/definitions/string"
> + description:
> + Indicates the function to select.
> + enum: [ audio, ge1, gpio, gpo, mii, mii-1, nand, pex, ptp, ptp-1, ptp-2,
> + sata0, sata1, sdio, spi, sysrst, tdm, ts, twsi0, uart0, uart1 ]
> +
> + marvell,pins:
> + $ref: /schemas/types.yaml#/definitions/string-array
> + description:
> + Array of MPP pins to be used for the given function.
> + minItems: 1
> + items:
> + enum: [ mpp0, mpp1, mpp2, mpp3, mpp4, mpp5, mpp6, mpp7, mpp8, mpp9,
> + mpp10, mpp11, mpp12, mpp13, mpp14, mpp15, mpp16, mpp17,
> + mpp18, mpp19, mpp20, mpp21, mpp22, mpp23, mpp24, mpp25,
> + mpp26, mpp27, mpp28, mpp29, mpp30, mpp31, mpp32, mpp33,
> + mpp34, mpp35, mpp36, mpp37, mpp38, mpp39, mpp40, mpp41,
> + mpp42, mpp43, mpp44 ]
> +
> +allOf:
> + - $ref: "pinctrl.yaml#"
> +
> +required:
> + - compatible
> + - reg
> +
> +additionalProperties: false
> +
> +examples:
> + - |
> + pinctrl@80020100 {
> + compatible = "marvell,88f6180-pinctrl";
> + reg = <0x80020100 0x20>;
> +
> + pmx_spi: pmx-spidc {
> + marvell,pins = "mpp0", "mpp1", "mpp2", "mpp3";
> + marvell,function = "spi";
> + };
> +
> + pmx_spic_gpio: pmx-gpio-spi {
> + marvell,pins = "mpp26", "mpp27";
> + marvell,function = "gpio";
> + };
> + };
> diff --git a/Documentation/devicetree/bindings/pinctrl/marvell,88f6281-pinctrl.yaml b/Documentation/devicetree/bindings/pinctrl/marvell,88f6281-pinctrl.yaml
> new file mode 100644
> index 000000000000..1d0c5932ca59
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/pinctrl/marvell,88f6281-pinctrl.yaml
> @@ -0,0 +1,74 @@
> +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/pinctrl/marvell,88f6281-pinctrl.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Marvell Kirkwood 88f6281 pin controller
> +
> +maintainers:
> + - Andrew Lunn <andrew@lunn.ch>
> +
> +description:
> + Bindings for Marvell's Kirkwood 88F6281 memory-mapped pin controller.
> +
> +properties:
> + compatible:
> + items:
> + - const: marvell,88f6281-pinctrl
> +
> + reg:
> + maxItems: 1
> +
> +patternProperties:
> + '^pmx-':
> + type: object
> + $ref: pinmux-node.yaml#
> +
> + properties:
> + marvell,function:
> + $ref: "/schemas/types.yaml#/definitions/string"
> + description:
> + Indicates the function to select.
> + enum: [ audio, ge1, gpio, gpo, mii, mii-1, nand, pex, ptp, ptp-1, ptp-2,
> + sata0, sata1, sdio, spi, sysrst, tdm, ts, twsi0, twsi1, uart0,
> + uart1 ]
> +
> + marvell,pins:
> + $ref: /schemas/types.yaml#/definitions/string-array
> + description:
> + Array of MPP pins to be used for the given function.
> + minItems: 1
> + items:
> + enum: [ mpp0, mpp1, mpp2, mpp3, mpp4, mpp5, mpp6, mpp7, mpp8, mpp9,
> + mpp10, mpp11, mpp12, mpp13, mpp14, mpp15, mpp16, mpp17,
> + mpp18, mpp19, mpp20, mpp21, mpp22, mpp23, mpp24, mpp25,
> + mpp26, mpp27, mpp28, mpp29, mpp30, mpp31, mpp32, mpp33,
> + mpp34, mpp35, mpp36, mpp37, mpp38, mpp39, mpp40, mpp41,
> + mpp42, mpp43, mpp44, mpp45, mpp46, mpp47, mpp48, mpp49 ]
> +
> +allOf:
> + - $ref: "pinctrl.yaml#"
> +
> +required:
> + - compatible
> + - reg
> +
> +additionalProperties: false
> +
> +examples:
> + - |
> + pinctrl@80020100 {
> + compatible = "marvell,88f6180-pinctrl";
> + reg = <0x80020100 0x20>;
> +
> + pmx_spi: pmx-spi {
> + marvell,pins = "mpp0", "mpp1", "mpp2", "mpp3";
> + marvell,function = "spi";
> + };
> +
> + pmx_spi_gpio: pmx-gpio-spi {
> + marvell,pins = "mpp26", "mpp27";
> + marvell,function = "gpio";
> + };
> + };
> diff --git a/Documentation/devicetree/bindings/pinctrl/marvell,88f6282-pinctrl.yaml b/Documentation/devicetree/bindings/pinctrl/marvell,88f6282-pinctrl.yaml
> new file mode 100644
> index 000000000000..1365c392be9e
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/pinctrl/marvell,88f6282-pinctrl.yaml
> @@ -0,0 +1,74 @@
> +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/pinctrl/marvell,88f6282-pinctrl.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Marvell Kirkwood 88f6282 pin controller
> +
> +maintainers:
> + - Andrew Lunn <andrew@lunn.ch>
> +
> +description:
> + Bindings for Marvell's Kirkwood 88F6282 memory-mapped pin controller.
> +
> +properties:
> + compatible:
> + items:
> + - const: marvell,88f6282-pinctrl
> +
> + reg:
> + maxItems: 1
> +
> +patternProperties:
> + '^pmx-':
> + type: object
> + $ref: pinmux-node.yaml#
> +
> + properties:
> + marvell,function:
> + $ref: "/schemas/types.yaml#/definitions/string"
> + description:
> + Indicates the function to select.
> + enum: [ audio, ge1, gpio, gpo, lcd, mii, mii-1, nand, pex,
> + sata0, sata1, sdio, spi, sysrst, tdm, ts, twsi0, twsi1, uart0,
> + uart1 ]
> +
> + marvell,pins:
> + $ref: /schemas/types.yaml#/definitions/string-array
> + description:
> + Array of MPP pins to be used for the given function.
> + minItems: 1
> + items:
> + enum: [ mpp0, mpp1, mpp2, mpp3, mpp4, mpp5, mpp6, mpp7, mpp8, mpp9,
> + mpp10, mpp11, mpp12, mpp13, mpp14, mpp15, mpp16, mpp17,
> + mpp18, mpp19, mpp20, mpp21, mpp22, mpp23, mpp24, mpp25,
> + mpp26, mpp27, mpp28, mpp29, mpp30, mpp31, mpp32, mpp33,
> + mpp34, mpp35, mpp36, mpp37, mpp38, mpp39, mpp40, mpp41,
> + mpp42, mpp43, mpp44, mpp45, mpp46, mpp47, mpp48 ]
> +
> +allOf:
> + - $ref: "pinctrl.yaml#"
> +
> +required:
> + - compatible
> + - reg
> +
> +additionalProperties: false
> +
> +examples:
> + - |
> + pinctrl@80020100 {
> + compatible = "marvell,88f6180-pinctrl";
> + reg = <0x80020100 0x20>;
> +
> + pmx_spi: pmx-spidc {
> + marvell,pins = "mpp0", "mpp1", "mpp2", "mpp3";
> + marvell,function = "spi";
> + };
> +
> + pmx_spi_gpio: pmx-gpio-spi {
> + marvell,pins = "mpp26", "mpp27";
> + marvell,function = "gpio";
> + };
> + };
> diff --git a/Documentation/devicetree/bindings/pinctrl/marvell,98dx1135-pinctrl.yaml b/Documentation/devicetree/bindings/pinctrl/marvell,98dx1135-pinctrl.yaml
> new file mode 100644
> index 000000000000..38c1a48e7603
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/pinctrl/marvell,98dx1135-pinctrl.yaml
> @@ -0,0 +1,72 @@
> +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/pinctrl/marvell,98dx1135-pinctrl.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Marvell 98dx1135 pin controller
> +
> +maintainers:
> + - Andrew Lunn <andrew@lunn.ch>
> +
> +description:
> + Bindings for Marvell's 98DX1135 memory-mapped pin controller.
> +
> +properties:
> + compatible:
> + items:
> + - const: marvell,98dx1135-pinctrl
> +
> + reg:
> + maxItems: 1
> +
> +patternProperties:
> + '^pmx-':
> + type: object
> + $ref: pinmux-node.yaml#
> +
> + properties:
> + marvell,function:
> + $ref: "/schemas/types.yaml#/definitions/string"
> + description:
> + Indicates the function to select.
> + enum: [ gpio, gpo, nand, pex, spi, sysrst, twsi0, uart0, uart1 ]
> +
> + marvell,pins:
> + $ref: /schemas/types.yaml#/definitions/string-array
> + description:
> + Array of MPP pins to be used for the given function.
> + minItems: 1
> + items:
> + enum: [ mpp0, mpp1, mpp2, mpp3, mpp4, mpp5, mpp6, mpp7, mpp8, mpp9,
> + mpp10, mpp11, mpp12, mpp13, mpp14, mpp15, mpp16, mpp17,
> + mpp18, mpp19, mpp20, mpp21, mpp22, mpp23, mpp24, mpp25,
> + mpp26, mpp27, mpp28, mpp29, mpp30, mpp31, mpp32, mpp33,
> + mpp34, mpp35, mpp36, mpp37, mpp38, mpp39, mpp40, mpp41,
> + mpp42, mpp43, mpp44 ]
> +
> +allOf:
> + - $ref: "pinctrl.yaml#"
> +
> +required:
> + - compatible
> + - reg
> +
> +additionalProperties: false
> +
> +examples:
> + - |
> + pinctrl@80020100 {
> + compatible = "marvell,88f6180-pinctrl";
> + reg = <0x80020100 0x20>;
> +
> + pmx_spi: pmx-spidc {
> + marvell,pins = "mpp0", "mpp1", "mpp2", "mpp3";
> + marvell,function = "spi";
> + };
> +
> + pmx_spi_gpio: pmx-gpio-spi {
> + marvell,pins = "mpp26", "mpp27";
> + marvell,function = "gpio";
> + };
> + };
> diff --git a/Documentation/devicetree/bindings/pinctrl/marvell,98dx4122-pinctrl.yaml b/Documentation/devicetree/bindings/pinctrl/marvell,98dx4122-pinctrl.yaml
> new file mode 100644
> index 000000000000..32080220748c
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/pinctrl/marvell,98dx4122-pinctrl.yaml
> @@ -0,0 +1,71 @@
> +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/pinctrl/marvell,98dx4122-pinctrl.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Marvell 98dx4122 pin controller
> +
> +maintainers:
> + - Andrew Lunn <andrew@lunn.ch>
> +
> +description:
> + Bindings for Marvell's 98DX4122 memory-mapped pin controller.
> +
> +properties:
> + compatible:
> + items:
> + - const: marvell,98dx4122-pinctrl
> +
> + reg:
> + maxItems: 1
> +
> +patternProperties:
> + '^pmx-':
> + type: object
> + $ref: pinmux-node.yaml#
> +
> + properties:
> + marvell,function:
> + $ref: "/schemas/types.yaml#/definitions/string"
> + description:
> + Indicates the function to select.
> + enum: [ gpio, gpo, nand, pex, spi, sysrst, twsi0, uart0, uart1 ]
> +
> + marvell,pins:
> + $ref: /schemas/types.yaml#/definitions/string-array
> + description:
> + Array of MPP pins to be used for the given function.
> + minItems: 1
> + items:
> + enum: [ mpp0, mpp1, mpp2, mpp3, mpp4, mpp5, mpp6, mpp7, mpp8, mpp9,
> + mpp10, mpp11, mpp12, mpp13, mpp14, mpp15, mpp16, mpp17, mpp18,
> + mpp19, mpp20, mpp21, mpp22, mpp23, mpp24, mpp25, mpp26, mpp27,
> + mpp28, mpp29, mpp30, mpp31, mpp32, mpp33, mpp34, mpp35, mpp36,
> + mpp37, mpp38, mpp39, mpp40, mpp41, mpp42, mpp43, mpp44 ]
> +
> +allOf:
> + - $ref: "pinctrl.yaml#"
> +
> +required:
> + - compatible
> + - reg
> +
> +additionalProperties: false
> +
> +examples:
> + - |
> + pinctrl@80020100 {
> + compatible = "marvell,88f6180-pinctrl";
> + reg = <0x80020100 0x20>;
> +
> + pmx_spi: pmx-spidc {
> + marvell,pins = "mpp0", "mpp1", "mpp2", "mpp3";
> + marvell,function = "spi";
> + };
> +
> + pmx_spi_gpio: pmx-gpio-spi {
> + marvell,pins = "mpp26", "mpp27";
> + marvell,function = "gpio";
> + };
> + };
> diff --git a/Documentation/devicetree/bindings/pinctrl/marvell,ac5-pinctrl.yaml b/Documentation/devicetree/bindings/pinctrl/marvell,ac5-pinctrl.yaml
> index a651b2744caf..4109bf1a2e5f 100644
> --- a/Documentation/devicetree/bindings/pinctrl/marvell,ac5-pinctrl.yaml
> +++ b/Documentation/devicetree/bindings/pinctrl/marvell,ac5-pinctrl.yaml
This file isn't a conversion and deserves to be its own patch.
> @@ -21,7 +21,7 @@ properties:
> maxItems: 1
>
> patternProperties:
> - '-pins$':
> + '^pmx-':
> type: object
> $ref: pinmux-node.yaml#
>
> @@ -40,10 +40,10 @@ patternProperties:
> minItems: 1
> items:
> enum: [ mpp0, mpp1, mpp2, mpp3, mpp4, mpp5, mpp6, mpp7, mpp8, mpp9,
> - mpp10, mpp11, mpp12, mpp13, mpp14, mpp15, mpp16, mpp17, mpp18, mpp19,
> - mpp20, mpp21, mpp22, mpp23, mpp24, mpp25, mpp26, mpp27, mpp28, mpp29,
> - mpp30, mpp31, mpp32, mpp33, mpp34, mpp35, mpp36, mpp37, mpp38, mpp39,
> - mpp40, mpp41, mpp42, mpp43, mpp44, mpp45 ]
> + mpp10, mpp11, mpp12, mpp13, mpp14, mpp15, mpp16, mpp17, mpp18,
> + mpp19, mpp20, mpp21, mpp22, mpp23, mpp24, mpp25, mpp26, mpp27,
> + mpp28, mpp29, mpp30, mpp31, mpp32, mpp33, mpp34, mpp35, mpp36,
> + mpp37, mpp38, mpp39, mpp40, mpp41, mpp42, mpp43, mpp44, mpp45 ]
>
> allOf:
> - $ref: "pinctrl.yaml#"
> @@ -60,12 +60,12 @@ examples:
> compatible = "marvell,ac5-pinctrl";
> reg = <0x80020100 0x20>;
>
> - i2c0_pins: i2c0-pins {
> + pmx_i2c0_pins: pmx-i2c0 {
> marvell,pins = "mpp26", "mpp27";
> marvell,function = "i2c0";
> };
>
> - i2c0_gpio: i2c0-gpio-pins {
> + pmx_i2c0_gpio: pmx-gpio-i2c0 {
> marvell,pins = "mpp26", "mpp27";
> marvell,function = "gpio";
> };
next prev parent reply other threads:[~2022-08-22 21:16 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-20 19:47 [PATCH 00/11] Start converting MVEBU bindings to YAML Andrew Lunn
2022-08-20 19:47 ` [PATCH 01/11] DT: RTC: orion-rtc: Convert " Andrew Lunn
2022-08-22 20:49 ` Rob Herring
2022-08-22 20:55 ` Rob Herring
2022-08-20 19:47 ` [PATCH 02/11] DT: thermal: marvell,kirkwood-thermal: " Andrew Lunn
2022-08-20 19:47 ` [PATCH 03/11] DT: pinctrl: Convert marvell,kirkwood-pintctrl " Andrew Lunn
2022-08-22 21:16 ` Rob Herring [this message]
2022-08-20 19:47 ` [PATCH 04/11] DT: USB: Convert ehci-orion " Andrew Lunn
2022-08-21 20:21 ` Rob Herring
2022-08-20 19:47 ` [PATCH 05/11] DT: watchdog: Convert marvel.txt " Andrew Lunn
2022-08-21 20:21 ` Rob Herring
2022-08-22 0:20 ` Andrew Lunn
2022-08-22 13:47 ` Rob Herring
2022-08-20 19:47 ` [PATCH 06/11] arm: DT: kirkwood/orion5: Rename watchdog node Andrew Lunn
2022-08-20 19:48 ` [PATCH 07/11] DT: nand-controller: Reflect reality of marvell,orion-nand Andrew Lunn
2022-08-21 20:21 ` Rob Herring
2022-08-20 19:48 ` [PATCH 08/11] DT: mtd: Convert orion-nand to YAML Andrew Lunn
2022-08-21 20:21 ` Rob Herring
2022-08-22 0:48 ` Andrew Lunn
2022-08-22 13:43 ` Rob Herring
2022-08-20 19:48 ` [PATCH 09/11] arm: DT: kirkwood.dtsi: Rename nand to nand-controller Andrew Lunn
2022-08-20 19:48 ` [PATCH 10/11] DT: timer: Convert marvell,orion-timer.txt to YAML Andrew Lunn
2022-08-20 19:48 ` [PATCH 11/11] DT: clock: Convert mvebu-gated-clock.txt " Andrew Lunn
2022-08-22 13:49 ` [PATCH 00/11] Start converting MVEBU bindings " Rob Herring
2022-08-22 13:53 ` Rob Herring
2022-08-22 14:28 ` Andrew Lunn
2022-08-30 18:58 ` Rob Herring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220822211649.GC808626-robh@kernel.org \
--to=robh@kernel.org \
--cc=andrew@lunn.ch \
--cc=arm@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=gregory.clement@bootlin.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).