From: Rob Herring <robh@kernel.org>
To: Eliav Farber <farbere@amazon.com>
Cc: brgl@bgdev.pl, mark.rutland@arm.com, arnd@arndb.de,
gregkh@linuxfoundation.org, linux-i2c@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
talel@amazon.com, hhhawa@amazon.com, jonnyc@amazon.com,
hanochu@amazon.com, ronenk@amazon.com, itamark@amazon.com,
shellykz@amazon.com, shorer@amazon.com, amitlavi@amazon.com,
almogbs@amazon.com, dkl@amazon.com, dwmw@amazon.co.uk
Subject: Re: [PATCH v2 1/2] dt-bindings: at24: add new optional power-supply property
Date: Mon, 22 Aug 2022 16:46:23 -0500 [thread overview]
Message-ID: <20220822214623.GA907654-robh@kernel.org> (raw)
In-Reply-To: <20220822105830.22790-2-farbere@amazon.com>
On Mon, Aug 22, 2022 at 10:58:29AM +0000, Eliav Farber wrote:
> Boards using the AT24 EEPROMs might have a GPIO that controls the power
> supply of the chip, and it must be set to enable the usage of it.
>
> Add a new optional property to the device tree binding document, which
> allows to specify a GPIO regulator for the pin that controls the power.
>
> On Linux this means that we need to enable the GPIO at the beginning of
> probe function, before trying to access the chip.
>
> Signed-off-by: Eliav Farber <farbere@amazon.com>
> ---
> V1 -> V2:
> Change pointed out by Rob Herring:
> - Use a gpio regulator for power-supply control.
>
> Documentation/devicetree/bindings/eeprom/at24.txt | 3 +++
> 1 file changed, 3 insertions(+)
This file doesn't exist any more. Use the latest -rc1 kernel unless
there is a reason you need a different (even later) base.
Rob
next prev parent reply other threads:[~2022-08-22 21:46 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-22 10:58 [PATCH v2 0/2] add power-supply control to enable eeprom usage Eliav Farber
2022-08-22 10:58 ` [PATCH v2 1/2] dt-bindings: at24: add new optional power-supply property Eliav Farber
2022-08-22 21:46 ` Rob Herring [this message]
2022-08-28 15:45 ` Farber, Eliav
2022-08-30 17:05 ` Krzysztof Kozlowski
2022-08-22 10:58 ` [PATCH v2 2/2] eeprom: at24: add support for power-supply control Eliav Farber
2022-08-28 14:28 ` Bartosz Golaszewski
2022-08-28 15:47 ` Farber, Eliav
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220822214623.GA907654-robh@kernel.org \
--to=robh@kernel.org \
--cc=almogbs@amazon.com \
--cc=amitlavi@amazon.com \
--cc=arnd@arndb.de \
--cc=brgl@bgdev.pl \
--cc=devicetree@vger.kernel.org \
--cc=dkl@amazon.com \
--cc=dwmw@amazon.co.uk \
--cc=farbere@amazon.com \
--cc=gregkh@linuxfoundation.org \
--cc=hanochu@amazon.com \
--cc=hhhawa@amazon.com \
--cc=itamark@amazon.com \
--cc=jonnyc@amazon.com \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=ronenk@amazon.com \
--cc=shellykz@amazon.com \
--cc=shorer@amazon.com \
--cc=talel@amazon.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).