* [PATCH] dt-bindings: phy: Add missing (unevaluated|additional)Properties on child nodes
@ 2022-08-23 14:56 Rob Herring
2022-08-25 8:21 ` Krzysztof Kozlowski
2022-08-30 7:06 ` Vinod Koul
0 siblings, 2 replies; 3+ messages in thread
From: Rob Herring @ 2022-08-23 14:56 UTC (permalink / raw)
To: Kishon Vijay Abraham I, Vinod Koul, Krzysztof Kozlowski, Ray Jui,
Scott Branden, Broadcom internal kernel review list,
Maxime Coquelin, Alexandre Torgue, Andy Gross, Bjorn Andersson,
Konrad Dybcio, Amelie Delaunay, Wesley Cheng
Cc: Ray Jui, Scott Branden, linux-phy, devicetree, linux-arm-kernel,
linux-kernel, linux-stm32, linux-arm-msm
In order to ensure only documented properties are present, node schemas
must have unevaluatedProperties or additionalProperties set to false
(typically).
Signed-off-by: Rob Herring <robh@kernel.org>
---
.../devicetree/bindings/phy/brcm,cygnus-pcie-phy.yaml | 1 +
Documentation/devicetree/bindings/phy/phy-stm32-usbphyc.yaml | 2 ++
.../devicetree/bindings/phy/qcom,qmp-usb3-dp-phy.yaml | 2 ++
Documentation/devicetree/bindings/phy/ti,phy-j721e-wiz.yaml | 3 +++
4 files changed, 8 insertions(+)
diff --git a/Documentation/devicetree/bindings/phy/brcm,cygnus-pcie-phy.yaml b/Documentation/devicetree/bindings/phy/brcm,cygnus-pcie-phy.yaml
index 045699c65779..808e90b2465d 100644
--- a/Documentation/devicetree/bindings/phy/brcm,cygnus-pcie-phy.yaml
+++ b/Documentation/devicetree/bindings/phy/brcm,cygnus-pcie-phy.yaml
@@ -32,6 +32,7 @@ properties:
patternProperties:
"^pcie-phy@[0-9]+$":
type: object
+ additionalProperties: false
description: >
PCIe PHY child nodes
diff --git a/Documentation/devicetree/bindings/phy/phy-stm32-usbphyc.yaml b/Documentation/devicetree/bindings/phy/phy-stm32-usbphyc.yaml
index dc287d428e49..801993813b18 100644
--- a/Documentation/devicetree/bindings/phy/phy-stm32-usbphyc.yaml
+++ b/Documentation/devicetree/bindings/phy/phy-stm32-usbphyc.yaml
@@ -77,6 +77,8 @@ patternProperties:
connector:
type: object
$ref: /schemas/connector/usb-connector.yaml
+ unevaluatedProperties: false
+
properties:
vbus-supply: true
diff --git a/Documentation/devicetree/bindings/phy/qcom,qmp-usb3-dp-phy.yaml b/Documentation/devicetree/bindings/phy/qcom,qmp-usb3-dp-phy.yaml
index b078009ed509..563e85c48c6a 100644
--- a/Documentation/devicetree/bindings/phy/qcom,qmp-usb3-dp-phy.yaml
+++ b/Documentation/devicetree/bindings/phy/qcom,qmp-usb3-dp-phy.yaml
@@ -81,6 +81,7 @@ properties:
patternProperties:
"^usb3-phy@[0-9a-f]+$":
type: object
+ additionalProperties: false
description:
The USB3 PHY.
@@ -121,6 +122,7 @@ patternProperties:
"^dp-phy@[0-9a-f]+$":
type: object
+ additionalProperties: false
description:
The DP PHY.
diff --git a/Documentation/devicetree/bindings/phy/ti,phy-j721e-wiz.yaml b/Documentation/devicetree/bindings/phy/ti,phy-j721e-wiz.yaml
index dcd63908aeae..7c7c3e3e6346 100644
--- a/Documentation/devicetree/bindings/phy/ti,phy-j721e-wiz.yaml
+++ b/Documentation/devicetree/bindings/phy/ti,phy-j721e-wiz.yaml
@@ -79,6 +79,7 @@ properties:
refclk-dig:
type: object
+ additionalProperties: false
description: |
WIZ node should have subnode for refclk_dig to select the reference
clock source for the reference clock used in the PHY and PMA digital
@@ -108,6 +109,7 @@ properties:
patternProperties:
"^pll[0|1]-refclk$":
type: object
+ additionalProperties: false
description: |
WIZ node should have subnodes for each of the PLLs present in
the SERDES.
@@ -133,6 +135,7 @@ patternProperties:
"^cmn-refclk1?-dig-div$":
type: object
+ additionalProperties: false
description:
WIZ node should have subnodes for each of the PMA common refclock
provided by the SERDES.
--
2.34.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] dt-bindings: phy: Add missing (unevaluated|additional)Properties on child nodes
2022-08-23 14:56 [PATCH] dt-bindings: phy: Add missing (unevaluated|additional)Properties on child nodes Rob Herring
@ 2022-08-25 8:21 ` Krzysztof Kozlowski
2022-08-30 7:06 ` Vinod Koul
1 sibling, 0 replies; 3+ messages in thread
From: Krzysztof Kozlowski @ 2022-08-25 8:21 UTC (permalink / raw)
To: Rob Herring, Kishon Vijay Abraham I, Vinod Koul,
Krzysztof Kozlowski, Ray Jui, Scott Branden,
Broadcom internal kernel review list, Maxime Coquelin,
Alexandre Torgue, Andy Gross, Bjorn Andersson, Konrad Dybcio,
Amelie Delaunay, Wesley Cheng
Cc: Ray Jui, Scott Branden, linux-phy, devicetree, linux-arm-kernel,
linux-kernel, linux-stm32, linux-arm-msm
On 23/08/2022 17:56, Rob Herring wrote:
> In order to ensure only documented properties are present, node schemas
> must have unevaluatedProperties or additionalProperties set to false
> (typically).
Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] dt-bindings: phy: Add missing (unevaluated|additional)Properties on child nodes
2022-08-23 14:56 [PATCH] dt-bindings: phy: Add missing (unevaluated|additional)Properties on child nodes Rob Herring
2022-08-25 8:21 ` Krzysztof Kozlowski
@ 2022-08-30 7:06 ` Vinod Koul
1 sibling, 0 replies; 3+ messages in thread
From: Vinod Koul @ 2022-08-30 7:06 UTC (permalink / raw)
To: Rob Herring
Cc: Kishon Vijay Abraham I, Krzysztof Kozlowski, Ray Jui,
Scott Branden, Broadcom internal kernel review list,
Maxime Coquelin, Alexandre Torgue, Andy Gross, Bjorn Andersson,
Konrad Dybcio, Amelie Delaunay, Wesley Cheng, Ray Jui,
Scott Branden, linux-phy, devicetree, linux-arm-kernel,
linux-kernel, linux-stm32, linux-arm-msm
On 23-08-22, 09:56, Rob Herring wrote:
> In order to ensure only documented properties are present, node schemas
> must have unevaluatedProperties or additionalProperties set to false
> (typically).
Applied, thanks
--
~Vinod
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2022-08-30 7:08 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-08-23 14:56 [PATCH] dt-bindings: phy: Add missing (unevaluated|additional)Properties on child nodes Rob Herring
2022-08-25 8:21 ` Krzysztof Kozlowski
2022-08-30 7:06 ` Vinod Koul
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).