* [PATCH] of/device: Fix up of_dma_configure_id() stub
@ 2022-08-24 15:32 Thierry Reding
2022-08-25 10:11 ` Lorenzo Pieralisi
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Thierry Reding @ 2022-08-24 15:32 UTC (permalink / raw)
To: Rob Herring, Frank Rowand; +Cc: Lorenzo Pieralisi, devicetree, linux-kernel
From: Thierry Reding <treding@nvidia.com>
Since the stub version of of_dma_configure_id() was added in commit
a081bd4af4ce ("of/device: Add input id to of_dma_configure()"), it has
not matched the signature of the full function, leading to build failure
reports when code using this function is built on !OF configurations.
Fixes: a081bd4af4ce ("of/device: Add input id to of_dma_configure()")
Signed-off-by: Thierry Reding <treding@nvidia.com>
---
include/linux/of_device.h | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/include/linux/of_device.h b/include/linux/of_device.h
index 1d7992a02e36..1a803e4335d3 100644
--- a/include/linux/of_device.h
+++ b/include/linux/of_device.h
@@ -101,8 +101,9 @@ static inline struct device_node *of_cpu_device_node_get(int cpu)
}
static inline int of_dma_configure_id(struct device *dev,
- struct device_node *np,
- bool force_dma)
+ struct device_node *np,
+ bool force_dma,
+ const u32 *id)
{
return 0;
}
--
2.37.2
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH] of/device: Fix up of_dma_configure_id() stub
2022-08-24 15:32 [PATCH] of/device: Fix up of_dma_configure_id() stub Thierry Reding
@ 2022-08-25 10:11 ` Lorenzo Pieralisi
2022-08-25 16:38 ` Frank Rowand
2022-08-25 19:00 ` Rob Herring
2 siblings, 0 replies; 4+ messages in thread
From: Lorenzo Pieralisi @ 2022-08-25 10:11 UTC (permalink / raw)
To: Thierry Reding; +Cc: Rob Herring, Frank Rowand, devicetree, linux-kernel
On Wed, Aug 24, 2022 at 05:32:56PM +0200, Thierry Reding wrote:
> From: Thierry Reding <treding@nvidia.com>
>
> Since the stub version of of_dma_configure_id() was added in commit
> a081bd4af4ce ("of/device: Add input id to of_dma_configure()"), it has
> not matched the signature of the full function, leading to build failure
> reports when code using this function is built on !OF configurations.
>
> Fixes: a081bd4af4ce ("of/device: Add input id to of_dma_configure()")
> Signed-off-by: Thierry Reding <treding@nvidia.com>
> ---
> include/linux/of_device.h | 5 +++--
> 1 file changed, 3 insertions(+), 2 deletions(-)
Acked-by: Lorenzo Pieralisi <lpieralisi@kernel.org>
> diff --git a/include/linux/of_device.h b/include/linux/of_device.h
> index 1d7992a02e36..1a803e4335d3 100644
> --- a/include/linux/of_device.h
> +++ b/include/linux/of_device.h
> @@ -101,8 +101,9 @@ static inline struct device_node *of_cpu_device_node_get(int cpu)
> }
>
> static inline int of_dma_configure_id(struct device *dev,
> - struct device_node *np,
> - bool force_dma)
> + struct device_node *np,
> + bool force_dma,
> + const u32 *id)
> {
> return 0;
> }
> --
> 2.37.2
>
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] of/device: Fix up of_dma_configure_id() stub
2022-08-24 15:32 [PATCH] of/device: Fix up of_dma_configure_id() stub Thierry Reding
2022-08-25 10:11 ` Lorenzo Pieralisi
@ 2022-08-25 16:38 ` Frank Rowand
2022-08-25 19:00 ` Rob Herring
2 siblings, 0 replies; 4+ messages in thread
From: Frank Rowand @ 2022-08-25 16:38 UTC (permalink / raw)
To: Thierry Reding, Rob Herring; +Cc: Lorenzo Pieralisi, devicetree, linux-kernel
On 8/24/22 10:32, Thierry Reding wrote:
> From: Thierry Reding <treding@nvidia.com>
>
> Since the stub version of of_dma_configure_id() was added in commit
> a081bd4af4ce ("of/device: Add input id to of_dma_configure()"), it has
> not matched the signature of the full function, leading to build failure
> reports when code using this function is built on !OF configurations.
>
> Fixes: a081bd4af4ce ("of/device: Add input id to of_dma_configure()")
> Signed-off-by: Thierry Reding <treding@nvidia.com>
> ---
> include/linux/of_device.h | 5 +++--
> 1 file changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/include/linux/of_device.h b/include/linux/of_device.h
> index 1d7992a02e36..1a803e4335d3 100644
> --- a/include/linux/of_device.h
> +++ b/include/linux/of_device.h
> @@ -101,8 +101,9 @@ static inline struct device_node *of_cpu_device_node_get(int cpu)
> }
>
> static inline int of_dma_configure_id(struct device *dev,
> - struct device_node *np,
> - bool force_dma)
> + struct device_node *np,
> + bool force_dma,
> + const u32 *id)
> {
> return 0;
> }
Reviewed-by: Frank Rowand <frank.rowand@sony.com>
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] of/device: Fix up of_dma_configure_id() stub
2022-08-24 15:32 [PATCH] of/device: Fix up of_dma_configure_id() stub Thierry Reding
2022-08-25 10:11 ` Lorenzo Pieralisi
2022-08-25 16:38 ` Frank Rowand
@ 2022-08-25 19:00 ` Rob Herring
2 siblings, 0 replies; 4+ messages in thread
From: Rob Herring @ 2022-08-25 19:00 UTC (permalink / raw)
To: Thierry Reding
Cc: Rob Herring, devicetree, linux-kernel, Lorenzo Pieralisi,
Frank Rowand
On Wed, 24 Aug 2022 17:32:56 +0200, Thierry Reding wrote:
> From: Thierry Reding <treding@nvidia.com>
>
> Since the stub version of of_dma_configure_id() was added in commit
> a081bd4af4ce ("of/device: Add input id to of_dma_configure()"), it has
> not matched the signature of the full function, leading to build failure
> reports when code using this function is built on !OF configurations.
>
> Fixes: a081bd4af4ce ("of/device: Add input id to of_dma_configure()")
> Signed-off-by: Thierry Reding <treding@nvidia.com>
> ---
> include/linux/of_device.h | 5 +++--
> 1 file changed, 3 insertions(+), 2 deletions(-)
>
Applied, thanks!
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2022-08-25 19:00 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-08-24 15:32 [PATCH] of/device: Fix up of_dma_configure_id() stub Thierry Reding
2022-08-25 10:11 ` Lorenzo Pieralisi
2022-08-25 16:38 ` Frank Rowand
2022-08-25 19:00 ` Rob Herring
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).