[PATCH] ARM: dts: turris-omnia: Add switch port 6 node

[PATCH] ARM: dts: turris-omnia: Add switch port 6 node

[Pali Rohár]

Switch port 6 is connected to eth0, so add appropriate device tree node for it.

Fixes: 26ca8b52d6e1 ("ARM: dts: add support for Turris Omnia")
Signed-off-by: Pali Rohár <pali@kernel.org>
---
 arch/arm/boot/dts/armada-385-turris-omnia.dts | 12 +++++++++++-
 1 file changed, 11 insertions(+), 1 deletion(-)

diff --git a/arch/arm/boot/dts/armada-385-turris-omnia.dts b/arch/arm/boot/dts/armada-385-turris-omnia.dts
index f655e9229d68..8215ffb6a795 100644
--- a/arch/arm/boot/dts/armada-385-turris-omnia.dts
+++ b/arch/arm/boot/dts/armada-385-turris-omnia.dts
@@ -463,7 +463,17 @@
 				};
 			};
 
-			/* port 6 is connected to eth0 */
+			ports@6 {
+				reg = <6>;
+				label = "cpu";
+				ethernet = <&eth0>;
+				phy-mode = "rgmii-id";
+
+				fixed-link {
+					speed = <1000>;
+					full-duplex;
+				};
+			};
 		};
 	};
 };
-- 
2.20.1

Re: [PATCH] ARM: dts: turris-omnia: Add switch port 6 node

[Andrew Lunn]

On Thu, Aug 25, 2022 at 02:21:02PM +0200, Pali Rohár wrote:
> Switch port 6 is connected to eth0, so add appropriate device tree node for it.
> 
> Fixes: 26ca8b52d6e1 ("ARM: dts: add support for Turris Omnia")
> Signed-off-by: Pali Rohár <pali@kernel.org>
> ---
>  arch/arm/boot/dts/armada-385-turris-omnia.dts | 12 +++++++++++-
>  1 file changed, 11 insertions(+), 1 deletion(-)
> 
> diff --git a/arch/arm/boot/dts/armada-385-turris-omnia.dts b/arch/arm/boot/dts/armada-385-turris-omnia.dts
> index f655e9229d68..8215ffb6a795 100644
> --- a/arch/arm/boot/dts/armada-385-turris-omnia.dts
> +++ b/arch/arm/boot/dts/armada-385-turris-omnia.dts
> @@ -463,7 +463,17 @@
>  				};
>  			};
>  
> -			/* port 6 is connected to eth0 */
> +			ports@6 {
> +				reg = <6>;
> +				label = "cpu";
> +				ethernet = <&eth0>;
> +				phy-mode = "rgmii-id";
> +
> +				fixed-link {
> +					speed = <1000>;
> +					full-duplex;
> +				};
> +			};

Hi Pali

I've not been following Vladimirs work on multiple CPU ports. Is it
clearly defined, both for old and new kernels, what happens where
there are multiple CPU ports defined?

      Andrew

Re: [PATCH] ARM: dts: turris-omnia: Add switch port 6 node

[Pali Rohár]

On Saturday 27 August 2022 20:41:59 Andrew Lunn wrote:
> On Thu, Aug 25, 2022 at 02:21:02PM +0200, Pali Rohár wrote:
> > Switch port 6 is connected to eth0, so add appropriate device tree node for it.
> > 
> > Fixes: 26ca8b52d6e1 ("ARM: dts: add support for Turris Omnia")
> > Signed-off-by: Pali Rohár <pali@kernel.org>
> > ---
> >  arch/arm/boot/dts/armada-385-turris-omnia.dts | 12 +++++++++++-
> >  1 file changed, 11 insertions(+), 1 deletion(-)
> > 
> > diff --git a/arch/arm/boot/dts/armada-385-turris-omnia.dts b/arch/arm/boot/dts/armada-385-turris-omnia.dts
> > index f655e9229d68..8215ffb6a795 100644
> > --- a/arch/arm/boot/dts/armada-385-turris-omnia.dts
> > +++ b/arch/arm/boot/dts/armada-385-turris-omnia.dts
> > @@ -463,7 +463,17 @@
> >  				};
> >  			};
> >  
> > -			/* port 6 is connected to eth0 */
> > +			ports@6 {
> > +				reg = <6>;
> > +				label = "cpu";
> > +				ethernet = <&eth0>;
> > +				phy-mode = "rgmii-id";
> > +
> > +				fixed-link {
> > +					speed = <1000>;
> > +					full-duplex;
> > +				};
> > +			};
> 
> Hi Pali
> 
> I've not been following Vladimirs work on multiple CPU ports. Is it
> clearly defined, both for old and new kernels, what happens where
> there are multiple CPU ports defined?
> 
>       Andrew

Hello!

On older kernel kernel versions just the first one cpu port works. Like
if second node is not defined at all. So I sent this patch to have
complete HW definition in DTS, even when kernel does not support all
features yet.

Re: [PATCH] ARM: dts: turris-omnia: Add switch port 6 node

[Andrew Lunn]

> > Hi Pali
> > 
> > I've not been following Vladimirs work on multiple CPU ports. Is it
> > clearly defined, both for old and new kernels, what happens where
> > there are multiple CPU ports defined?
> > 
> >       Andrew
> 
> Hello!
> 
> On older kernel kernel versions just the first one cpu port works.

O.K, i was worried it might use the last "cpu" port found, and so
change things.

Reviewed-by: Andrew Lunn <andrew@lunn.ch>

    Andrew

Re: [PATCH] ARM: dts: turris-omnia: Add switch port 6 node

[Pali Rohár]

PING?

On Thursday 25 August 2022 14:21:02 Pali Rohár wrote:
> Switch port 6 is connected to eth0, so add appropriate device tree node for it.
> 
> Fixes: 26ca8b52d6e1 ("ARM: dts: add support for Turris Omnia")
> Signed-off-by: Pali Rohár <pali@kernel.org>
> ---
>  arch/arm/boot/dts/armada-385-turris-omnia.dts | 12 +++++++++++-
>  1 file changed, 11 insertions(+), 1 deletion(-)
> 
> diff --git a/arch/arm/boot/dts/armada-385-turris-omnia.dts b/arch/arm/boot/dts/armada-385-turris-omnia.dts
> index f655e9229d68..8215ffb6a795 100644
> --- a/arch/arm/boot/dts/armada-385-turris-omnia.dts
> +++ b/arch/arm/boot/dts/armada-385-turris-omnia.dts
> @@ -463,7 +463,17 @@
>  				};
>  			};
>  
> -			/* port 6 is connected to eth0 */
> +			ports@6 {
> +				reg = <6>;
> +				label = "cpu";
> +				ethernet = <&eth0>;
> +				phy-mode = "rgmii-id";
> +
> +				fixed-link {
> +					speed = <1000>;
> +					full-duplex;
> +				};
> +			};
>  		};
>  	};
>  };
> -- 
> 2.20.1
> 

Re: [PATCH] ARM: dts: turris-omnia: Add switch port 6 node

[Andrew Lunn]

On Sat, Sep 24, 2022 at 02:14:00PM +0200, Pali Rohár wrote:
> PING?

You would do better reposting, adding my Reviewed-by:.

My _guess_ would be, any patch which Gregory receives which already
has a reviewed-by: on it, will get picked up immediately.

    Andrew

Re: [PATCH] ARM: dts: turris-omnia: Add switch port 6 node

[Pali Rohár]

PING?

On Thursday 25 August 2022 14:21:02 Pali Rohár wrote:
> Switch port 6 is connected to eth0, so add appropriate device tree node for it.
> 
> Fixes: 26ca8b52d6e1 ("ARM: dts: add support for Turris Omnia")
> Signed-off-by: Pali Rohár <pali@kernel.org>
> ---
>  arch/arm/boot/dts/armada-385-turris-omnia.dts | 12 +++++++++++-
>  1 file changed, 11 insertions(+), 1 deletion(-)
> 
> diff --git a/arch/arm/boot/dts/armada-385-turris-omnia.dts b/arch/arm/boot/dts/armada-385-turris-omnia.dts
> index f655e9229d68..8215ffb6a795 100644
> --- a/arch/arm/boot/dts/armada-385-turris-omnia.dts
> +++ b/arch/arm/boot/dts/armada-385-turris-omnia.dts
> @@ -463,7 +463,17 @@
>  				};
>  			};
>  
> -			/* port 6 is connected to eth0 */
> +			ports@6 {
> +				reg = <6>;
> +				label = "cpu";
> +				ethernet = <&eth0>;
> +				phy-mode = "rgmii-id";
> +
> +				fixed-link {
> +					speed = <1000>;
> +					full-duplex;
> +				};
> +			};
>  		};
>  	};
>  };
> -- 
> 2.20.1
> 

Re: [PATCH] ARM: dts: turris-omnia: Add switch port 6 node

[Gregory CLEMENT]

Pali Rohár <pali@kernel.org> writes:

> Switch port 6 is connected to eth0, so add appropriate device tree node for it.
>
> Fixes: 26ca8b52d6e1 ("ARM: dts: add support for Turris Omnia")
> Signed-off-by: Pali Rohár <pali@kernel.org>

Applied on mvebu/dt

Thanks,

Gregory
> ---
>  arch/arm/boot/dts/armada-385-turris-omnia.dts | 12 +++++++++++-
>  1 file changed, 11 insertions(+), 1 deletion(-)
>
> diff --git a/arch/arm/boot/dts/armada-385-turris-omnia.dts b/arch/arm/boot/dts/armada-385-turris-omnia.dts
> index f655e9229d68..8215ffb6a795 100644
> --- a/arch/arm/boot/dts/armada-385-turris-omnia.dts
> +++ b/arch/arm/boot/dts/armada-385-turris-omnia.dts
> @@ -463,7 +463,17 @@
>  				};
>  			};
>  
> -			/* port 6 is connected to eth0 */
> +			ports@6 {
> +				reg = <6>;
> +				label = "cpu";
> +				ethernet = <&eth0>;
> +				phy-mode = "rgmii-id";
> +
> +				fixed-link {
> +					speed = <1000>;
> +					full-duplex;
> +				};
> +			};
>  		};
>  	};
>  };
> -- 
> 2.20.1
>

-- 
Gregory Clement, Bootlin
Embedded Linux and Kernel engineering
http://bootlin.com