From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 027D9ECAAA2 for ; Thu, 25 Aug 2022 21:31:02 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232783AbiHYVbB (ORCPT ); Thu, 25 Aug 2022 17:31:01 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49948 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231807AbiHYVbA (ORCPT ); Thu, 25 Aug 2022 17:31:00 -0400 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2D867BB680 for ; Thu, 25 Aug 2022 14:30:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1661463058; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=LY0dJI+HK3FIyhOwsV0Ul5xZhYFbnAopq+3Lt6Gqi0I=; b=f5YY2U0K2Hhw3Dmv2CE5ulOQxaUQ6srd4fib/qStqZ+OUHTQigj6dElz05fev0WmSDE8+E TrhWE3D4uWIj6asmVJcAlntEtKzVVb4FOyq1StQ6VrR8QXiz1bGCrrM25pN6X8aToXd3pB kss3HQPTEN2R9yo5Krab/VjuqKungSQ= Received: from mail-qt1-f199.google.com (mail-qt1-f199.google.com [209.85.160.199]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-617-l45EDqY9OoGO3Jws6mqjTQ-1; Thu, 25 Aug 2022 17:30:57 -0400 X-MC-Unique: l45EDqY9OoGO3Jws6mqjTQ-1 Received: by mail-qt1-f199.google.com with SMTP id ff27-20020a05622a4d9b00b0034306b77c08so15998830qtb.6 for ; Thu, 25 Aug 2022 14:30:57 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc; bh=LY0dJI+HK3FIyhOwsV0Ul5xZhYFbnAopq+3Lt6Gqi0I=; b=tqJQWE3X5MxVpIOB3cjTRr4SbjpdBT1Ye2JDlSePZjay8NdWtAEj08JA8GGq6c655s 7qGRWzgSpeDWE+gufB/8zrl73AuH75iFOIPxp3/scGlTurb7lXv4+z9kaj3FdQNem500 wnNqqFDFwgJ4hapaw7LBes9Ql/gqm6p+O/bx4ePWLOlam4AXdnBqnWXRcPIwg38DM4FM hu10kTJztl/Oee2O/M5Of/7a0aazy79eM5+AxG8VxO9Q4psJT/aGshN0Rm//c392rCSc +jMqtwGESCqWzt+qyz3Xtp2F024GfguXsEC+KEBTeYe4n/kxDg7bcvwFiLifcvwW3Ygx RIcw== X-Gm-Message-State: ACgBeo0ohyIseRORCk3GHV8Mhd1B/ndoV6fcZy4CH3Fjwx2/9ZMlWLEx gYVx8PhmoOhHMk8WTN4h+KyiHwUEX5AGJUAOH4GslldFd/J9KUDz8dsgl9ojzKBCMfaSzHH/Z0D awStv03+OWtEJTPGohfjszA== X-Received: by 2002:ad4:5de2:0:b0:477:f5e6:e13 with SMTP id jn2-20020ad45de2000000b00477f5e60e13mr5423061qvb.31.1661463056657; Thu, 25 Aug 2022 14:30:56 -0700 (PDT) X-Google-Smtp-Source: AA6agR7xkZetSsMyk6rm1K+UpYZVkmzuXPO46vRqd+KLaE2CVCyFwQLP8z/A95Kj/ZKZzhHK07guDg== X-Received: by 2002:ad4:5de2:0:b0:477:f5e6:e13 with SMTP id jn2-20020ad45de2000000b00477f5e60e13mr5423047qvb.31.1661463056397; Thu, 25 Aug 2022 14:30:56 -0700 (PDT) Received: from halaneylaptop ([2600:1700:1ff0:d0e0::48]) by smtp.gmail.com with ESMTPSA id m14-20020a05620a24ce00b006b9a89d408csm427775qkn.100.2022.08.25.14.30.55 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 25 Aug 2022 14:30:55 -0700 (PDT) Date: Thu, 25 Aug 2022 16:30:53 -0500 From: Andrew Halaney To: Douglas Anderson Cc: Bjorn Andersson , Mark Brown , Andy Gross , Bhupesh Sharma , Konrad Dybcio , Krzysztof Kozlowski , Rob Herring , devicetree@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/7] arm64: dts: qcom: sa8155p-adp: Specify which LDO modes are allowed Message-ID: <20220825213053.5xxiljfjkhnpy53p@halaneylaptop> References: <20220825164205.4060647-1-dianders@chromium.org> <20220825094155.1.Id59c32b560c4662d8b3697de2bd494d08d654806@changeid> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220825094155.1.Id59c32b560c4662d8b3697de2bd494d08d654806@changeid> Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On Thu, Aug 25, 2022 at 09:41:59AM -0700, Douglas Anderson wrote: > This board uses RPMH, specifies "regulator-allow-set-load" for LDOs, > but doesn't specify any modes with "regulator-allowed-modes". > > Prior to commit efb0cb50c427 ("regulator: qcom-rpmh: Implement > get_optimum_mode(), not set_load()") the above meant that we were able > to set either LPM or HPM mode. After that commit (and fixes [1]) we'll > be stuck at the initial mode. Discussion of this has resulted in the > decision that the old dts files were wrong and should be fixed to > fully restore old functionality. > > Let's re-enable the old functionality by fixing the dts. > > [1] https://lore.kernel.org/r/20220824142229.RFT.v2.2.I6f77860e5cd98bf5c67208fa9edda4a08847c304@changeid > > Fixes: 5b85e8f2225c ("arm64: dts: qcom: sa8155p-adp: Add base dts file") > Signed-off-by: Douglas Anderson > --- > > arch/arm64/boot/dts/qcom/sa8155p-adp.dts | 13 ++++++++++++- > 1 file changed, 12 insertions(+), 1 deletion(-) > > diff --git a/arch/arm64/boot/dts/qcom/sa8155p-adp.dts b/arch/arm64/boot/dts/qcom/sa8155p-adp.dts > index ba547ca9fc6b..ddb9cb182152 100644 > --- a/arch/arm64/boot/dts/qcom/sa8155p-adp.dts > +++ b/arch/arm64/boot/dts/qcom/sa8155p-adp.dts > @@ -43,7 +43,6 @@ vreg_s4a_1p8: smps4 { > > regulator-always-on; > regulator-boot-on; > - regulator-allow-set-load; I could see this deserving its own commit or a line in the commit message, but not a big deal to me: Reviewed-by: Andrew Halaney > > vin-supply = <&vreg_3p3>; > }; > @@ -137,6 +136,9 @@ vreg_l5a_0p88: ldo5 { > regulator-max-microvolt = <880000>; > regulator-initial-mode = ; > regulator-allow-set-load; > + regulator-allowed-modes = > + + RPMH_REGULATOR_MODE_HPM>; > }; > > vreg_l7a_1p8: ldo7 { > @@ -152,6 +154,9 @@ vreg_l10a_2p96: ldo10 { > regulator-max-microvolt = <2960000>; > regulator-initial-mode = ; > regulator-allow-set-load; > + regulator-allowed-modes = > + + RPMH_REGULATOR_MODE_HPM>; > }; > > vreg_l11a_0p8: ldo11 { > @@ -258,6 +263,9 @@ vreg_l5c_1p2: ldo5 { > regulator-max-microvolt = <1200000>; > regulator-initial-mode = ; > regulator-allow-set-load; > + regulator-allowed-modes = > + + RPMH_REGULATOR_MODE_HPM>; > }; > > vreg_l7c_1p8: ldo7 { > @@ -273,6 +281,9 @@ vreg_l8c_1p2: ldo8 { > regulator-max-microvolt = <1200000>; > regulator-initial-mode = ; > regulator-allow-set-load; > + regulator-allowed-modes = > + + RPMH_REGULATOR_MODE_HPM>; > }; > > vreg_l10c_3p3: ldo10 { > -- > 2.37.2.672.g94769d06f0-goog >