From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 54BF8ECAAA2 for ; Thu, 25 Aug 2022 21:33:52 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S243686AbiHYVdu (ORCPT ); Thu, 25 Aug 2022 17:33:50 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53076 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S243684AbiHYVds (ORCPT ); Thu, 25 Aug 2022 17:33:48 -0400 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1A958BFC41 for ; Thu, 25 Aug 2022 14:33:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1661463226; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=6aPloejq6vPvAglHpAJmylSnk+VauqCSWbgwN5T3xFw=; b=Grkq6sFxGeijgzavNrx3RzYW4crjFNq5iXHmX8beLBSokZcFt6DW3dIj+wU3WzS+rFWSlh Wp6ItaFjjTz1KDIlJiJ90BnEjOqXPg084p5qL6MtylK9TQutkbYe7/KdAVxob9W24Ai7hx 8lDiWPNnIG4lhRBr+WZ56r7sx0ubxdM= Received: from mail-qv1-f72.google.com (mail-qv1-f72.google.com [209.85.219.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-593-q1_8DmWrOxqhLtxa40_7dQ-1; Thu, 25 Aug 2022 17:33:40 -0400 X-MC-Unique: q1_8DmWrOxqhLtxa40_7dQ-1 Received: by mail-qv1-f72.google.com with SMTP id lj8-20020a0562145c8800b00496ceb190d4so9433970qvb.3 for ; Thu, 25 Aug 2022 14:33:40 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc; bh=6aPloejq6vPvAglHpAJmylSnk+VauqCSWbgwN5T3xFw=; b=pA18wPoVyuANr4naOgFVmvOIWrwcjPkzmZS8Do3Cb8fYlMjqDSGilQPUHSjkGR7Ivw DjFmDvbM0KopXDJS4Jd2iJ7ZL1b6aWIM5m+STjgsW6hZinL+OTKRGJI5RIXcL8sXkwIO 5AcQDJy6+OG2yC4qD5rCl/dEiXb7LHFVtG0ZS7yMbBuj4K1wDfygkt1qVK12dyQQBJ9S e++7zLK6SOR7ZWKc6TcgDEYOfL82DGj3QwbpdO4MmPo+V9d67Dd317IfkjSIianVmgGB Iun/Zy/SruqcvHZ/hnkCZPVKSEH/H1midBe0pEwX8ELbSG7/+lYpBS1KPNkgLAKPweVD nIUA== X-Gm-Message-State: ACgBeo1kmaQ3jaD23Vs2JtRWuiYJKbu8C/lF8M8F1yte/Iv6bmPa43Ud kAFBsCDPLJ1lSZ2mX4lhZMFXqpGDEs1sHCIxeq+1n/Ignw611S53mo1XSS1qXjDguacvlIfUVwz dpHe/+ZonI8oaHDSSHlNa7Q== X-Received: by 2002:a05:622a:342:b0:343:71c7:9be6 with SMTP id r2-20020a05622a034200b0034371c79be6mr5617602qtw.72.1661463219745; Thu, 25 Aug 2022 14:33:39 -0700 (PDT) X-Google-Smtp-Source: AA6agR4rio0ubMv+vXsQgasbaBeWjrLzOszpzRC+aB0GsBY5/h2vBh2/WaaV1Gk73dWYTWUJ4jVdwg== X-Received: by 2002:a05:622a:342:b0:343:71c7:9be6 with SMTP id r2-20020a05622a034200b0034371c79be6mr5617582qtw.72.1661463219519; Thu, 25 Aug 2022 14:33:39 -0700 (PDT) Received: from halaneylaptop ([2600:1700:1ff0:d0e0::48]) by smtp.gmail.com with ESMTPSA id o6-20020a05620a2a0600b006baf3ffba23sm411321qkp.38.2022.08.25.14.33.38 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 25 Aug 2022 14:33:39 -0700 (PDT) Date: Thu, 25 Aug 2022 16:33:37 -0500 From: Andrew Halaney To: Douglas Anderson Cc: Bjorn Andersson , Mark Brown , Andy Gross , Johan Hovold , Konrad Dybcio , Krzysztof Kozlowski , Rob Herring , devicetree@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 2/7] arm64: dts: qcom: sa8295p-adp: Specify which LDO modes are allowed Message-ID: <20220825213337.3h3in2csbdcom7on@halaneylaptop> References: <20220825164205.4060647-1-dianders@chromium.org> <20220825094155.2.I430a56702ab0af65244e62667bb7743107de0c96@changeid> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220825094155.2.I430a56702ab0af65244e62667bb7743107de0c96@changeid> Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On Thu, Aug 25, 2022 at 09:42:00AM -0700, Douglas Anderson wrote: > This board uses RPMH, specifies "regulator-allow-set-load" for LDOs, > but doesn't specify any modes with "regulator-allowed-modes". > > Prior to commit efb0cb50c427 ("regulator: qcom-rpmh: Implement > get_optimum_mode(), not set_load()") the above meant that we were able > to set either LPM or HPM mode. After that commit (and fixes [1]) we'll > be stuck at the initial mode. Discussion of this has resulted in the > decision that the old dts files were wrong and should be fixed to > fully restore old functionality. > > Let's re-enable the old functionality by fixing the dts. > > [1] https://lore.kernel.org/r/20220824142229.RFT.v2.2.I6f77860e5cd98bf5c67208fa9edda4a08847c304@changeid > > Fixes: 519183af39b2 ("arm64: dts: qcom: add SA8540P and ADP") > Signed-off-by: Douglas Anderson Reviewed-by: Andrew Halaney > --- > > arch/arm64/boot/dts/qcom/sa8295p-adp.dts | 45 ++++++++++++++++++++++++ > 1 file changed, 45 insertions(+) > > diff --git a/arch/arm64/boot/dts/qcom/sa8295p-adp.dts b/arch/arm64/boot/dts/qcom/sa8295p-adp.dts > index 9398f0349944..6d05cb54e32f 100644 > --- a/arch/arm64/boot/dts/qcom/sa8295p-adp.dts > +++ b/arch/arm64/boot/dts/qcom/sa8295p-adp.dts > @@ -36,6 +36,9 @@ vreg_l3a: ldo3 { > regulator-max-microvolt = <1208000>; > regulator-initial-mode = ; > regulator-allow-set-load; > + regulator-allowed-modes = > + + RPMH_REGULATOR_MODE_HPM>; > }; > > vreg_l5a: ldo5 { > @@ -44,6 +47,9 @@ vreg_l5a: ldo5 { > regulator-max-microvolt = <912000>; > regulator-initial-mode = ; > regulator-allow-set-load; > + regulator-allowed-modes = > + + RPMH_REGULATOR_MODE_HPM>; > }; > > vreg_l7a: ldo7 { > @@ -52,6 +58,9 @@ vreg_l7a: ldo7 { > regulator-max-microvolt = <1800000>; > regulator-initial-mode = ; > regulator-allow-set-load; > + regulator-allowed-modes = > + + RPMH_REGULATOR_MODE_HPM>; > }; > > vreg_l13a: ldo13 { > @@ -60,6 +69,9 @@ vreg_l13a: ldo13 { > regulator-max-microvolt = <3072000>; > regulator-initial-mode = ; > regulator-allow-set-load; > + regulator-allowed-modes = > + + RPMH_REGULATOR_MODE_HPM>; > }; > }; > > @@ -73,6 +85,9 @@ vreg_l1c: ldo1 { > regulator-max-microvolt = <912000>; > regulator-initial-mode = ; > regulator-allow-set-load; > + regulator-allowed-modes = > + + RPMH_REGULATOR_MODE_HPM>; > }; > > vreg_l2c: ldo2 { > @@ -81,6 +96,9 @@ vreg_l2c: ldo2 { > regulator-max-microvolt = <3072000>; > regulator-initial-mode = ; > regulator-allow-set-load; > + regulator-allowed-modes = > + + RPMH_REGULATOR_MODE_HPM>; > }; > > vreg_l3c: ldo3 { > @@ -89,6 +107,9 @@ vreg_l3c: ldo3 { > regulator-max-microvolt = <1200000>; > regulator-initial-mode = ; > regulator-allow-set-load; > + regulator-allowed-modes = > + + RPMH_REGULATOR_MODE_HPM>; > }; > > vreg_l4c: ldo4 { > @@ -97,6 +118,9 @@ vreg_l4c: ldo4 { > regulator-max-microvolt = <1208000>; > regulator-initial-mode = ; > regulator-allow-set-load; > + regulator-allowed-modes = > + + RPMH_REGULATOR_MODE_HPM>; > }; > > vreg_l6c: ldo6 { > @@ -105,6 +129,9 @@ vreg_l6c: ldo6 { > regulator-max-microvolt = <1200000>; > regulator-initial-mode = ; > regulator-allow-set-load; > + regulator-allowed-modes = > + + RPMH_REGULATOR_MODE_HPM>; > }; > > vreg_l7c: ldo7 { > @@ -113,6 +140,9 @@ vreg_l7c: ldo7 { > regulator-max-microvolt = <1800000>; > regulator-initial-mode = ; > regulator-allow-set-load; > + regulator-allowed-modes = > + + RPMH_REGULATOR_MODE_HPM>; > }; > > vreg_l10c: ldo10 { > @@ -121,6 +151,9 @@ vreg_l10c: ldo10 { > regulator-max-microvolt = <2504000>; > regulator-initial-mode = ; > regulator-allow-set-load; > + regulator-allowed-modes = > + + RPMH_REGULATOR_MODE_HPM>; > }; > > vreg_l17c: ldo17 { > @@ -129,6 +162,9 @@ vreg_l17c: ldo17 { > regulator-max-microvolt = <2504000>; > regulator-initial-mode = ; > regulator-allow-set-load; > + regulator-allowed-modes = > + + RPMH_REGULATOR_MODE_HPM>; > }; > }; > > @@ -142,6 +178,9 @@ vreg_l3g: ldo3 { > regulator-max-microvolt = <1200000>; > regulator-initial-mode = ; > regulator-allow-set-load; > + regulator-allowed-modes = > + + RPMH_REGULATOR_MODE_HPM>; > }; > > vreg_l7g: ldo7 { > @@ -150,6 +189,9 @@ vreg_l7g: ldo7 { > regulator-max-microvolt = <1800000>; > regulator-initial-mode = ; > regulator-allow-set-load; > + regulator-allowed-modes = > + + RPMH_REGULATOR_MODE_HPM>; > }; > > vreg_l8g: ldo8 { > @@ -158,6 +200,9 @@ vreg_l8g: ldo8 { > regulator-max-microvolt = <880000>; > regulator-initial-mode = ; > regulator-allow-set-load; > + regulator-allowed-modes = > + + RPMH_REGULATOR_MODE_HPM>; > }; > }; > }; > -- > 2.37.2.672.g94769d06f0-goog >