From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id BA920ECAAA2 for ; Thu, 25 Aug 2022 21:35:12 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S243795AbiHYVfL (ORCPT ); Thu, 25 Aug 2022 17:35:11 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56062 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230096AbiHYVfK (ORCPT ); Thu, 25 Aug 2022 17:35:10 -0400 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0DC9289CFE for ; Thu, 25 Aug 2022 14:35:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1661463308; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=JICveRMgrKIohjs6LWwa5w2kG83O8Uzo7FGURzBNI/k=; b=OfBpQ2d68ujtqPWPtkiZh8B/9WtWuKR8Y3wTRz4Dj9uUy1mfXURzq01GwZgt2AiNcqhVLH PeaUCJxh/dtL0wQWD4PYM7s5ofxqcOOYVLw97bjEurhQglgNPdLjzeI7J2zVmXY52phIQ3 2fcbaQ6Cx9lKjsZqFqrqA7uxYZvXngs= Received: from mail-qt1-f198.google.com (mail-qt1-f198.google.com [209.85.160.198]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-557-QJIwK37vOrijaa27OXs1EA-1; Thu, 25 Aug 2022 17:35:06 -0400 X-MC-Unique: QJIwK37vOrijaa27OXs1EA-1 Received: by mail-qt1-f198.google.com with SMTP id ci6-20020a05622a260600b0034370b6f5d6so16209766qtb.14 for ; Thu, 25 Aug 2022 14:35:06 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc; bh=JICveRMgrKIohjs6LWwa5w2kG83O8Uzo7FGURzBNI/k=; b=jl+CQm2brvw0JgL/QurodDXOPbiu8Uw/28f+ZT2onbjAIYhez7oVGrA/r6unRE7Urn CiUNbjGrZ/gBiRo1ibsvKODx8u61MFzW+OTOEVcdylpRIKncDGoA6fpP2/pgwLCrHiYe Dv40qjDZzYXpDl7pyamT5CwPXQN293kXf/zinIJy2T36oN/Y9T5qE34hQrsttwTWuL4U gaazOfPGMi1ku08Bl+Llg/82+XvOgmXzOAZ+VW9ivvgeFcch6uwXhE2954fui5B9K84u a7sn3pDz/fYb+XNr3k2ZVyL841gisktFSdS5bbb0ZbMEXH+gUwoclVKl8h2FoGAaSipK bJrg== X-Gm-Message-State: ACgBeo0/OG8yNFCuKLYzqMO+TtSOfd/+jXAhZt6tFdggqkH41XwHv9i4 zLTJML/uhYApUGpRaNX0Fabeyz0XMNzP7lC8GfknC+TC5cg2Z29DfANNdl3/QMziOWbkvTA5vlQ 12GQkAE+FTJFzB6q1Lgnjyg== X-Received: by 2002:a05:622a:2d1:b0:343:6193:3348 with SMTP id a17-20020a05622a02d100b0034361933348mr5387437qtx.633.1661463306175; Thu, 25 Aug 2022 14:35:06 -0700 (PDT) X-Google-Smtp-Source: AA6agR7vekjCktFDw9vN21MT/LB4Vvr1Rgv1cTA5GVVEQ3/sr6cpjl8oaIlGlzKDMRTi+yXJyQ0xRQ== X-Received: by 2002:a05:622a:2d1:b0:343:6193:3348 with SMTP id a17-20020a05622a02d100b0034361933348mr5387423qtx.633.1661463305953; Thu, 25 Aug 2022 14:35:05 -0700 (PDT) Received: from halaneylaptop ([2600:1700:1ff0:d0e0::48]) by smtp.gmail.com with ESMTPSA id h15-20020a05622a170f00b003436103df40sm77411qtk.8.2022.08.25.14.35.05 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 25 Aug 2022 14:35:05 -0700 (PDT) Date: Thu, 25 Aug 2022 16:35:03 -0500 From: Andrew Halaney To: Douglas Anderson Cc: Bjorn Andersson , Mark Brown , Andy Gross , Johan Hovold , Konrad Dybcio , Krzysztof Kozlowski , Rob Herring , devicetree@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 3/7] arm64: dts: qcom: sc8280xp-crd: Specify which LDO modes are allowed Message-ID: <20220825213503.2appw3rguwnnuxw6@halaneylaptop> References: <20220825164205.4060647-1-dianders@chromium.org> <20220825094155.3.Ie7d2c50d2b42ef2d364f3a0c8e300e5ce1875b79@changeid> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220825094155.3.Ie7d2c50d2b42ef2d364f3a0c8e300e5ce1875b79@changeid> Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On Thu, Aug 25, 2022 at 09:42:01AM -0700, Douglas Anderson wrote: > This board uses RPMH, specifies "regulator-allow-set-load" for LDOs, > but doesn't specify any modes with "regulator-allowed-modes". > > Prior to commit efb0cb50c427 ("regulator: qcom-rpmh: Implement > get_optimum_mode(), not set_load()") the above meant that we were able > to set either LPM or HPM mode. After that commit (and fixes [1]) we'll > be stuck at the initial mode. Discussion of this has resulted in the > decision that the old dts files were wrong and should be fixed to > fully restore old functionality. > > Let's re-enable the old functionality by fixing the dts. > > [1] https://lore.kernel.org/r/20220824142229.RFT.v2.2.I6f77860e5cd98bf5c67208fa9edda4a08847c304@changeid > > Fixes: ccd3517faf18 ("arm64: dts: qcom: sc8280xp: Add reference device") > Signed-off-by: Douglas Anderson Reviewed-by: Andrew Halaney > --- > > arch/arm64/boot/dts/qcom/sc8280xp-crd.dts | 33 +++++++++++++++++++++++ > 1 file changed, 33 insertions(+) > > diff --git a/arch/arm64/boot/dts/qcom/sc8280xp-crd.dts b/arch/arm64/boot/dts/qcom/sc8280xp-crd.dts > index d6f272c71a47..f64d58e371bd 100644 > --- a/arch/arm64/boot/dts/qcom/sc8280xp-crd.dts > +++ b/arch/arm64/boot/dts/qcom/sc8280xp-crd.dts > @@ -88,6 +88,9 @@ vreg_l3b: ldo3 { > regulator-max-microvolt = <1200000>; > regulator-initial-mode = ; > regulator-allow-set-load; > + regulator-allowed-modes = > + + RPMH_REGULATOR_MODE_HPM>; > regulator-boot-on; > regulator-always-on; > }; > @@ -98,6 +101,9 @@ vreg_l4b: ldo4 { > regulator-max-microvolt = <912000>; > regulator-initial-mode = ; > regulator-allow-set-load; > + regulator-allowed-modes = > + + RPMH_REGULATOR_MODE_HPM>; > }; > > vreg_l6b: ldo6 { > @@ -106,6 +112,9 @@ vreg_l6b: ldo6 { > regulator-max-microvolt = <880000>; > regulator-initial-mode = ; > regulator-allow-set-load; > + regulator-allowed-modes = > + + RPMH_REGULATOR_MODE_HPM>; > regulator-boot-on; > }; > }; > @@ -120,6 +129,9 @@ vreg_l1c: ldo1 { > regulator-max-microvolt = <1800000>; > regulator-initial-mode = ; > regulator-allow-set-load; > + regulator-allowed-modes = > + + RPMH_REGULATOR_MODE_HPM>; > }; > > vreg_l7c: ldo7 { > @@ -128,6 +140,9 @@ vreg_l7c: ldo7 { > regulator-max-microvolt = <2504000>; > regulator-initial-mode = ; > regulator-allow-set-load; > + regulator-allowed-modes = > + + RPMH_REGULATOR_MODE_HPM>; > }; > > vreg_l13c: ldo13 { > @@ -136,6 +151,9 @@ vreg_l13c: ldo13 { > regulator-max-microvolt = <3072000>; > regulator-initial-mode = ; > regulator-allow-set-load; > + regulator-allowed-modes = > + + RPMH_REGULATOR_MODE_HPM>; > }; > }; > > @@ -151,6 +169,9 @@ vreg_l3d: ldo3 { > regulator-max-microvolt = <1200000>; > regulator-initial-mode = ; > regulator-allow-set-load; > + regulator-allowed-modes = > + + RPMH_REGULATOR_MODE_HPM>; > }; > > vreg_l4d: ldo4 { > @@ -159,6 +180,9 @@ vreg_l4d: ldo4 { > regulator-max-microvolt = <1200000>; > regulator-initial-mode = ; > regulator-allow-set-load; > + regulator-allowed-modes = > + + RPMH_REGULATOR_MODE_HPM>; > }; > > vreg_l6d: ldo6 { > @@ -167,6 +191,9 @@ vreg_l6d: ldo6 { > regulator-max-microvolt = <880000>; > regulator-initial-mode = ; > regulator-allow-set-load; > + regulator-allowed-modes = > + + RPMH_REGULATOR_MODE_HPM>; > }; > > vreg_l7d: ldo7 { > @@ -175,6 +202,9 @@ vreg_l7d: ldo7 { > regulator-max-microvolt = <3072000>; > regulator-initial-mode = ; > regulator-allow-set-load; > + regulator-allowed-modes = > + + RPMH_REGULATOR_MODE_HPM>; > }; > > vreg_l9d: ldo9 { > @@ -183,6 +213,9 @@ vreg_l9d: ldo9 { > regulator-max-microvolt = <912000>; > regulator-initial-mode = ; > regulator-allow-set-load; > + regulator-allowed-modes = > + + RPMH_REGULATOR_MODE_HPM>; > }; > }; > }; > -- > 2.37.2.672.g94769d06f0-goog >