From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9EDC0ECAAA3 for ; Fri, 26 Aug 2022 09:20:42 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S245712AbiHZJUk (ORCPT ); Fri, 26 Aug 2022 05:20:40 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48590 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1343645AbiHZJUa (ORCPT ); Fri, 26 Aug 2022 05:20:30 -0400 Received: from mail.pr-group.ru (mail.pr-group.ru [178.18.215.3]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 662F6C6CF3; Fri, 26 Aug 2022 02:20:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=metrotek.ru; s=mail; h=from:subject:date:message-id:to:cc:mime-version:content-type:in-reply-to: references; bh=2AKJkBRzZEXX9oMXeLTTHymBPdK/bRW+qRnxJRAdUtY=; b=NJhBm/AwFKnOcGxAg7z3XwYvLazErcCyihTKGixiQzHd3hIleMAMNlru+I8cnUP0HgfSflJBUaweX qu7bsAGTM6rNcRajozOI1jwIckGKlDAocVUfzrjpvzHM2mAcqaMd9reCZR2uwLeTChr7Wg0SXnRQdB 4otBIRLfEcHvd3QII67G2b1JRwo7TfXgXku436TkgMKlgrWralYYwdAVFWWXqu5vMqmgLwUe1MzaPg QfAHdiAhFImpPOKylBoL3507UjKLPwKzGqVQzpsrkcTQmaL0tMCzpRuI/+/sKGnwztvXoe+9EHp4QB 9mbiP+Ljjymi+MwB6a8l9/YuW4xWFkw== X-Kerio-Anti-Spam: Build: [Engines: 2.16.4.1445, Stamp: 3], Multi: [Enabled, t: (0.000011,0.012105)], BW: [Enabled, t: (0.000024,0.000001)], RTDA: [Enabled, t: (0.343412), Hit: No, Details: v2.41.0; Id: 15.52kaig.1gbcn79br.13s; mclb], total: 0(700) X-Footer: bWV0cm90ZWsucnU= Received: from h-e2.ddg ([85.143.252.66]) (authenticated user i.bornyakov@metrotek.ru) by mail.pr-group.ru with ESMTPSA (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256 bits)); Fri, 26 Aug 2022 12:20:09 +0300 Date: Fri, 26 Aug 2022 12:19:12 +0300 From: Ivan Bornyakov To: Sascha Hauer Cc: j.zink@pengutronix.de, devicetree@vger.kernel.org, linux-fpga@vger.kernel.org, robh+dt@kernel.org, mdf@kernel.org, kernel@pengutronix.de, yilun.xu@intel.com, hao.wu@intel.com Subject: Re: [PATCH 00/16] Add support for Lattice MachXO2 programming via I2C Message-ID: <20220826091912.xunn3cv3gwhktjib@h-e2.ddg> References: <20220825141343.1375690-1-j.zink@pengutronix.de> <20220825152514.9926-1-i.bornyakov@metrotek.ru> <20220826082539.GA12909@pengutronix.de> <20220826090042.jhngyeufei55b5c2@h-e2.ddg> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220826090042.jhngyeufei55b5c2@h-e2.ddg> Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On Fri, Aug 26, 2022 at 12:00:44PM +0300, Ivan Bornyakov wrote: > On Fri, Aug 26, 2022 at 10:25:39AM +0200, Sascha Hauer wrote: > > Hi Ivan, > > > > On Thu, Aug 25, 2022 at 06:25:14PM +0300, Ivan Bornyakov wrote: > > > Hi, Johannes! > > > > > > I just came across your patches. Surprisingly, our work interferes. > > > > > > I recently posted patch-series for configuring ECP5 and was asked to make > > > generalized sysCONFIG driver with support for both ECP5 and MachXO2, which > > > I did. Sadly I don't have hardware with MachXO2, but you clearly do :) > > > > > > Please, take a look at > > > > > > https://lore.kernel.org/linux-fpga/20220825112433.14583-1-i.bornyakov@metrotek.ru/ > > > > > > and please help test MachXO2 variant. When we pull this off, you may add I2C > > > interface on top. > > > > You are adding a new driver for something we already have a driver for > > in the tree. > > My intent was to add new driver and drop old one once the new driver is > proven to be working. > > > The final goal should be that we only have a single driver > > for sysconfig based FPGAs in the tree. > > It is. > > > Johannes' series is a step in > > that direction: He cleans up the existing driver and starts abstracting > > out common sysconfig functions so that they can be used by both the I2C > > and SPI interface. He just told me that the abstraction is likely not > > enough to integrate ECP5 support right away, one reason being that the > > machxo2 has a flash whereas the ECP5 does not. > > > > Unless you can explain why the existing driver is broken beyond repair > > I think we should rather incrementally improve the existing driver > > instead of adding a new one with a conflicting compatible. > > Yeah, conflicting compatible was my oversight. > Wait! They are not conflicting :) The new one is "lattice,machxo2-fpga-mgr", the old one is "lattice,machxo2-slave-spi" > > So despite you were in the room earlier I think you should rather base > > your work on Johannes' series. > > We on par here. You guys didn't join ongoing work, I didn't rework > existing driver. > > > > > Just my 2 cents, maybe one of the maintainers has a few words on it. > > > > Sascha > > > > > > -- > > Pengutronix e.K. | | > > Steuerwalder Str. 21 | http://www.pengutronix.de/ | > > 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | > > Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |