From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 467B3C0502C for ; Mon, 29 Aug 2022 22:30:41 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229629AbiH2Wak (ORCPT ); Mon, 29 Aug 2022 18:30:40 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40160 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229446AbiH2Waj (ORCPT ); Mon, 29 Aug 2022 18:30:39 -0400 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 408794D4D1; Mon, 29 Aug 2022 15:30:38 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id D4821B8136A; Mon, 29 Aug 2022 22:30:36 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 5A49CC433C1; Mon, 29 Aug 2022 22:30:35 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1661812235; bh=XR4jQathTB6ZptuH+sL9t6uDcotuMvsfdYzhSPZG6gI=; h=In-Reply-To:References:Subject:From:Cc:To:Date:From; b=R+WH0iPW9Zf1owPKGWvfw9Bm6hcGCZ1ybMoBzojSSsUvC4/ER0vvqTcP5EssPuV0v d16cqYHuosEVZK1krOIeion/MiZ7Dn1mTyMlR/hdnfAfyEhehy5PSc8ts6YdJoK2wu WikLN8F4DoVnPVV7NNipLykUvmKTzqbqoGcTZWroN2NRtWMqi4CuyklZ9bq+91gbvy HtM5WSn3PkOc908fgiFmh7JiyQx+R6HxpBakqwJM9y1gdgpokvQyADg/rR/EDv09do 6knZvPQ1M95yI5qT2/MpxX6yAgw6Xx+OAl69ImLTKYa7jBy29/E24HVgSI2yqiYzyZ Gp92yAP0lDLzA== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable In-Reply-To: <1661714479-28981-1-git-send-email-quic_akhilpo@quicinc.com> References: <1661714479-28981-1-git-send-email-quic_akhilpo@quicinc.com> Subject: Re: [PATCH v5 0/6] clk/qcom: Support gdsc collapse polling using 'reset' interface From: Stephen Boyd Cc: krzysztof.kozlowski@linaro.org, Douglas Anderson , Akhil P Oommen , Abhinav Kumar , Andy Gross , Daniel Vetter , David Airlie , Konrad Dybcio , Krzysztof Kozlowski , Michael Turquette , Rob Herring , Sean Paul , Stephen Boyd , devicetree@vger.kernel.org, linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org To: Akhil P Oommen , Bjorn Andersson , Dmitry Baryshkov , Rob Clark , dri-devel@lists.freedesktop.org, freedreno , linux-arm-msm@vger.kernel.org, Philipp Zabel Date: Mon, 29 Aug 2022 15:30:33 -0700 User-Agent: alot/0.10 Message-Id: <20220829223035.5A49CC433C1@smtp.kernel.org> Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org +Philipp Quoting Akhil P Oommen (2022-08-28 12:21:13) >=20 > Some clients like adreno gpu driver would like to ensure that its gdsc > is collapsed at hardware during a gpu reset sequence. This is because it > has a votable gdsc which could be ON due to a vote from another subsystem > like tz, hyp etc or due to an internal hardware signal. To allow > this, gpucc driver can expose an interface to the client driver using > reset framework. Using this the client driver can trigger a polling within > the gdsc driver. Please include the reset maintainer on reset related patches. -Stephen >=20 > This series is rebased on top of linus's master branch. >=20 > Related discussion: https://patchwork.freedesktop.org/patch/493144/ >=20 > Changes in v5: > - Nit: Remove a duplicate blank line (Krzysztof) >=20 > Changes in v4: > - Update gpu dt-binding schema > - Typo fix in commit text >=20 > Changes in v3: > - Use pointer to const for "struct qcom_reset_ops" in qcom_reset_map (Krz= ysztof) >=20 > Changes in v2: > - Return error when a particular custom reset op is not implemented. (Dmi= try) >=20 > Akhil P Oommen (6): > dt-bindings: clk: qcom: Support gpu cx gdsc reset > clk: qcom: Allow custom reset ops > clk: qcom: gdsc: Add a reset op to poll gdsc collapse > clk: qcom: gpucc-sc7280: Add cx collapse reset support > dt-bindings: drm/msm/gpu: Add optional resets > arm64: dts: qcom: sc7280: Add Reset support for gpu >=20 > .../devicetree/bindings/display/msm/gpu.yaml | 6 +++++ > arch/arm64/boot/dts/qcom/sc7280.dtsi | 3 +++ > drivers/clk/qcom/gdsc.c | 23 ++++++++++++++--= -- > drivers/clk/qcom/gdsc.h | 7 ++++++ > drivers/clk/qcom/gpucc-sc7280.c | 10 ++++++++ > drivers/clk/qcom/reset.c | 27 ++++++++++++++++= ++++++ > drivers/clk/qcom/reset.h | 8 +++++++ > include/dt-bindings/clock/qcom,gpucc-sc7280.h | 3 +++ > 8 files changed, 83 insertions(+), 4 deletions(-)