* [PATCH v5 1/2] dts: arm: Adding documentation for SAMA5D3-EDS board @ 2022-08-30 15:24 Jerry Ray 2022-08-30 15:24 ` [PATCH v5 2/2] dts: arm: at91: Add " Jerry Ray 2022-08-30 16:57 ` [PATCH v5 1/2] dts: arm: Adding documentation for " Krzysztof Kozlowski 0 siblings, 2 replies; 6+ messages in thread From: Jerry Ray @ 2022-08-30 15:24 UTC (permalink / raw) To: Rob Herring, Nicolas Ferre, Alexandre Belloni, Ludovic Desroches, devicetree, linux-arm-kernel, linux-kernel, Jerry Ray Adding the SAMA5D3-EDS board from Microchip into the atmel AT91 board description yaml file. Signed-off-by: Jerry Ray <jerry.ray@microchip.com> Acked-by: Rob Herring <robh@kernel.org> --- v4->v5: - No change v3->v4: - No change v2->v3: - No change v1->v2: - Added Device Tree documentation for Microchip SAMA5D3-EDS board --- Documentation/devicetree/bindings/arm/atmel-at91.yaml | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/Documentation/devicetree/bindings/arm/atmel-at91.yaml b/Documentation/devicetree/bindings/arm/atmel-at91.yaml index 08efb259a947..635491aaeb0c 100644 --- a/Documentation/devicetree/bindings/arm/atmel-at91.yaml +++ b/Documentation/devicetree/bindings/arm/atmel-at91.yaml @@ -138,6 +138,13 @@ properties: - const: atmel,at91sam9g20 - const: atmel,at91sam9 + - description: Microchip SAMA5D3 Ethernet Development System Board + items: + - const: microchip,sama5d3-eds + - const: atmel,sama5d36 + - const: atmel,sama5d3 + - const: atmel,sama5 + - items: - enum: - atmel,sama5d31 -- 2.17.1 ^ permalink raw reply related [flat|nested] 6+ messages in thread
* [PATCH v5 2/2] dts: arm: at91: Add SAMA5D3-EDS board 2022-08-30 15:24 [PATCH v5 1/2] dts: arm: Adding documentation for SAMA5D3-EDS board Jerry Ray @ 2022-08-30 15:24 ` Jerry Ray 2022-08-30 17:02 ` Krzysztof Kozlowski 2022-08-30 16:57 ` [PATCH v5 1/2] dts: arm: Adding documentation for " Krzysztof Kozlowski 1 sibling, 1 reply; 6+ messages in thread From: Jerry Ray @ 2022-08-30 15:24 UTC (permalink / raw) To: Rob Herring, Nicolas Ferre, Alexandre Belloni, Ludovic Desroches, devicetree, linux-arm-kernel, linux-kernel, Jerry Ray The SAMA5D3-EDS board is an Ethernet Development Platform allowing for evaluating many Microchip ethernet switch and PHY products. Various daughter cards can connect up via an RGMII connector or an RMII connector. The EDS board is not intended for stand-alone use and has no ethernet capabilities when no daughter board is connected. As such, this device tree is intended to be used with a DT overlay defining the add-on board. To better ensure consistency, some items are defined here as a form of documentation so that all add-on overlays will use the same terms. Google search keywords: "Microchip SAMA5D3-EDS" Signed-off-by: Jerry Ray <jerry.ray@microchip.com> --- v4->v5: - patch now applies to v6.0-rc2 v3->v4: - Fixed regulators as necessary to get the board to boot from SD Card. v2->v3: - Alphabetized pinctrl entries. - cleaned up a warning in the regulators section. - License tweaked to 'OR MIT' - Included Makefile change v1->v2: - Modified the compatible field in the device tree to reflect Microchip Ethernet Development System Board. --- arch/arm/boot/dts/Makefile | 1 + arch/arm/boot/dts/at91-sama5d3_eds.dts | 309 +++++++++++++++++++++++++ 2 files changed, 310 insertions(+) create mode 100644 arch/arm/boot/dts/at91-sama5d3_eds.dts diff --git a/arch/arm/boot/dts/Makefile b/arch/arm/boot/dts/Makefile index 05d8aef6e5d2..e92e639a2dc3 100644 --- a/arch/arm/boot/dts/Makefile +++ b/arch/arm/boot/dts/Makefile @@ -61,6 +61,7 @@ dtb-$(CONFIG_SOC_SAM_V7) += \ at91-sama5d2_icp.dtb \ at91-sama5d2_ptc_ek.dtb \ at91-sama5d2_xplained.dtb \ + at91-sama5d3_eds.dtb \ at91-sama5d3_ksz9477_evb.dtb \ at91-sama5d3_xplained.dtb \ at91-dvk_som60.dtb \ diff --git a/arch/arm/boot/dts/at91-sama5d3_eds.dts b/arch/arm/boot/dts/at91-sama5d3_eds.dts new file mode 100644 index 000000000000..2e6d94b30916 --- /dev/null +++ b/arch/arm/boot/dts/at91-sama5d3_eds.dts @@ -0,0 +1,309 @@ +// SPDX-License-Identifier: GPL-2.0+ OR MIT +/* + * at91-sama5d3_eds.dts - Device Tree file for the SAMA5D3 Ethernet + * Development System board. + * + * Copyright (C) 2022 Microchip Technology Inc. and its subsidiaries + * 2022 Jerry Ray <jerry.ray@microchip.com> + */ +/dts-v1/; +#include "sama5d36.dtsi" + +/ { + model = "SAMA5D3 Ethernet Development System"; + compatible = "microchip,sama5d3-eds", "atmel,sama5d3", + "atmel,sama5"; + + chosen { + stdout-path = "serial0:115200n8"; + }; + + clocks { + slow_xtal { + clock-frequency = <32768>; + }; + + main_xtal { + clock-frequency = <12000000>; + }; + }; + + gpio_keys { + compatible = "gpio-keys"; + + pinctrl-names = "default"; + pinctrl-0 = <&pinctrl_key_gpio>; + + button-3 { + label = "PB_USER"; + gpios = <&pioE 29 GPIO_ACTIVE_LOW>; + linux,code = <0x104>; + wakeup-source; + }; + }; + + memory@20000000 { + reg = <0x20000000 0x10000000>; + }; + + vcc_3v3_reg: BUCK_REG1 { + compatible = "regulator-fixed"; + regulator-name = "VCC_3V3"; + regulator-min-microvolt = <3300000>; + regulator-max-microvolt = <3300000>; + regulator-always-on; + }; + + vcc_2v5_reg: LDO_REG2 { + compatible = "regulator-fixed"; + regulator-name = "VCC_2V5"; + regulator-min-microvolt = <2500000>; + regulator-max-microvolt = <2500000>; + regulator-always-on; + vin-supply = <&vcc_3v3_reg>; + }; + + vcc_1v8_reg: LDO_REG3 { + compatible = "regulator-fixed"; + regulator-name = "VCC_1V8"; + regulator-min-microvolt = <1800000>; + regulator-max-microvolt = <1800000>; + regulator-always-on; + vin-supply = <&vcc_3v3_reg>; + }; + + vcc_1v2_reg: BUCK_REG4 { + compatible = "regulator-fixed"; + regulator-name = "VCC_1V2"; + regulator-min-microvolt = <1200000>; + regulator-max-microvolt = <1200000>; + regulator-always-on; + }; + + vcc_mmc0_reg: fixedregulator_mmc0 { + compatible = "regulator-fixed"; + regulator-name = "mmc0-card-supply"; + regulator-min-microvolt = <3300000>; + regulator-max-microvolt = <3300000>; + regulator-always-on; + pinctrl-names = "default"; + pinctrl-0 = <&pinctrl_vcc_mmc0_reg_gpio>; + gpio = <&pioE 2 GPIO_ACTIVE_LOW>; + }; +}; + +&can0 { + status = "okay"; +}; + +&dbgu { + status = "okay"; +}; + +&ebi { + pinctrl-0 = <&pinctrl_ebi_nand_addr>; + pinctrl-names = "default"; + status = "okay"; + + nand_controller: nand-controller { + status = "okay"; + + nand@3 { + reg = <0x3 0x0 0x2>; + atmel,rb = <0>; + nand-bus-width = <8>; + nand-ecc-mode = "hw"; + nand-ecc-strength = <4>; + nand-ecc-step-size = <512>; + nand-on-flash-bbt; + label = "atmel_nand"; + + partitions { + compatible = "fixed-partitions"; + #address-cells = <1>; + #size-cells = <1>; + + at91bootstrap@0 { + label = "at91bootstrap"; + reg = <0x0 0x40000>; + }; + + bootloader@40000 { + label = "bootloader"; + reg = <0x40000 0xc0000>; + }; + + bootloaderenvred@100000 { + label = "bootloader env redundant"; + reg = <0x100000 0x40000>; + }; + + bootloaderenv@140000 { + label = "bootloader env"; + reg = <0x140000 0x40000>; + }; + + dtb@180000 { + label = "device tree"; + reg = <0x180000 0x80000>; + }; + + kernel@200000 { + label = "kernel"; + reg = <0x200000 0x600000>; + }; + + rootfs@800000 { + label = "rootfs"; + reg = <0x800000 0x0f800000>; + }; + }; + }; + }; +}; + +&i2c0 { + pinctrl-0 = <&pinctrl_i2c0_pu>; + status = "okay"; +}; + +&i2c1 { + status = "okay"; +}; + +&i2c2 { + dmas = <0>, <0>; /* Do not use DMA for i2c2 */ + pinctrl-0 = <&pinctrl_i2c2_pu>; + status = "okay"; +}; + +&mmc0 { + pinctrl-0 = <&pinctrl_mmc0_clk_cmd_dat0 &pinctrl_mmc0_dat1_3 + &pinctrl_mmc0_dat4_7 &pinctrl_mmc0_cd>; + vmmc-supply = <&vcc_mmc0_reg>; + vqmmc-supply = <&vcc_3v3_reg>; + status = "okay"; + slot@0 { + reg = <0>; + bus-width = <8>; + cd-gpios = <&pioE 0 GPIO_ACTIVE_LOW>; + }; +}; + +&pinctrl { + board { + pinctrl_i2c0_pu: i2c0_pu { + atmel,pins = + <AT91_PIOA 30 AT91_PERIPH_A AT91_PINCTRL_PULL_UP>, + <AT91_PIOA 31 AT91_PERIPH_A AT91_PINCTRL_PULL_UP>; + }; + + pinctrl_i2c2_pu: i2c2_pu { + atmel,pins = + <AT91_PIOA 18 AT91_PERIPH_B AT91_PINCTRL_PULL_UP>, + <AT91_PIOA 19 AT91_PERIPH_B AT91_PINCTRL_PULL_UP>; + }; + + pinctrl_key_gpio: key_gpio_0 { + atmel,pins = + <AT91_PIOE 29 AT91_PERIPH_GPIO AT91_PINCTRL_PULL_UP_DEGLITCH>; + }; + + pinctrl_mmc0_cd: mmc0_cd { + atmel,pins = + <AT91_PIOE 0 AT91_PERIPH_GPIO AT91_PINCTRL_PULL_UP_DEGLITCH>; + }; + + /* Reserved for reset signal to the RGMII connector. */ + pinctrl_rgmii_rstn: rgmii_rstn { + atmel,pins = + <AT91_PIOD 18 AT91_PERIPH_GPIO AT91_PINCTRL_PULL_UP_DEGLITCH>; + }; + + /* Reserved for an interrupt line from the RMII and RGMII connectors. */ + pinctrl_spi_irqn: spi_irqn { + atmel,pins = + <AT91_PIOB 28 AT91_PERIPH_GPIO AT91_PINCTRL_DEGLITCH>; + }; + + pinctrl_spi0_cs: spi0_cs_default { + atmel,pins = + <AT91_PIOD 13 AT91_PERIPH_GPIO AT91_PINCTRL_NONE + AT91_PIOD 16 AT91_PERIPH_GPIO AT91_PINCTRL_NONE>; + }; + + pinctrl_spi1_cs: spi1_cs_default { + atmel,pins = <AT91_PIOC 25 AT91_PERIPH_GPIO AT91_PINCTRL_NONE + AT91_PIOC 28 AT91_PERIPH_GPIO AT91_PINCTRL_NONE>; + }; + + pinctrl_usba_vbus: usba_vbus { + atmel,pins = + <AT91_PIOE 9 AT91_PERIPH_GPIO AT91_PINCTRL_DEGLITCH>; + }; + + pinctrl_usb_default: usb_default { + atmel,pins = + <AT91_PIOE 3 AT91_PERIPH_GPIO AT91_PINCTRL_NONE + AT91_PIOE 4 AT91_PERIPH_GPIO AT91_PINCTRL_NONE>; + }; + + /* Reserved for VBUS fault interrupt. */ + pinctrl_vbusfault_irqn: vbusfault_irqn { + atmel,pins = + <AT91_PIOE 5 AT91_PERIPH_GPIO AT91_PINCTRL_DEGLITCH>; + }; + + pinctrl_vcc_mmc0_reg_gpio: vcc_mmc0_reg_gpio_default { + atmel,pins = <AT91_PIOE 2 AT91_PERIPH_GPIO AT91_PINCTRL_PULL_UP>; + }; + }; +}; + +&spi0 { + pinctrl-names = "default", "cs"; + pinctrl-1 = <&pinctrl_spi0_cs>; + cs-gpios = <&pioD 13 0>, <0>, <0>, <&pioD 16 0>; + status = "okay"; +}; + +&spi1 { + pinctrl-names = "default", "cs"; + pinctrl-1 = <&pinctrl_spi1_cs>; + cs-gpios = <&pioC 25 0>, <0>, <0>, <&pioC 28 0>; + status = "okay"; +}; + +&tcb0 { + timer0: timer@0 { + compatible = "atmel,tcb-timer"; + reg = <0>; + }; + + timer1: timer@1 { + compatible = "atmel,tcb-timer"; + reg = <1>; + }; +}; + +&usb0 { + atmel,vbus-gpio = <&pioE 9 GPIO_ACTIVE_HIGH>; + pinctrl-names = "default"; + pinctrl-0 = <&pinctrl_usba_vbus>; + status = "okay"; +}; + +&usb1 { + atmel,vbus-gpio = <0 + &pioE 3 GPIO_ACTIVE_HIGH + &pioE 4 GPIO_ACTIVE_HIGH + >; + pinctrl-names = "default"; + pinctrl-0 = <&pinctrl_usb_default>; + num-ports = <3>; + status = "okay"; +}; + +&usb2 { + status = "okay"; +}; -- 2.17.1 ^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH v5 2/2] dts: arm: at91: Add SAMA5D3-EDS board 2022-08-30 15:24 ` [PATCH v5 2/2] dts: arm: at91: Add " Jerry Ray @ 2022-08-30 17:02 ` Krzysztof Kozlowski 2022-08-30 20:16 ` Jerry.Ray 0 siblings, 1 reply; 6+ messages in thread From: Krzysztof Kozlowski @ 2022-08-30 17:02 UTC (permalink / raw) To: Jerry Ray, Rob Herring, Nicolas Ferre, Alexandre Belloni, Ludovic Desroches, devicetree, linux-arm-kernel, linux-kernel On 30/08/2022 18:24, Jerry Ray wrote: > The SAMA5D3-EDS board is an Ethernet Development Platform allowing for > evaluating many Microchip ethernet switch and PHY products. Various > daughter cards can connect up via an RGMII connector or an RMII connector. > Use subject prefixes matching the subsystem (git log --oneline -- ...). > The EDS board is not intended for stand-alone use and has no ethernet > capabilities when no daughter board is connected. As such, this device > tree is intended to be used with a DT overlay defining the add-on board. > To better ensure consistency, some items are defined here as a form of > documentation so that all add-on overlays will use the same terms. > > Google search keywords: "Microchip SAMA5D3-EDS" > > Signed-off-by: Jerry Ray <jerry.ray@microchip.com> > --- > v4->v5: > - patch now applies to v6.0-rc2 If this is rebased, why you did not CC me? > v3->v4: > - Fixed regulators as necessary to get the board to boot from SD Card. > v2->v3: > - Alphabetized pinctrl entries. > - cleaned up a warning in the regulators section. > - License tweaked to 'OR MIT' > - Included Makefile change > v1->v2: > - Modified the compatible field in the device tree to reflect Microchip > Ethernet Development System Board. > --- > arch/arm/boot/dts/Makefile | 1 + > arch/arm/boot/dts/at91-sama5d3_eds.dts | 309 +++++++++++++++++++++++++ > 2 files changed, 310 insertions(+) > create mode 100644 arch/arm/boot/dts/at91-sama5d3_eds.dts > > diff --git a/arch/arm/boot/dts/Makefile b/arch/arm/boot/dts/Makefile > index 05d8aef6e5d2..e92e639a2dc3 100644 > --- a/arch/arm/boot/dts/Makefile > +++ b/arch/arm/boot/dts/Makefile > @@ -61,6 +61,7 @@ dtb-$(CONFIG_SOC_SAM_V7) += \ > at91-sama5d2_icp.dtb \ > at91-sama5d2_ptc_ek.dtb \ > at91-sama5d2_xplained.dtb \ > + at91-sama5d3_eds.dtb \ > at91-sama5d3_ksz9477_evb.dtb \ > at91-sama5d3_xplained.dtb \ > at91-dvk_som60.dtb \ > diff --git a/arch/arm/boot/dts/at91-sama5d3_eds.dts b/arch/arm/boot/dts/at91-sama5d3_eds.dts > new file mode 100644 > index 000000000000..2e6d94b30916 > --- /dev/null > +++ b/arch/arm/boot/dts/at91-sama5d3_eds.dts > @@ -0,0 +1,309 @@ > +// SPDX-License-Identifier: GPL-2.0+ OR MIT > +/* > + * at91-sama5d3_eds.dts - Device Tree file for the SAMA5D3 Ethernet > + * Development System board. > + * > + * Copyright (C) 2022 Microchip Technology Inc. and its subsidiaries > + * 2022 Jerry Ray <jerry.ray@microchip.com> > + */ > +/dts-v1/; > +#include "sama5d36.dtsi" > + > +/ { > + model = "SAMA5D3 Ethernet Development System"; > + compatible = "microchip,sama5d3-eds", "atmel,sama5d3", > + "atmel,sama5"; This does not match your bindings. > + > + chosen { > + stdout-path = "serial0:115200n8"; > + }; > + > + clocks { > + slow_xtal { No underscores in node names. Generic node names, so at least add some generic prefix or suffix, e.g.: "slow-xtal-clock" > + clock-frequency = <32768>; > + }; > + > + main_xtal { Ditto, e.g. main-xtal-clock > + clock-frequency = <12000000>; > + }; > + }; > + > + gpio_keys { No underscores... > + compatible = "gpio-keys"; > + > + pinctrl-names = "default"; > + pinctrl-0 = <&pinctrl_key_gpio>; > + > + button-3 { > + label = "PB_USER"; > + gpios = <&pioE 29 GPIO_ACTIVE_LOW>; > + linux,code = <0x104>; > + wakeup-source; > + }; > + }; > + > + memory@20000000 { > + reg = <0x20000000 0x10000000>; > + }; > + > + vcc_3v3_reg: BUCK_REG1 { No, this coding style is very poor. No capital letters, no underscores. Use generic node names, e.g. "regulator-0". > + compatible = "regulator-fixed"; > + regulator-name = "VCC_3V3"; > + regulator-min-microvolt = <3300000>; > + regulator-max-microvolt = <3300000>; > + regulator-always-on; > + }; > + > + vcc_2v5_reg: LDO_REG2 { > + compatible = "regulator-fixed"; > + regulator-name = "VCC_2V5"; > + regulator-min-microvolt = <2500000>; > + regulator-max-microvolt = <2500000>; > + regulator-always-on; > + vin-supply = <&vcc_3v3_reg>; > + }; > + > + vcc_1v8_reg: LDO_REG3 { > + compatible = "regulator-fixed"; > + regulator-name = "VCC_1V8"; > + regulator-min-microvolt = <1800000>; > + regulator-max-microvolt = <1800000>; > + regulator-always-on; > + vin-supply = <&vcc_3v3_reg>; > + }; > + > + vcc_1v2_reg: BUCK_REG4 { > + compatible = "regulator-fixed"; > + regulator-name = "VCC_1V2"; > + regulator-min-microvolt = <1200000>; > + regulator-max-microvolt = <1200000>; > + regulator-always-on; > + }; > + > + vcc_mmc0_reg: fixedregulator_mmc0 { Another different pattern of naming.. > + compatible = "regulator-fixed"; > + regulator-name = "mmc0-card-supply"; > + regulator-min-microvolt = <3300000>; > + regulator-max-microvolt = <3300000>; > + regulator-always-on; > + pinctrl-names = "default"; > + pinctrl-0 = <&pinctrl_vcc_mmc0_reg_gpio>; > + gpio = <&pioE 2 GPIO_ACTIVE_LOW>; > + }; > +}; > + > +&can0 { > + status = "okay"; > +}; > + > +&dbgu { > + status = "okay"; > +}; > + > +&ebi { > + pinctrl-0 = <&pinctrl_ebi_nand_addr>; > + pinctrl-names = "default"; > + status = "okay"; > + > + nand_controller: nand-controller { > + status = "okay"; > +> + nand@3 { > + reg = <0x3 0x0 0x2>; > + atmel,rb = <0>; > + nand-bus-width = <8>; > + nand-ecc-mode = "hw"; > + nand-ecc-strength = <4>; > + nand-ecc-step-size = <512>; > + nand-on-flash-bbt; > + label = "atmel_nand"; > + > + partitions { > + compatible = "fixed-partitions"; > + #address-cells = <1>; > + #size-cells = <1>; > + > + at91bootstrap@0 { > + label = "at91bootstrap"; > + reg = <0x0 0x40000>; > + }; > + > + bootloader@40000 { > + label = "bootloader"; > + reg = <0x40000 0xc0000>; > + }; > + > + bootloaderenvred@100000 { > + label = "bootloader env redundant"; > + reg = <0x100000 0x40000>; > + }; > + > + bootloaderenv@140000 { > + label = "bootloader env"; > + reg = <0x140000 0x40000>; > + }; > + > + dtb@180000 { > + label = "device tree"; > + reg = <0x180000 0x80000>; > + }; > + > + kernel@200000 { > + label = "kernel"; > + reg = <0x200000 0x600000>; > + }; > + > + rootfs@800000 { > + label = "rootfs"; > + reg = <0x800000 0x0f800000>; > + }; > + }; > + }; > + }; > +}; > + > +&i2c0 { > + pinctrl-0 = <&pinctrl_i2c0_pu>; > + status = "okay"; > +}; > + > +&i2c1 { > + status = "okay"; > +}; > + > +&i2c2 { > + dmas = <0>, <0>; /* Do not use DMA for i2c2 */ Instead you need to remove the property. > + pinctrl-0 = <&pinctrl_i2c2_pu>; > + status = "okay"; > +}; > + > +&mmc0 { > + pinctrl-0 = <&pinctrl_mmc0_clk_cmd_dat0 &pinctrl_mmc0_dat1_3 > + &pinctrl_mmc0_dat4_7 &pinctrl_mmc0_cd>; > + vmmc-supply = <&vcc_mmc0_reg>; > + vqmmc-supply = <&vcc_3v3_reg>; > + status = "okay"; > + slot@0 { > + reg = <0>; > + bus-width = <8>; > + cd-gpios = <&pioE 0 GPIO_ACTIVE_LOW>; > + }; > +}; > + > +&pinctrl { > + board { > + pinctrl_i2c0_pu: i2c0_pu { No underscores in node names. > + atmel,pins = > + <AT91_PIOA 30 AT91_PERIPH_A AT91_PINCTRL_PULL_UP>, > + <AT91_PIOA 31 AT91_PERIPH_A AT91_PINCTRL_PULL_UP>; > + }; > + > + pinctrl_i2c2_pu: i2c2_pu { > + atmel,pins = > + <AT91_PIOA 18 AT91_PERIPH_B AT91_PINCTRL_PULL_UP>, > + <AT91_PIOA 19 AT91_PERIPH_B AT91_PINCTRL_PULL_UP>; > + }; > + > + pinctrl_key_gpio: key_gpio_0 { > + atmel,pins = > + <AT91_PIOE 29 AT91_PERIPH_GPIO AT91_PINCTRL_PULL_UP_DEGLITCH>; > + }; > + > + pinctrl_mmc0_cd: mmc0_cd { > + atmel,pins = > + <AT91_PIOE 0 AT91_PERIPH_GPIO AT91_PINCTRL_PULL_UP_DEGLITCH>; > + }; > + > + /* Reserved for reset signal to the RGMII connector. */ > + pinctrl_rgmii_rstn: rgmii_rstn { > + atmel,pins = > + <AT91_PIOD 18 AT91_PERIPH_GPIO AT91_PINCTRL_PULL_UP_DEGLITCH>; > + }; > + > + /* Reserved for an interrupt line from the RMII and RGMII connectors. */ > + pinctrl_spi_irqn: spi_irqn { > + atmel,pins = > + <AT91_PIOB 28 AT91_PERIPH_GPIO AT91_PINCTRL_DEGLITCH>; > + }; > + > + pinctrl_spi0_cs: spi0_cs_default { > + atmel,pins = > + <AT91_PIOD 13 AT91_PERIPH_GPIO AT91_PINCTRL_NONE > + AT91_PIOD 16 AT91_PERIPH_GPIO AT91_PINCTRL_NONE>; > + }; > + > + pinctrl_spi1_cs: spi1_cs_default { > + atmel,pins = <AT91_PIOC 25 AT91_PERIPH_GPIO AT91_PINCTRL_NONE > + AT91_PIOC 28 AT91_PERIPH_GPIO AT91_PINCTRL_NONE>; > + }; > + > + pinctrl_usba_vbus: usba_vbus { > + atmel,pins = > + <AT91_PIOE 9 AT91_PERIPH_GPIO AT91_PINCTRL_DEGLITCH>; > + }; > + > + pinctrl_usb_default: usb_default { > + atmel,pins = > + <AT91_PIOE 3 AT91_PERIPH_GPIO AT91_PINCTRL_NONE > + AT91_PIOE 4 AT91_PERIPH_GPIO AT91_PINCTRL_NONE>; > + }; > + > + /* Reserved for VBUS fault interrupt. */ > + pinctrl_vbusfault_irqn: vbusfault_irqn { > + atmel,pins = > + <AT91_PIOE 5 AT91_PERIPH_GPIO AT91_PINCTRL_DEGLITCH>; > + }; > + > + pinctrl_vcc_mmc0_reg_gpio: vcc_mmc0_reg_gpio_default { > + atmel,pins = <AT91_PIOE 2 AT91_PERIPH_GPIO AT91_PINCTRL_PULL_UP>; > + }; > + }; > +}; > + > +&spi0 { > + pinctrl-names = "default", "cs"; > + pinctrl-1 = <&pinctrl_spi0_cs>; > + cs-gpios = <&pioD 13 0>, <0>, <0>, <&pioD 16 0>; > + status = "okay"; > +}; > + > +&spi1 { > + pinctrl-names = "default", "cs"; > + pinctrl-1 = <&pinctrl_spi1_cs>; > + cs-gpios = <&pioC 25 0>, <0>, <0>, <&pioC 28 0>; Use proper flags. What is <0>??? > + status = "okay"; > +}; > + > +&tcb0 { > + timer0: timer@0 { > + compatible = "atmel,tcb-timer"; > + reg = <0>; > + }; > + > + timer1: timer@1 { > + compatible = "atmel,tcb-timer"; > + reg = <1>; > + }; > +}; > + > +&usb0 { > + atmel,vbus-gpio = <&pioE 9 GPIO_ACTIVE_HIGH>; > + pinctrl-names = "default"; > + pinctrl-0 = <&pinctrl_usba_vbus>; > + status = "okay"; > +}; > + > +&usb1 { > + atmel,vbus-gpio = <0 What is this 0? > + &pioE 3 GPIO_ACTIVE_HIGH > + &pioE 4 GPIO_ACTIVE_HIGH Why two GPIOs? > + >; > + pinctrl-names = "default"; > + pinctrl-0 = <&pinctrl_usb_default>; > + num-ports = <3>; > + status = "okay"; > +}; > + > +&usb2 { > + status = "okay"; > +}; Best regards, Krzysztof ^ permalink raw reply [flat|nested] 6+ messages in thread
* RE: [PATCH v5 2/2] dts: arm: at91: Add SAMA5D3-EDS board 2022-08-30 17:02 ` Krzysztof Kozlowski @ 2022-08-30 20:16 ` Jerry.Ray 2022-08-31 6:06 ` Krzysztof Kozlowski 0 siblings, 1 reply; 6+ messages in thread From: Jerry.Ray @ 2022-08-30 20:16 UTC (permalink / raw) To: krzysztof.kozlowski, robh+dt, Nicolas.Ferre, alexandre.belloni, Ludovic.Desroches, devicetree, linux-arm-kernel, linux-kernel >On 30/08/2022 18:24, Jerry Ray wrote: >> The SAMA5D3-EDS board is an Ethernet Development Platform allowing for >> evaluating many Microchip ethernet switch and PHY products. Various >> daughter cards can connect up via an RGMII connector or an RMII connector. >> > >Use subject prefixes matching the subsystem (git log --oneline -- ...). > >> The EDS board is not intended for stand-alone use and has no ethernet >> capabilities when no daughter board is connected. As such, this >> device tree is intended to be used with a DT overlay defining the add-on board. >> To better ensure consistency, some items are defined here as a form of >> documentation so that all add-on overlays will use the same terms. >> >> Google search keywords: "Microchip SAMA5D3-EDS" >> >> Signed-off-by: Jerry Ray <jerry.ray@microchip.com> >> --- >> v4->v5: >> - patch now applies to v6.0-rc2 > >If this is rebased, why you did not CC me? > Apologies. Didn't update the mailing list from previous attempts. >> v3->v4: >> - Fixed regulators as necessary to get the board to boot from SD Card. >> v2->v3: >> - Alphabetized pinctrl entries. >> - cleaned up a warning in the regulators section. >> - License tweaked to 'OR MIT' >> - Included Makefile change >> v1->v2: >> - Modified the compatible field in the device tree to reflect Microchip >> Ethernet Development System Board. >> --- >> arch/arm/boot/dts/Makefile | 1 + >> arch/arm/boot/dts/at91-sama5d3_eds.dts | 309 >> +++++++++++++++++++++++++ >> 2 files changed, 310 insertions(+) >> create mode 100644 arch/arm/boot/dts/at91-sama5d3_eds.dts >> >> diff --git a/arch/arm/boot/dts/Makefile b/arch/arm/boot/dts/Makefile >> index 05d8aef6e5d2..e92e639a2dc3 100644 >> --- a/arch/arm/boot/dts/Makefile >> +++ b/arch/arm/boot/dts/Makefile >> @@ -61,6 +61,7 @@ dtb-$(CONFIG_SOC_SAM_V7) += \ >> at91-sama5d2_icp.dtb \ >> at91-sama5d2_ptc_ek.dtb \ >> at91-sama5d2_xplained.dtb \ >> + at91-sama5d3_eds.dtb \ >> at91-sama5d3_ksz9477_evb.dtb \ >> at91-sama5d3_xplained.dtb \ >> at91-dvk_som60.dtb \ >> diff --git a/arch/arm/boot/dts/at91-sama5d3_eds.dts >> b/arch/arm/boot/dts/at91-sama5d3_eds.dts >> new file mode 100644 >> index 000000000000..2e6d94b30916 >> --- /dev/null >> +++ b/arch/arm/boot/dts/at91-sama5d3_eds.dts >> @@ -0,0 +1,309 @@ >> +// SPDX-License-Identifier: GPL-2.0+ OR MIT >> +/* >> + * at91-sama5d3_eds.dts - Device Tree file for the SAMA5D3 Ethernet >> + * Development System board. >> + * >> + * Copyright (C) 2022 Microchip Technology Inc. and its subsidiaries >> + * 2022 Jerry Ray <jerry.ray@microchip.com> >> + */ >> +/dts-v1/; >> +#include "sama5d36.dtsi" >> + >> +/ { >> + model = "SAMA5D3 Ethernet Development System"; >> + compatible = "microchip,sama5d3-eds", "atmel,sama5d3", >> + "atmel,sama5"; > >This does not match your bindings. > >> + >> + chosen { >> + stdout-path = "serial0:115200n8"; >> + }; >> + >> + clocks { >> + slow_xtal { > >No underscores in node names. Generic node names, so at least add some generic prefix or suffix, e.g.: "slow-xtal-clock" > I'm not at liberty to change these names. Pre-existing drivers are counting on them. The hardware leverages the SAMA5D3-xplained board. I'm leveraging the at91-sama5d3_xplained.dts. The board will not boot up if I modify the names. >> + clock-frequency = <32768>; >> + }; >> + >> + main_xtal { > >Ditto, e.g. main-xtal-clock > >> + clock-frequency = <12000000>; >> + }; >> + }; >> + >> + gpio_keys { > >No underscores... > >> + compatible = "gpio-keys"; >> + >> + pinctrl-names = "default"; >> + pinctrl-0 = <&pinctrl_key_gpio>; >> + >> + button-3 { >> + label = "PB_USER"; >> + gpios = <&pioE 29 GPIO_ACTIVE_LOW>; >> + linux,code = <0x104>; >> + wakeup-source; >> + }; >> + }; >> + >> + memory@20000000 { >> + reg = <0x20000000 0x10000000>; >> + }; >> + >> + vcc_3v3_reg: BUCK_REG1 { > >No, this coding style is very poor. No capital letters, no underscores. >Use generic node names, e.g. "regulator-0". > > I'll conform where I can with regards to style. >> + compatible = "regulator-fixed"; >> + regulator-name = "VCC_3V3"; >> + regulator-min-microvolt = <3300000>; >> + regulator-max-microvolt = <3300000>; >> + regulator-always-on; >> + }; >> + >> + vcc_2v5_reg: LDO_REG2 { >> + compatible = "regulator-fixed"; >> + regulator-name = "VCC_2V5"; >> + regulator-min-microvolt = <2500000>; >> + regulator-max-microvolt = <2500000>; >> + regulator-always-on; >> + vin-supply = <&vcc_3v3_reg>; >> + }; >> + >> + vcc_1v8_reg: LDO_REG3 { >> + compatible = "regulator-fixed"; >> + regulator-name = "VCC_1V8"; >> + regulator-min-microvolt = <1800000>; >> + regulator-max-microvolt = <1800000>; >> + regulator-always-on; >> + vin-supply = <&vcc_3v3_reg>; >> + }; >> + >> + vcc_1v2_reg: BUCK_REG4 { >> + compatible = "regulator-fixed"; >> + regulator-name = "VCC_1V2"; >> + regulator-min-microvolt = <1200000>; >> + regulator-max-microvolt = <1200000>; >> + regulator-always-on; >> + }; >> + >> + vcc_mmc0_reg: fixedregulator_mmc0 { > >Another different pattern of naming.. > >> + compatible = "regulator-fixed"; >> + regulator-name = "mmc0-card-supply"; >> + regulator-min-microvolt = <3300000>; >> + regulator-max-microvolt = <3300000>; >> + regulator-always-on; >> + pinctrl-names = "default"; >> + pinctrl-0 = <&pinctrl_vcc_mmc0_reg_gpio>; >> + gpio = <&pioE 2 GPIO_ACTIVE_LOW>; >> + }; >> +}; >> + >> +&can0 { >> + status = "okay"; >> +}; >> + >> +&dbgu { >> + status = "okay"; >> +}; >> + >> +&ebi { >> + pinctrl-0 = <&pinctrl_ebi_nand_addr>; >> + pinctrl-names = "default"; >> + status = "okay"; >> + >> + nand_controller: nand-controller { >> + status = "okay"; >> +> + nand@3 { >> + reg = <0x3 0x0 0x2>; >> + atmel,rb = <0>; >> + nand-bus-width = <8>; >> + nand-ecc-mode = "hw"; >> + nand-ecc-strength = <4>; >> + nand-ecc-step-size = <512>; >> + nand-on-flash-bbt; >> + label = "atmel_nand"; >> + >> + partitions { >> + compatible = "fixed-partitions"; >> + #address-cells = <1>; >> + #size-cells = <1>; >> + >> + at91bootstrap@0 { >> + label = "at91bootstrap"; >> + reg = <0x0 0x40000>; >> + }; >> + >> + bootloader@40000 { >> + label = "bootloader"; >> + reg = <0x40000 0xc0000>; >> + }; >> + >> + bootloaderenvred@100000 { >> + label = "bootloader env redundant"; >> + reg = <0x100000 0x40000>; >> + }; >> + >> + bootloaderenv@140000 { >> + label = "bootloader env"; >> + reg = <0x140000 0x40000>; >> + }; >> + >> + dtb@180000 { >> + label = "device tree"; >> + reg = <0x180000 0x80000>; >> + }; >> + >> + kernel@200000 { >> + label = "kernel"; >> + reg = <0x200000 0x600000>; >> + }; >> + >> + rootfs@800000 { >> + label = "rootfs"; >> + reg = <0x800000 0x0f800000>; >> + }; >> + }; >> + }; >> + }; >> +}; >> + >> +&i2c0 { >> + pinctrl-0 = <&pinctrl_i2c0_pu>; >> + status = "okay"; >> +}; >> + >> +&i2c1 { >> + status = "okay"; >> +}; >> + >> +&i2c2 { >> + dmas = <0>, <0>; /* Do not use DMA for i2c2 */ > >Instead you need to remove the property. > >> + pinctrl-0 = <&pinctrl_i2c2_pu>; >> + status = "okay"; >> +}; >> + >> +&mmc0 { >> + pinctrl-0 = <&pinctrl_mmc0_clk_cmd_dat0 &pinctrl_mmc0_dat1_3 >> + &pinctrl_mmc0_dat4_7 &pinctrl_mmc0_cd>; >> + vmmc-supply = <&vcc_mmc0_reg>; >> + vqmmc-supply = <&vcc_3v3_reg>; >> + status = "okay"; >> + slot@0 { >> + reg = <0>; >> + bus-width = <8>; >> + cd-gpios = <&pioE 0 GPIO_ACTIVE_LOW>; >> + }; >> +}; >> + >> +&pinctrl { >> + board { >> + pinctrl_i2c0_pu: i2c0_pu { > >No underscores in node names. > >> + atmel,pins = >> + <AT91_PIOA 30 AT91_PERIPH_A AT91_PINCTRL_PULL_UP>, >> + <AT91_PIOA 31 AT91_PERIPH_A AT91_PINCTRL_PULL_UP>; >> + }; >> + >> + pinctrl_i2c2_pu: i2c2_pu { >> + atmel,pins = >> + <AT91_PIOA 18 AT91_PERIPH_B AT91_PINCTRL_PULL_UP>, >> + <AT91_PIOA 19 AT91_PERIPH_B AT91_PINCTRL_PULL_UP>; >> + }; >> + >> + pinctrl_key_gpio: key_gpio_0 { >> + atmel,pins = >> + <AT91_PIOE 29 AT91_PERIPH_GPIO AT91_PINCTRL_PULL_UP_DEGLITCH>; >> + }; >> + >> + pinctrl_mmc0_cd: mmc0_cd { >> + atmel,pins = >> + <AT91_PIOE 0 AT91_PERIPH_GPIO AT91_PINCTRL_PULL_UP_DEGLITCH>; >> + }; >> + >> + /* Reserved for reset signal to the RGMII connector. */ >> + pinctrl_rgmii_rstn: rgmii_rstn { >> + atmel,pins = >> + <AT91_PIOD 18 AT91_PERIPH_GPIO AT91_PINCTRL_PULL_UP_DEGLITCH>; >> + }; >> + >> + /* Reserved for an interrupt line from the RMII and RGMII connectors. */ >> + pinctrl_spi_irqn: spi_irqn { >> + atmel,pins = >> + <AT91_PIOB 28 AT91_PERIPH_GPIO AT91_PINCTRL_DEGLITCH>; >> + }; >> + >> + pinctrl_spi0_cs: spi0_cs_default { >> + atmel,pins = >> + <AT91_PIOD 13 AT91_PERIPH_GPIO AT91_PINCTRL_NONE >> + AT91_PIOD 16 AT91_PERIPH_GPIO AT91_PINCTRL_NONE>; >> + }; >> + >> + pinctrl_spi1_cs: spi1_cs_default { >> + atmel,pins = <AT91_PIOC 25 AT91_PERIPH_GPIO AT91_PINCTRL_NONE >> + AT91_PIOC 28 AT91_PERIPH_GPIO AT91_PINCTRL_NONE>; >> + }; >> + >> + pinctrl_usba_vbus: usba_vbus { >> + atmel,pins = >> + <AT91_PIOE 9 AT91_PERIPH_GPIO AT91_PINCTRL_DEGLITCH>; >> + }; >> + >> + pinctrl_usb_default: usb_default { >> + atmel,pins = >> + <AT91_PIOE 3 AT91_PERIPH_GPIO AT91_PINCTRL_NONE >> + AT91_PIOE 4 AT91_PERIPH_GPIO AT91_PINCTRL_NONE>; >> + }; >> + >> + /* Reserved for VBUS fault interrupt. */ >> + pinctrl_vbusfault_irqn: vbusfault_irqn { >> + atmel,pins = >> + <AT91_PIOE 5 AT91_PERIPH_GPIO AT91_PINCTRL_DEGLITCH>; >> + }; >> + >> + pinctrl_vcc_mmc0_reg_gpio: vcc_mmc0_reg_gpio_default { >> + atmel,pins = <AT91_PIOE 2 AT91_PERIPH_GPIO AT91_PINCTRL_PULL_UP>; >> + }; >> + }; >> +}; >> + >> +&spi0 { >> + pinctrl-names = "default", "cs"; >> + pinctrl-1 = <&pinctrl_spi0_cs>; >> + cs-gpios = <&pioD 13 0>, <0>, <0>, <&pioD 16 0>; >> + status = "okay"; >> +}; >> + >> +&spi1 { >> + pinctrl-names = "default", "cs"; >> + pinctrl-1 = <&pinctrl_spi1_cs>; >> + cs-gpios = <&pioC 25 0>, <0>, <0>, <&pioC 28 0>; > >Use proper flags. What is <0>??? > > >> + status = "okay"; >> +}; >> + >> +&tcb0 { >> + timer0: timer@0 { >> + compatible = "atmel,tcb-timer"; >> + reg = <0>; >> + }; >> + >> + timer1: timer@1 { >> + compatible = "atmel,tcb-timer"; >> + reg = <1>; >> + }; >> +}; >> + >> +&usb0 { >> + atmel,vbus-gpio = <&pioE 9 GPIO_ACTIVE_HIGH>; >> + pinctrl-names = "default"; >> + pinctrl-0 = <&pinctrl_usba_vbus>; >> + status = "okay"; >> +}; >> + >> +&usb1 { >> + atmel,vbus-gpio = <0 > >What is this 0? > >> + &pioE 3 GPIO_ACTIVE_HIGH >> + &pioE 4 GPIO_ACTIVE_HIGH > >Why two GPIOs? > >> + >; >> + pinctrl-names = "default"; >> + pinctrl-0 = <&pinctrl_usb_default>; >> + num-ports = <3>; >> + status = "okay"; >> +}; >> + >> +&usb2 { >> + status = "okay"; >> +}; > > >Best regards, >Krzysztof > Regards, Jerry. ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH v5 2/2] dts: arm: at91: Add SAMA5D3-EDS board 2022-08-30 20:16 ` Jerry.Ray @ 2022-08-31 6:06 ` Krzysztof Kozlowski 0 siblings, 0 replies; 6+ messages in thread From: Krzysztof Kozlowski @ 2022-08-31 6:06 UTC (permalink / raw) To: Jerry.Ray, robh+dt, Nicolas.Ferre, alexandre.belloni, Ludovic.Desroches, devicetree, linux-arm-kernel, linux-kernel On 30/08/2022 23:16, Jerry.Ray@microchip.com wrote: >> >>> + >>> + chosen { >>> + stdout-path = "serial0:115200n8"; >>> + }; >>> + >>> + clocks { >>> + slow_xtal { >> >> No underscores in node names. Generic node names, so at least add some generic prefix or suffix, e.g.: "slow-xtal-clock" >> > > I'm not at liberty to change these names. Pre-existing drivers are counting on them. > The hardware leverages the SAMA5D3-xplained board. > I'm leveraging the at91-sama5d3_xplained.dts. > The board will not boot up if I modify the names. For custom names you have clock-output-names... But anyway it seems you override existing nodes, so this should be override by label, not by entire path. Best regards, Krzysztof ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH v5 1/2] dts: arm: Adding documentation for SAMA5D3-EDS board 2022-08-30 15:24 [PATCH v5 1/2] dts: arm: Adding documentation for SAMA5D3-EDS board Jerry Ray 2022-08-30 15:24 ` [PATCH v5 2/2] dts: arm: at91: Add " Jerry Ray @ 2022-08-30 16:57 ` Krzysztof Kozlowski 1 sibling, 0 replies; 6+ messages in thread From: Krzysztof Kozlowski @ 2022-08-30 16:57 UTC (permalink / raw) To: Jerry Ray, Rob Herring, Nicolas Ferre, Alexandre Belloni, Ludovic Desroches, devicetree, linux-arm-kernel, linux-kernel On 30/08/2022 18:24, Jerry Ray wrote: > Adding the SAMA5D3-EDS board from Microchip into the atmel AT91 board > description yaml file. > > Signed-off-by: Jerry Ray <jerry.ray@microchip.com> > Acked-by: Rob Herring <robh@kernel.org> > --- Use subject prefixes matching the subsystem (git log --oneline -- ...). > v4->v5: > - No change > v3->v4: > - No change > v2->v3: > - No change > v1->v2: > - Added Device Tree documentation for Microchip SAMA5D3-EDS board > --- > Documentation/devicetree/bindings/arm/atmel-at91.yaml | 7 +++++++ > 1 file changed, 7 insertions(+) > > diff --git a/Documentation/devicetree/bindings/arm/atmel-at91.yaml b/Documentation/devicetree/bindings/arm/atmel-at91.yaml > index 08efb259a947..635491aaeb0c 100644 > --- a/Documentation/devicetree/bindings/arm/atmel-at91.yaml > +++ b/Documentation/devicetree/bindings/arm/atmel-at91.yaml > @@ -138,6 +138,13 @@ properties: > - const: atmel,at91sam9g20 > - const: atmel,at91sam9 > > + - description: Microchip SAMA5D3 Ethernet Development System Board > + items: > + - const: microchip,sama5d3-eds > + - const: atmel,sama5d36 This does not match your DTS. Test your bindings... Please drop Rob's ack as this is not correct. Best regards, Krzysztof ^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2022-08-31 6:06 UTC | newest] Thread overview: 6+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2022-08-30 15:24 [PATCH v5 1/2] dts: arm: Adding documentation for SAMA5D3-EDS board Jerry Ray 2022-08-30 15:24 ` [PATCH v5 2/2] dts: arm: at91: Add " Jerry Ray 2022-08-30 17:02 ` Krzysztof Kozlowski 2022-08-30 20:16 ` Jerry.Ray 2022-08-31 6:06 ` Krzysztof Kozlowski 2022-08-30 16:57 ` [PATCH v5 1/2] dts: arm: Adding documentation for " Krzysztof Kozlowski
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).