From: Horatiu Vultur <horatiu.vultur@microchip.com>
To: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Cc: <devicetree@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
<srinivas.kandagatla@linaro.org>, <robh+dt@kernel.org>,
<krzysztof.kozlowski+dt@linaro.org>,
<UNGLinuxDriver@microchip.com>
Subject: Re: [PATCH v3 2/2] nvmem: lan9662-otp: add support.
Date: Wed, 31 Aug 2022 12:52:37 +0200 [thread overview]
Message-ID: <20220831105237.ot5aaawnrwjqmjgj@soft-dev3-1.localhost> (raw)
In-Reply-To: <1ddf261e-55fb-e30c-93b0-efb9bc0987b3@linaro.org>
The 08/31/2022 10:29, Krzysztof Kozlowski wrote:
Hi Krzysztof,
>
> On 31/08/2022 09:42, Horatiu Vultur wrote:
>
> > +static const struct of_device_id lan9662_otp_match[] = {
> > + { .compatible = "microchip,lan9662-otp", },
> > + { .compatible = "microchip,lan9668-otp", },
>
> This is still wrong, does not match your bindings at all and still
> duplicates entries without driver data. One entry - 9662.
I have look at some other drivers, where I can see they don't have any
driver data. For example [1] and the bindings are here [2].
[1] https://elixir.bootlin.com/linux/latest/source/drivers/net/ethernet/ti/cpsw_new.c#L1832
[2] https://elixir.bootlin.com/linux/latest/source/Documentation/devicetree/bindings/net/ti,cpsw-switch.yaml#L23
Is this also wrong, or I still can't understand how the bindings are
working?
If I put only one entry:
---
static const struct of_device_id lan9662_otp_match[] = {
{ .compatible = "microchip,lan9662-otp", },
---
Wouldn't be a problem that the binding mentions also lan9668?
>
> Best regards,
> Krzysztof
--
/Horatiu
next prev parent reply other threads:[~2022-08-31 10:48 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-31 6:42 [PATCH v3 0/2] nvmem: lan9662-otpc: add support Horatiu Vultur
2022-08-31 6:42 ` [PATCH v3 1/2] dt-bindings: lan9662-otpc: document Lan9662 OTPC Horatiu Vultur
2022-08-31 7:28 ` Krzysztof Kozlowski
2022-08-31 10:44 ` Horatiu Vultur
2022-08-31 12:45 ` Krzysztof Kozlowski
2022-08-31 6:42 ` [PATCH v3 2/2] nvmem: lan9662-otp: add support Horatiu Vultur
2022-08-31 7:29 ` Krzysztof Kozlowski
2022-08-31 10:52 ` Horatiu Vultur [this message]
2022-08-31 12:52 ` Krzysztof Kozlowski
2022-08-31 14:52 ` Horatiu Vultur
2022-08-31 15:17 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220831105237.ot5aaawnrwjqmjgj@soft-dev3-1.localhost \
--to=horatiu.vultur@microchip.com \
--cc=UNGLinuxDriver@microchip.com \
--cc=devicetree@vger.kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=krzysztof.kozlowski@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=srinivas.kandagatla@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).