From: Stephan Gerhold <stephan.gerhold@kernkonzept.com>
To: Bjorn Andersson <andersson@kernel.org>
Cc: Andy Gross <agross@kernel.org>,
Konrad Dybcio <konrad.dybcio@somainline.org>,
Mathieu Poirier <mathieu.poirier@linaro.org>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Sireesh Kodali <sireeshkodali1@gmail.com>,
Luca Weiss <luca@z3ntu.xyz>,
Stephan Gerhold <stephan@gerhold.net>,
linux-arm-msm@vger.kernel.org, linux-remoteproc@vger.kernel.org,
devicetree@vger.kernel.org,
Stephan Gerhold <stephan.gerhold@kernkonzept.com>
Subject: [PATCH v3 3/7] dt-bindings: remoteproc: qcom,msm8916-mss-pil: Add MSM8974
Date: Wed, 31 Aug 2022 15:46:22 +0200 [thread overview]
Message-ID: <20220831134626.2803117-4-stephan.gerhold@kernkonzept.com> (raw)
In-Reply-To: <20220831134626.2803117-1-stephan.gerhold@kernkonzept.com>
The "qcom,msm8974-mss-pil" binding is still similar enough to MSM8916
to be covered by the same DT schema. The only difference is the
additional "mss-supply", which can be easily handled using a single
if statement.
Signed-off-by: Stephan Gerhold <stephan.gerhold@kernkonzept.com>
---
Changes in v3: None
Changes in v2:
- Add if to the "allOf" list (suggested by Krzysztof)
---
.../remoteproc/qcom,msm8916-mss-pil.yaml | 16 ++++++++++++++++
.../devicetree/bindings/remoteproc/qcom,q6v5.txt | 16 ----------------
2 files changed, 16 insertions(+), 16 deletions(-)
diff --git a/Documentation/devicetree/bindings/remoteproc/qcom,msm8916-mss-pil.yaml b/Documentation/devicetree/bindings/remoteproc/qcom,msm8916-mss-pil.yaml
index e4ac4889fc92..c7e594873648 100644
--- a/Documentation/devicetree/bindings/remoteproc/qcom,msm8916-mss-pil.yaml
+++ b/Documentation/devicetree/bindings/remoteproc/qcom,msm8916-mss-pil.yaml
@@ -18,6 +18,7 @@ properties:
oneOf:
- enum:
- qcom,msm8916-mss-pil
+ - qcom,msm8974-mss-pil
- const: qcom,q6v5-pil
description: Deprecated, prefer using qcom,msm8916-mss-pil
@@ -76,6 +77,9 @@ properties:
pll-supply:
description: PLL proxy supply (control handed over after startup)
+ mss-supply:
+ description: MSS power domain supply (only valid for qcom,msm8974-mss-pil)
+
resets:
items:
- description: MSS restart control
@@ -181,6 +185,18 @@ required:
- smd-edge
allOf:
+ # mss-supply is only valid (and required) for MSM8974
+ - if:
+ properties:
+ compatible:
+ const: qcom,msm8974-mss-pil
+ then:
+ required:
+ - mss-supply
+ else:
+ properties:
+ mss-supply: false
+
# Fallbacks for deprecated properties
- oneOf:
- required:
diff --git a/Documentation/devicetree/bindings/remoteproc/qcom,q6v5.txt b/Documentation/devicetree/bindings/remoteproc/qcom,q6v5.txt
index 11862b6c2339..5923c0447e2d 100644
--- a/Documentation/devicetree/bindings/remoteproc/qcom,q6v5.txt
+++ b/Documentation/devicetree/bindings/remoteproc/qcom,q6v5.txt
@@ -9,7 +9,6 @@ on the Qualcomm Hexagon core.
Definition: must be one of:
"qcom,ipq8074-wcss-pil"
"qcom,qcs404-wcss-pil"
- "qcom,msm8974-mss-pil"
"qcom,msm8996-mss-pil"
"qcom,msm8998-mss-pil"
"qcom,sdm845-mss-pil"
@@ -37,7 +36,6 @@ on the Qualcomm Hexagon core.
string:
qcom,ipq8074-wcss-pil:
qcom,qcs404-wcss-pil:
- qcom,msm8974-mss-pil:
must be "wdog", "fatal", "ready", "handover", "stop-ack"
qcom,msm8996-mss-pil:
qcom,msm8998-mss-pil:
@@ -68,8 +66,6 @@ on the Qualcomm Hexagon core.
"gcc_axim_cbcr", "lcc_ahbfabric_cbc", "tcsr_lcc_cbc",
"lcc_abhs_cbc", "lcc_tcm_slave_cbc", "lcc_abhm_cbc",
"lcc_axim_cbc", "lcc_bcr_sleep"
- qcom,msm8974-mss-pil:
- must be "iface", "bus", "mem", "xo"
qcom,msm8996-mss-pil:
must be "iface", "bus", "mem", "xo", "gpll0_mss",
"snoc_axi", "mnoc_axi", "pnoc", "qdss"
@@ -106,17 +102,6 @@ should be referenced as follows:
Definition: reference to the reserved-memory for the mba region followed
by the mpss region
-For the compatible string below the following supplies are required:
- "qcom,msm8974-mss-pil"
-- cx-supply: (deprecated, use power domain instead)
-- mss-supply:
-- mx-supply: (deprecated, use power domain instead)
-- pll-supply:
- Usage: required
- Value type: <phandle>
- Definition: reference to the regulators to be held on behalf of the
- booting of the Hexagon core
-
For the compatible string below the following supplies are required:
"qcom,qcs404-wcss-pil"
- cx-supply:
@@ -144,7 +129,6 @@ For the compatible string below the following supplies are required:
Definition: The power-domains needed depend on the compatible string:
qcom,ipq8074-wcss-pil:
no power-domain names required
- qcom,msm8974-mss-pil:
qcom,msm8996-mss-pil:
qcom,msm8998-mss-pil:
must be "cx", "mx"
--
2.30.2
next prev parent reply other threads:[~2022-08-31 15:06 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-31 13:46 [PATCH v3 0/7] remoteproc: qcom_q6v5_mss: Add MSM8909 and MSM8953 Stephan Gerhold
2022-08-31 13:46 ` [PATCH v3 1/7] arm64: dts: qcom: msm8916: Drop MSS fallback compatible Stephan Gerhold
2022-08-31 13:46 ` [PATCH v3 2/7] dt-bindings: remoteproc: qcom,q6v5: Move MSM8916 to schema Stephan Gerhold
2022-09-06 9:03 ` Krzysztof Kozlowski
2022-09-06 9:48 ` Krzysztof Kozlowski
2022-08-31 13:46 ` Stephan Gerhold [this message]
2022-09-08 9:48 ` [PATCH v3 3/7] dt-bindings: remoteproc: qcom,msm8916-mss-pil: Add MSM8974 Krzysztof Kozlowski
2022-08-31 13:46 ` [PATCH v3 4/7] dt-bindings: remoteproc: qcom,msm8916-mss-pil: Add MSM8909 Stephan Gerhold
2022-08-31 13:46 ` [PATCH v3 5/7] remoteproc: qcom_q6v5_mss: Add support for MSM8909 Stephan Gerhold
2022-08-31 13:46 ` [PATCH v3 6/7] dt-bindings: remoteproc: qcom,msm8916-mss-pil: Add MSM8953 Stephan Gerhold
2022-09-08 9:50 ` Krzysztof Kozlowski
2022-08-31 13:46 ` [PATCH v3 7/7] remoteproc: qcom: q6v5-mss: Add modem support on MSM8953 Stephan Gerhold
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220831134626.2803117-4-stephan.gerhold@kernkonzept.com \
--to=stephan.gerhold@kernkonzept.com \
--cc=agross@kernel.org \
--cc=andersson@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=konrad.dybcio@somainline.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-remoteproc@vger.kernel.org \
--cc=luca@z3ntu.xyz \
--cc=mathieu.poirier@linaro.org \
--cc=robh+dt@kernel.org \
--cc=sireeshkodali1@gmail.com \
--cc=stephan@gerhold.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).