From: Andrew Halaney <ahalaney@redhat.com>
To: agross@kernel.org, andersson@kernel.org,
konrad.dybcio@somainline.org, lgirdwood@gmail.com,
broonie@kernel.org, robh+dt@kernel.org,
krzysztof.kozlowski+dt@linaro.org
Cc: linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org,
devicetree@vger.kernel.org, dianders@chromium.org,
johan@kernel.org, Andrew Halaney <ahalaney@redhat.com>
Subject: [PATCH 2/3] regulator: dt-bindings: qcom,rpmh: Specify supply property
Date: Fri, 2 Sep 2022 13:51:47 -0500 [thread overview]
Message-ID: <20220902185148.635292-3-ahalaney@redhat.com> (raw)
In-Reply-To: <20220902185148.635292-1-ahalaney@redhat.com>
The top level RPMh nodes have a supply property, make sure to specify it
so the patternProperties later that are keyed off of the PMIC version
are properly honored. Without this, and the dt-binding containing
additionalProperties: false, you will see the following when running
make dt_binding_check:
DTEX Documentation/devicetree/bindings/regulator/qcom,rpmh-regulator.example.dts
DTC Documentation/devicetree/bindings/regulator/qcom,rpmh-regulator.example.dtb
CHECK Documentation/devicetree/bindings/regulator/qcom,rpmh-regulator.example.dtb
/mnt/extrassd/git/linux-next/Documentation/devicetree/bindings/regulator/qcom,rpmh-regulator.example.dtb: pm8998-rpmh-regulators: 'vdd-l7-l12-l14-l15-supply' does not match any of the regexes: '^(smps|ldo|lvs)[0-9]+$', 'pinctrl-[0-9]+'
From schema: /mnt/extrassd/git/linux-next/Documentation/devicetree/bindings/regulator/qcom,rpmh-regulator.yaml
That supply pattern is intended to be considered correct for the
qcom,pm8998-rpmh-regulators compatible, and is no longer complained
about with the supply property described.
Unfortunately this pattern is wide enough that it no longer complains
when you bork the expected supply for a compatible. I.e. for
qcom,pm8998-rpmh-regulators, if I change the example usage in the
binding to:
vdd-l0-l12-l14-l15-supply = <&pm8998_s5>;
I get no warning, when really it should be of the pattern:
vdd-l7-l12-l14-l15-supply = <&pm8998_s5>;
Signed-off-by: Andrew Halaney <ahalaney@redhat.com>
---
.../devicetree/bindings/regulator/qcom,rpmh-regulator.yaml | 3 +++
1 file changed, 3 insertions(+)
diff --git a/Documentation/devicetree/bindings/regulator/qcom,rpmh-regulator.yaml b/Documentation/devicetree/bindings/regulator/qcom,rpmh-regulator.yaml
index b3fd60b21610..86265b513de3 100644
--- a/Documentation/devicetree/bindings/regulator/qcom,rpmh-regulator.yaml
+++ b/Documentation/devicetree/bindings/regulator/qcom,rpmh-regulator.yaml
@@ -106,6 +106,9 @@ patternProperties:
$ref: "regulator.yaml#"
description: smps/ldo regulator nodes(s).
+ ".*-supply$":
+ description: Input supply phandle(s) for this node
+
additionalProperties: false
required:
--
2.37.2
next prev parent reply other threads:[~2022-09-02 18:52 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-02 18:51 [PATCH 0/3] regulator: dt-bindings: qcom,rpmh: dt-binding fixups Andrew Halaney
2022-09-02 18:51 ` [PATCH 1/3] regulator: dt-bindings: qcom,rpmh: Use additionalProperties Andrew Halaney
2022-09-02 21:34 ` Rob Herring
2022-09-05 16:45 ` Krzysztof Kozlowski
2022-09-05 16:53 ` Krzysztof Kozlowski
2022-09-06 14:32 ` Andrew Halaney
2022-09-02 18:51 ` Andrew Halaney [this message]
2022-09-05 16:47 ` [PATCH 2/3] regulator: dt-bindings: qcom,rpmh: Specify supply property Krzysztof Kozlowski
2022-09-02 18:51 ` [PATCH 3/3] regulator: dt-bindings: qcom,rpmh: Indicate regulator-allow-set-load dependencies Andrew Halaney
2022-09-05 16:50 ` Krzysztof Kozlowski
2022-09-06 14:41 ` Andrew Halaney
2022-09-08 10:23 ` Krzysztof Kozlowski
2022-09-06 20:25 ` [PATCH 0/3] regulator: dt-bindings: qcom,rpmh: dt-binding fixups Andrew Halaney
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220902185148.635292-3-ahalaney@redhat.com \
--to=ahalaney@redhat.com \
--cc=agross@kernel.org \
--cc=andersson@kernel.org \
--cc=broonie@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dianders@chromium.org \
--cc=johan@kernel.org \
--cc=konrad.dybcio@somainline.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=lgirdwood@gmail.com \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).