* [PATCH v2] media: dt-bindings: dongwoon,dw9714: convert to dtschema
@ 2022-09-01 7:14 Krzysztof Kozlowski
2022-09-02 21:26 ` Rob Herring
0 siblings, 1 reply; 2+ messages in thread
From: Krzysztof Kozlowski @ 2022-09-01 7:14 UTC (permalink / raw)
To: Mauro Carvalho Chehab, Rob Herring, Krzysztof Kozlowski,
Sakari Ailus, linux-media, devicetree, linux-kernel
Cc: Krzysztof Kozlowski
Convert Dongwoon Anatech DW9714 camera voice coil lens driver to DT
schema and extend the bindings with vcc-supply (already used by driver)
and powerdown-gpios (based on datasheet, not used by the driver).
Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
---
Changes since v1:
1. Update path in Maintainers
---
.../bindings/media/i2c/dongwoon,dw9714.txt | 9 ----
.../bindings/media/i2c/dongwoon,dw9714.yaml | 47 +++++++++++++++++++
MAINTAINERS | 2 +-
3 files changed, 48 insertions(+), 10 deletions(-)
delete mode 100644 Documentation/devicetree/bindings/media/i2c/dongwoon,dw9714.txt
create mode 100644 Documentation/devicetree/bindings/media/i2c/dongwoon,dw9714.yaml
diff --git a/Documentation/devicetree/bindings/media/i2c/dongwoon,dw9714.txt b/Documentation/devicetree/bindings/media/i2c/dongwoon,dw9714.txt
deleted file mode 100644
index b88dcdd41def..000000000000
--- a/Documentation/devicetree/bindings/media/i2c/dongwoon,dw9714.txt
+++ /dev/null
@@ -1,9 +0,0 @@
-Dongwoon Anatech DW9714 camera voice coil lens driver
-
-DW9174 is a 10-bit DAC with current sink capability. It is intended
-for driving voice coil lenses in camera modules.
-
-Mandatory properties:
-
-- compatible: "dongwoon,dw9714"
-- reg: I²C slave address
diff --git a/Documentation/devicetree/bindings/media/i2c/dongwoon,dw9714.yaml b/Documentation/devicetree/bindings/media/i2c/dongwoon,dw9714.yaml
new file mode 100644
index 000000000000..66229a3dc05d
--- /dev/null
+++ b/Documentation/devicetree/bindings/media/i2c/dongwoon,dw9714.yaml
@@ -0,0 +1,47 @@
+# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/media/i2c/dongwoon,dw9714.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: Dongwoon Anatech DW9714 camera voice coil lens driver
+
+maintainers:
+ - Krzysztof Kozlowski <krzk@kernel.org>
+
+description:
+ DW9174 is a 10-bit DAC with current sink capability. It is intended for
+ driving voice coil lenses in camera modules.
+
+properties:
+ compatible:
+ const: dongwoon,dw9714
+
+ reg:
+ maxItems: 1
+
+ powerdown-gpios:
+ description:
+ XSD pin for shutdown (active low)
+
+ vcc-supply:
+ description: VDD power supply
+
+required:
+ - compatible
+ - reg
+
+additionalProperties: false
+
+examples:
+ - |
+ i2c {
+ #address-cells = <1>;
+ #size-cells = <0>;
+
+ camera-lens@c {
+ compatible = "dongwoon,dw9714";
+ reg = <0x0c>;
+ vcc-supply = <®_csi_1v8>;
+ };
+ };
diff --git a/MAINTAINERS b/MAINTAINERS
index ebc140e71b49..8573e3810688 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -6233,7 +6233,7 @@ M: Sakari Ailus <sakari.ailus@linux.intel.com>
L: linux-media@vger.kernel.org
S: Maintained
T: git git://linuxtv.org/media_tree.git
-F: Documentation/devicetree/bindings/media/i2c/dongwoon,dw9714.txt
+F: Documentation/devicetree/bindings/media/i2c/dongwoon,dw9714.yaml
F: drivers/media/i2c/dw9714.c
DONGWOON DW9768 LENS VOICE COIL DRIVER
--
2.34.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH v2] media: dt-bindings: dongwoon,dw9714: convert to dtschema
2022-09-01 7:14 [PATCH v2] media: dt-bindings: dongwoon,dw9714: convert to dtschema Krzysztof Kozlowski
@ 2022-09-02 21:26 ` Rob Herring
0 siblings, 0 replies; 2+ messages in thread
From: Rob Herring @ 2022-09-02 21:26 UTC (permalink / raw)
To: Krzysztof Kozlowski
Cc: Mauro Carvalho Chehab, devicetree, linux-media, Rob Herring,
Sakari Ailus, Krzysztof Kozlowski, linux-kernel
On Thu, 01 Sep 2022 10:14:37 +0300, Krzysztof Kozlowski wrote:
> Convert Dongwoon Anatech DW9714 camera voice coil lens driver to DT
> schema and extend the bindings with vcc-supply (already used by driver)
> and powerdown-gpios (based on datasheet, not used by the driver).
>
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
>
> ---
>
> Changes since v1:
> 1. Update path in Maintainers
> ---
> .../bindings/media/i2c/dongwoon,dw9714.txt | 9 ----
> .../bindings/media/i2c/dongwoon,dw9714.yaml | 47 +++++++++++++++++++
> MAINTAINERS | 2 +-
> 3 files changed, 48 insertions(+), 10 deletions(-)
> delete mode 100644 Documentation/devicetree/bindings/media/i2c/dongwoon,dw9714.txt
> create mode 100644 Documentation/devicetree/bindings/media/i2c/dongwoon,dw9714.yaml
>
Reviewed-by: Rob Herring <robh@kernel.org>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-09-02 21:26 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-09-01 7:14 [PATCH v2] media: dt-bindings: dongwoon,dw9714: convert to dtschema Krzysztof Kozlowski
2022-09-02 21:26 ` Rob Herring
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).