Re: [PATCH 1/2] arm64: dts: imx8mp-verdin: add dsi to hdmi functionality

Laurent Pinchart
2022-09-01T18:08:06Z

Hi Max,

Thank you for the patch.

On Thu, Sep 01, 2022 at 05:40:50PM +0200, Max Krummenacher wrote:
> From: Max Krummenacher <max.krummenacher@toradex.com>
>
> Add the hdmi connector present on the dsi to hdmi adapter now
> required by the upstream lontium bridge driver.
> The dsi to hdmi adapter is enabled in an device tree overlay.

Shouldn't the connector also be in the overlay ? There's certainly no
physical HDMI connector on the i.MX8MP Verdin SoM :-)

> Signed-off-by: Max Krummenacher <max.krummenacher@toradex.com>
>
> ---
>
> arch/arm64/boot/dts/freescale/imx8mp-verdin.dtsi | 8 ++++++++
> 1 file changed, 8 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/freescale/imx8mp-verdin.dtsi b/arch/arm64/boot/dts/freescale/imx8mp-verdin.dtsi
> index 76cc89296150..bd84a0d135dc 100644
> --- a/arch/arm64/boot/dts/freescale/imx8mp-verdin.dtsi
> +++ b/arch/arm64/boot/dts/freescale/imx8mp-verdin.dtsi
> @@ -59,6 +59,14 @@ button-wakeup {
> };
> };
>
> + hdmi_connector: hdmi-connector {
> + compatible = "hdmi-connector";
> + ddc-i2c-bus = <&i2c2>;
> + label = "hdmi";
> + type = "a";
> + status = "disabled";
> + };
> +
> /* Carrier Board Supplies */
> reg_1p8v: regulator-1p8v {
> compatible = "regulator-fixed";