From: Guenter Roeck <linux@roeck-us.net>
To: Eliav Farber <farbere@amazon.com>
Cc: jdelvare@suse.com, robh+dt@kernel.org, p.zabel@pengutronix.de,
rtanwar@maxlinear.com, linux-hwmon@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
hhhawa@amazon.com, jonnyc@amazon.com,
andriy.shevchenko@intel.com
Subject: Re: [PATCH v4 01/21] hwmon: (mr75203) fix coding style space errors
Date: Tue, 6 Sep 2022 09:52:29 -0700 [thread overview]
Message-ID: <20220906165229.GA594012@roeck-us.net> (raw)
In-Reply-To: <20220906083356.21067-2-farbere@amazon.com>
On Tue, Sep 06, 2022 at 08:33:36AM +0000, Eliav Farber wrote:
> Fix: "ERROR: space required before the open parenthesis '('"
>
> Fixes: 9d823351a337 ("hwmon: Add hardware monitoring driver for Moortec MR75203 PVT controller")
Coding style "fixes" do not fix the code. I consider using the Fixes: tag
for those to close to an abuse of that tag (and it would be great if that
was spelled out somewhere). As it is, I can not with good conscience apply
this patch to the mainline kernel (especially not for -rc5), meaning the
entire series will have to wait for the next release window unless there
are no conflicts.
Guenter
> Signed-off-by: Eliav Farber <farbere@amazon.com>
> ---
> drivers/hwmon/mr75203.c | 40 ++++++++++++++++++++--------------------
> 1 file changed, 20 insertions(+), 20 deletions(-)
>
> diff --git a/drivers/hwmon/mr75203.c b/drivers/hwmon/mr75203.c
> index 046523d47c29..8adfbb15453f 100644
> --- a/drivers/hwmon/mr75203.c
> +++ b/drivers/hwmon/mr75203.c
> @@ -155,7 +155,7 @@ static int pvt_read_temp(struct device *dev, u32 attr, int channel, long *val)
> return ret;
>
> ret = regmap_read(t_map, SDIF_DATA(channel), &nbs);
> - if(ret < 0)
> + if (ret < 0)
> return ret;
>
> nbs &= SAMPLE_DATA_MSK;
> @@ -197,7 +197,7 @@ static int pvt_read_in(struct device *dev, u32 attr, int channel, long *val)
> return ret;
>
> ret = regmap_read(v_map, VM_SDIF_DATA(vm_idx), &n);
> - if(ret < 0)
> + if (ret < 0)
> return ret;
>
> n &= SAMPLE_DATA_MSK;
> @@ -291,19 +291,19 @@ static int pvt_init(struct pvt_device *pvt)
>
> if (t_num) {
> ret = regmap_write(t_map, SDIF_SMPL_CTRL, 0x0);
> - if(ret < 0)
> + if (ret < 0)
> return ret;
>
> ret = regmap_write(t_map, SDIF_HALT, 0x0);
> - if(ret < 0)
> + if (ret < 0)
> return ret;
>
> ret = regmap_write(t_map, CLK_SYNTH, clk_synth);
> - if(ret < 0)
> + if (ret < 0)
> return ret;
>
> ret = regmap_write(t_map, SDIF_DISABLE, 0x0);
> - if(ret < 0)
> + if (ret < 0)
> return ret;
>
> ret = regmap_read_poll_timeout(t_map, SDIF_STAT,
> @@ -316,7 +316,7 @@ static int pvt_init(struct pvt_device *pvt)
> val = CFG0_MODE_2 | CFG0_PARALLEL_OUT | CFG0_12_BIT |
> IP_CFG << SDIF_ADDR_SFT | SDIF_WRN_W | SDIF_PROG;
> ret = regmap_write(t_map, SDIF_W, val);
> - if(ret < 0)
> + if (ret < 0)
> return ret;
>
> ret = regmap_read_poll_timeout(t_map, SDIF_STAT,
> @@ -329,7 +329,7 @@ static int pvt_init(struct pvt_device *pvt)
> val = POWER_DELAY_CYCLE_256 | IP_TMR << SDIF_ADDR_SFT |
> SDIF_WRN_W | SDIF_PROG;
> ret = regmap_write(t_map, SDIF_W, val);
> - if(ret < 0)
> + if (ret < 0)
> return ret;
>
> ret = regmap_read_poll_timeout(t_map, SDIF_STAT,
> @@ -343,39 +343,39 @@ static int pvt_init(struct pvt_device *pvt)
> IP_CTRL << SDIF_ADDR_SFT |
> SDIF_WRN_W | SDIF_PROG;
> ret = regmap_write(t_map, SDIF_W, val);
> - if(ret < 0)
> + if (ret < 0)
> return ret;
> }
>
> if (p_num) {
> ret = regmap_write(p_map, SDIF_HALT, 0x0);
> - if(ret < 0)
> + if (ret < 0)
> return ret;
>
> ret = regmap_write(p_map, SDIF_DISABLE, BIT(p_num) - 1);
> - if(ret < 0)
> + if (ret < 0)
> return ret;
>
> ret = regmap_write(p_map, CLK_SYNTH, clk_synth);
> - if(ret < 0)
> + if (ret < 0)
> return ret;
> }
>
> if (v_num) {
> ret = regmap_write(v_map, SDIF_SMPL_CTRL, 0x0);
> - if(ret < 0)
> + if (ret < 0)
> return ret;
>
> ret = regmap_write(v_map, SDIF_HALT, 0x0);
> - if(ret < 0)
> + if (ret < 0)
> return ret;
>
> ret = regmap_write(v_map, CLK_SYNTH, clk_synth);
> - if(ret < 0)
> + if (ret < 0)
> return ret;
>
> ret = regmap_write(v_map, SDIF_DISABLE, 0x0);
> - if(ret < 0)
> + if (ret < 0)
> return ret;
>
> ret = regmap_read_poll_timeout(v_map, SDIF_STAT,
> @@ -389,7 +389,7 @@ static int pvt_init(struct pvt_device *pvt)
> CFG1_14_BIT | IP_CFG << SDIF_ADDR_SFT |
> SDIF_WRN_W | SDIF_PROG;
> ret = regmap_write(v_map, SDIF_W, val);
> - if(ret < 0)
> + if (ret < 0)
> return ret;
>
> ret = regmap_read_poll_timeout(v_map, SDIF_STAT,
> @@ -402,7 +402,7 @@ static int pvt_init(struct pvt_device *pvt)
> val = POWER_DELAY_CYCLE_64 | IP_TMR << SDIF_ADDR_SFT |
> SDIF_WRN_W | SDIF_PROG;
> ret = regmap_write(v_map, SDIF_W, val);
> - if(ret < 0)
> + if (ret < 0)
> return ret;
>
> ret = regmap_read_poll_timeout(v_map, SDIF_STAT,
> @@ -416,7 +416,7 @@ static int pvt_init(struct pvt_device *pvt)
> IP_CTRL << SDIF_ADDR_SFT |
> SDIF_WRN_W | SDIF_PROG;
> ret = regmap_write(v_map, SDIF_W, val);
> - if(ret < 0)
> + if (ret < 0)
> return ret;
> }
>
> @@ -535,7 +535,7 @@ static int mr75203_probe(struct platform_device *pdev)
> return dev_err_probe(dev, ret, "cannot deassert reset control\n");
>
> ret = regmap_read(pvt->c_map, PVT_IP_CONFIG, &val);
> - if(ret < 0)
> + if (ret < 0)
> return ret;
>
> ts_num = (val & TS_NUM_MSK) >> TS_NUM_SFT;
next prev parent reply other threads:[~2022-09-06 17:05 UTC|newest]
Thread overview: 40+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-06 8:33 [PATCH v4 00/21] Variety of fixes and new features for mr75203 driver Eliav Farber
2022-09-06 8:33 ` [PATCH v4 01/21] hwmon: (mr75203) fix coding style space errors Eliav Farber
2022-09-06 16:52 ` Guenter Roeck [this message]
2022-09-07 6:50 ` Farber, Eliav
2022-09-07 14:42 ` Andy Shevchenko
2022-09-07 15:57 ` Guenter Roeck
2022-09-06 8:33 ` [PATCH v4 02/21] dt-bindings: hwmon: (mr75203) fix "intel,vm-map" property to be optional Eliav Farber
2022-09-06 16:53 ` Guenter Roeck
2022-09-07 6:28 ` [PATCH v4 02/21] dt-bindings: hwmon: (mr75203) fix "intel, vm-map" " Farber, Eliav
2022-09-07 16:00 ` Guenter Roeck
2022-09-06 8:33 ` [PATCH v4 03/21] hwmon: (mr75203) fix VM sensor allocation when "intel,vm-map" not defined Eliav Farber
2022-09-06 8:33 ` [PATCH v4 04/21] hwmon: (mr75203) update pvt->v_num and vm_num to the actual number of used sensors Eliav Farber
2022-09-06 8:33 ` [PATCH v4 05/21] hwmon: (mr75203) fix voltage equation for negative source input Eliav Farber
2022-09-06 12:03 ` Andy Shevchenko
2022-09-06 13:27 ` Farber, Eliav
2022-09-06 14:01 ` Andy Shevchenko
2022-09-06 8:33 ` [PATCH v4 06/21] hwmon: (mr75203) fix multi-channel voltage reading Eliav Farber
2022-09-06 14:10 ` Andy Shevchenko
2022-09-07 5:15 ` Farber, Eliav
2022-09-07 14:41 ` Andy Shevchenko
2022-09-06 8:33 ` [PATCH v4 07/21] hwmon: (mr75203) enable polling for all VM channels Eliav Farber
2022-09-06 8:33 ` [PATCH v4 08/21] dt-bindings: hwmon: (mr75203) add description for Moortec's PVT controller Eliav Farber
2022-09-08 22:40 ` Rob Herring
2022-09-06 8:33 ` [PATCH v4 09/21] dt-bindings: hwmon: (mr75203) change "resets" property to be optional Eliav Farber
2022-09-08 22:40 ` Rob Herring
2022-09-06 8:33 ` [PATCH v4 10/21] hwmon: (mr75203) skip reset-control deassert for SOCs that don't support it Eliav Farber
2022-09-06 8:33 ` [PATCH v4 11/21] dt-bindings: vendor-prefixes: add vendor prefix for Moortec Eliav Farber
2022-09-06 8:33 ` [PATCH v4 12/21] dt-bindings: hwmon: (mr75203) add "moortec,vm-active-channels" property Eliav Farber
2022-09-06 17:08 ` Guenter Roeck
2022-09-07 5:21 ` [PATCH v4 12/21] dt-bindings: hwmon: (mr75203) add "moortec, vm-active-channels" property Farber, Eliav
2022-09-06 8:33 ` [PATCH v4 13/21] hwmon: (mr75203) add VM active channel support Eliav Farber
2022-09-06 8:33 ` [PATCH v4 14/21] dt-bindings: hwmon: (mr75203) add "moortec,vm-pre-scaler-x2" property Eliav Farber
2022-09-06 8:33 ` [PATCH v4 15/21] hwmon: (mr75203) add VM pre-scaler x2 support Eliav Farber
2022-09-06 8:33 ` [PATCH v4 16/21] hwmon: (mr75203) modify the temperature equation according to series 5 datasheet Eliav Farber
2022-09-06 8:33 ` [PATCH v4 17/21] dt-bindings: hwmon: (mr75203) add "moortec,ts-series" property Eliav Farber
2022-09-06 8:33 ` [PATCH v4 18/21] hwmon: (mr75203) add support for series 6 temperature equation Eliav Farber
2022-09-06 8:33 ` [PATCH v4 19/21] dt-bindings: hwmon: (mr75203) add coefficient properties for the thermal equation Eliav Farber
2022-09-06 8:33 ` [PATCH v4 20/21] hwmon: (mr75203) parse temperature coefficients from device-tree Eliav Farber
2022-09-06 8:33 ` [PATCH v4 21/21] hwmon: (mr75203) add debugfs to read and write temperature coefficients Eliav Farber
2022-09-06 14:26 ` [PATCH v4 00/21] Variety of fixes and new features for mr75203 driver Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220906165229.GA594012@roeck-us.net \
--to=linux@roeck-us.net \
--cc=andriy.shevchenko@intel.com \
--cc=devicetree@vger.kernel.org \
--cc=farbere@amazon.com \
--cc=hhhawa@amazon.com \
--cc=jdelvare@suse.com \
--cc=jonnyc@amazon.com \
--cc=linux-hwmon@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=p.zabel@pengutronix.de \
--cc=robh+dt@kernel.org \
--cc=rtanwar@maxlinear.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).