From: Rob Herring <robh@kernel.org>
To: Alexander A Sverdlin <alexander.sverdlin@nokia.com>
Cc: Rob Herring <robh+dt@kernel.org>,
Frank Rowand <frowand.list@gmail.com>,
linux-kernel@vger.kernel.org, devicetree@vger.kernel.org
Subject: Re: [PATCH v2] of: irq: Report individual failures in of_irq_init()
Date: Wed, 7 Sep 2022 10:54:56 -0500 [thread overview]
Message-ID: <20220907155456.GA3526808-robh@kernel.org> (raw)
In-Reply-To: <20220907121629.54330-1-alexander.sverdlin@nokia.com>
On Wed, 07 Sep 2022 14:16:29 +0200, Alexander A Sverdlin wrote:
> From: Alexander Sverdlin <alexander.sverdlin@nokia.com>
>
> New pr_err(), a copy of preceeding pr_debug(), faciliates debugging.
>
> This change was inspired by a long lasting debugging of the
> octeon_irq_init_ciu() which fails completely silently and leaves the
> interrupt controller half-way configured which in turn had very non-obvious
> effects.
>
> Signed-off-by: Alexander Sverdlin <alexander.sverdlin@nokia.com>
> ---
>
> Changelog:
> v2:
> * Kept existing pr_debug() on Rob's request
>
> drivers/of/irq.c | 3 +++
> 1 file changed, 3 insertions(+)
>
Applied, thanks!
prev parent reply other threads:[~2022-09-07 15:55 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-07 12:16 [PATCH v2] of: irq: Report individual failures in of_irq_init() Alexander A Sverdlin
2022-09-07 15:54 ` Rob Herring [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220907155456.GA3526808-robh@kernel.org \
--to=robh@kernel.org \
--cc=alexander.sverdlin@nokia.com \
--cc=devicetree@vger.kernel.org \
--cc=frowand.list@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).