* [PATCH v2] of: irq: Report individual failures in of_irq_init()
@ 2022-09-07 12:16 Alexander A Sverdlin
2022-09-07 15:54 ` Rob Herring
0 siblings, 1 reply; 2+ messages in thread
From: Alexander A Sverdlin @ 2022-09-07 12:16 UTC (permalink / raw)
To: devicetree; +Cc: Alexander Sverdlin, Rob Herring, Frank Rowand, linux-kernel
From: Alexander Sverdlin <alexander.sverdlin@nokia.com>
New pr_err(), a copy of preceeding pr_debug(), faciliates debugging.
This change was inspired by a long lasting debugging of the
octeon_irq_init_ciu() which fails completely silently and leaves the
interrupt controller half-way configured which in turn had very non-obvious
effects.
Signed-off-by: Alexander Sverdlin <alexander.sverdlin@nokia.com>
---
Changelog:
v2:
* Kept existing pr_debug() on Rob's request
drivers/of/irq.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/drivers/of/irq.c b/drivers/of/irq.c
index d22f605..2bac44f 100644
--- a/drivers/of/irq.c
+++ b/drivers/of/irq.c
@@ -592,6 +592,9 @@ void __init of_irq_init(const struct of_device_id *matches)
ret = desc->irq_init_cb(desc->dev,
desc->interrupt_parent);
if (ret) {
+ pr_err("%s: Failed to init %pOF (%p), parent %p\n",
+ __func__, desc->dev, desc->dev,
+ desc->interrupt_parent);
of_node_clear_flag(desc->dev, OF_POPULATED);
kfree(desc);
continue;
--
2.10.2
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH v2] of: irq: Report individual failures in of_irq_init()
2022-09-07 12:16 [PATCH v2] of: irq: Report individual failures in of_irq_init() Alexander A Sverdlin
@ 2022-09-07 15:54 ` Rob Herring
0 siblings, 0 replies; 2+ messages in thread
From: Rob Herring @ 2022-09-07 15:54 UTC (permalink / raw)
To: Alexander A Sverdlin; +Cc: Rob Herring, Frank Rowand, linux-kernel, devicetree
On Wed, 07 Sep 2022 14:16:29 +0200, Alexander A Sverdlin wrote:
> From: Alexander Sverdlin <alexander.sverdlin@nokia.com>
>
> New pr_err(), a copy of preceeding pr_debug(), faciliates debugging.
>
> This change was inspired by a long lasting debugging of the
> octeon_irq_init_ciu() which fails completely silently and leaves the
> interrupt controller half-way configured which in turn had very non-obvious
> effects.
>
> Signed-off-by: Alexander Sverdlin <alexander.sverdlin@nokia.com>
> ---
>
> Changelog:
> v2:
> * Kept existing pr_debug() on Rob's request
>
> drivers/of/irq.c | 3 +++
> 1 file changed, 3 insertions(+)
>
Applied, thanks!
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-09-07 15:55 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-09-07 12:16 [PATCH v2] of: irq: Report individual failures in of_irq_init() Alexander A Sverdlin
2022-09-07 15:54 ` Rob Herring
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).