[PATCH v2 1/2] dt-bindings: input: touchscreen: elants_i2c: Add eth3915n touchscreen chip

[PATCH v2 1/2] dt-bindings: input: touchscreen: elants_i2c: Add eth3915n touchscreen chip

[Yunlong Jia]

Add an elan touch screen chip eth3915n.
This chip requires more delay time than the eth3500.

Signed-off-by: Yunlong Jia <yunlong.jia@ecs.com.tw>
Reviewed-by: Douglas Anderson <dianders@chromium.org>
---

(no changes since v1)

 .../devicetree/bindings/input/touchscreen/elan,elants_i2c.yaml   | 1 +
 1 file changed, 1 insertion(+)

diff --git a/Documentation/devicetree/bindings/input/touchscreen/elan,elants_i2c.yaml b/Documentation/devicetree/bindings/input/touchscreen/elan,elants_i2c.yaml
index a9b53c2e6f0ab..d28625372f5ac 100644
--- a/Documentation/devicetree/bindings/input/touchscreen/elan,elants_i2c.yaml
+++ b/Documentation/devicetree/bindings/input/touchscreen/elan,elants_i2c.yaml
@@ -17,6 +17,7 @@ properties:
     enum:
       - elan,ektf3624
       - elan,ekth3500
+      - elan,ekth3915
 
   reg:
     maxItems: 1
-- 
2.17.1

Re: [PATCH v2 1/2] dt-bindings: input: touchscreen: elants_i2c: Add eth3915n touchscreen chip

[David Heidelberg]

Acked-by: David Heidelberg <david@ixit.cz>

On 07/09/2022 07:52, Yunlong Jia wrote:
> Add an elan touch screen chip eth3915n.
> This chip requires more delay time than the eth3500.
>
> Signed-off-by: Yunlong Jia <yunlong.jia@ecs.com.tw>
> Reviewed-by: Douglas Anderson <dianders@chromium.org>
> ---
>
> (no changes since v1)
>
>   .../devicetree/bindings/input/touchscreen/elan,elants_i2c.yaml   | 1 +
>   1 file changed, 1 insertion(+)
>
> diff --git a/Documentation/devicetree/bindings/input/touchscreen/elan,elants_i2c.yaml b/Documentation/devicetree/bindings/input/touchscreen/elan,elants_i2c.yaml
> index a9b53c2e6f0ab..d28625372f5ac 100644
> --- a/Documentation/devicetree/bindings/input/touchscreen/elan,elants_i2c.yaml
> +++ b/Documentation/devicetree/bindings/input/touchscreen/elan,elants_i2c.yaml
> @@ -17,6 +17,7 @@ properties:
>       enum:
>         - elan,ektf3624
>         - elan,ekth3500
> +      - elan,ekth3915
>   
>     reg:
>       maxItems: 1

-- 
David Heidelberg
Consultant Software Engineer

Matrix: @okias:matrix.org

Re: [PATCH v2 1/2] dt-bindings: input: touchscreen: elants_i2c: Add eth3915n touchscreen chip

[Doug Anderson]

Hi,

On Tue, Sep 6, 2022 at 10:52 PM Yunlong Jia
<yunlong.jia@ecs.corp-partner.google.com> wrote:
>
> Add an elan touch screen chip eth3915n.
> This chip requires more delay time than the eth3500.
>
> Signed-off-by: Yunlong Jia <yunlong.jia@ecs.com.tw>
> Reviewed-by: Douglas Anderson <dianders@chromium.org>
> ---
>
> (no changes since v1)

Technically that's not true. You changed your Signed-off-by between v1
and v2. That would be something to mention in the changelog.

Also: I suspect that when a maintainer lands your patch that they'll
get into trouble. That's because your email was sent from
"yunlong.jia@ecs.corp-partner.google.com" but your "Signed-off-by" was
"yunlong.jia@ecs.com.tw". If I try grabbing your patch from the
mailing lists, applying it, and then running it through "checkpatch":

 ./scripts/checkpatch.pl
0001-input-touchscreen-elants_i2c-Add-eth3915n-touchscree.patch
WARNING: From:/Signed-off-by: email address mismatch: 'From: Yunlong
Jia <yunlong.jia@ecs.corp-partner.google.com>' != 'Signed-off-by:
Yunlong Jia <yunlong.jia@ecs.com.tw>'


If I had to guess, the problem is with Google's SMTP servers. If you
logged into the SMTP server with your "corp-partner" address then
Google's SMTP server will automatically re-write your "From" address
to be whatever address you logged in with. I'd guess your options are:

1. Use an official SMTP server for "ecs.com.tw"

...or...

2. I _suspect_ that it will work to set the git config
"sendemail.envelopeSender" to
"yunlong.jia@ecs.corp-partner.google.com". I haven't tested this but I
think it'll work.

Note that when you send a v3, make sure to carry David Heidelberg's Ack.

-Doug

Re: [PATCH v2 1/2] dt-bindings: input: touchscreen: elants_i2c: Add eth3915n touchscreen chip

[Rob Herring]

On Wed, Sep 07, 2022 at 05:52:03AM +0000, Yunlong Jia wrote:
> Add an elan touch screen chip eth3915n.
> This chip requires more delay time than the eth3500.
> 
> Signed-off-by: Yunlong Jia <yunlong.jia@ecs.com.tw>

Author and Sob emails need to match.

> Reviewed-by: Douglas Anderson <dianders@chromium.org>
> ---
> 
> (no changes since v1)
> 
>  .../devicetree/bindings/input/touchscreen/elan,elants_i2c.yaml   | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/Documentation/devicetree/bindings/input/touchscreen/elan,elants_i2c.yaml b/Documentation/devicetree/bindings/input/touchscreen/elan,elants_i2c.yaml
> index a9b53c2e6f0ab..d28625372f5ac 100644
> --- a/Documentation/devicetree/bindings/input/touchscreen/elan,elants_i2c.yaml
> +++ b/Documentation/devicetree/bindings/input/touchscreen/elan,elants_i2c.yaml
> @@ -17,6 +17,7 @@ properties:
>      enum:
>        - elan,ektf3624
>        - elan,ekth3500
> +      - elan,ekth3915
>  
>    reg:
>      maxItems: 1
> -- 
> 2.17.1
> 
>