From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 26D9DECAAD5 for ; Sat, 10 Sep 2022 11:37:21 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229527AbiIJLhU (ORCPT ); Sat, 10 Sep 2022 07:37:20 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57380 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229582AbiIJLhT (ORCPT ); Sat, 10 Sep 2022 07:37:19 -0400 Received: from soltyk.jannau.net (soltyk.jannau.net [144.76.91.90]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E5BA35A81E; Sat, 10 Sep 2022 04:37:15 -0700 (PDT) Received: by soltyk.jannau.net (Postfix, from userid 1000) id 44E6126F009; Sat, 10 Sep 2022 13:37:14 +0200 (CEST) Date: Sat, 10 Sep 2022 13:37:14 +0200 From: Janne Grunau To: Krzysztof Kozlowski Cc: asahi@lists.linux.dev, Mark Kettenis , Alyssa Rosenzweig , Hector Martin , Krzysztof Kozlowski , Rob Herring , Sven Peter , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [RFC PATCH 04/10] dt-bindings: arm: apple: Add t6001/t6002 Mac Studio compatibles Message-ID: <20220910113714.GC4024@jannau.net> References: <20220909135103.98179-1-j@jannau.net> <20220909135103.98179-5-j@jannau.net> <25b42684-1bee-b7f6-a89d-ed0b0ea7428b@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <25b42684-1bee-b7f6-a89d-ed0b0ea7428b@linaro.org> User-Agent: Mutt/1.10.1 (2018-07-13) Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 2022-09-10 11:57:34 +0200, Krzysztof Kozlowski wrote: > On 09/09/2022 15:50, Janne Grunau wrote: > > This adds the following apple,t6001 platform: > > > > - apple,j375c - Mac Studio (M1 Max, 2022) > > > > And the initial apple,t6002 platform: > > > > - apple,j375d - Mac Studio (M1 Ultra, 2022) > > > > Signed-off-by: Janne Grunau > > --- > > > > Documentation/devicetree/bindings/arm/apple.yaml | 11 ++++++++++- > > 1 file changed, 10 insertions(+), 1 deletion(-) > > > > diff --git a/Documentation/devicetree/bindings/arm/apple.yaml b/Documentation/devicetree/bindings/arm/apple.yaml > > index 8d93e8a6cc18..b34e56b9dc59 100644 > > --- a/Documentation/devicetree/bindings/arm/apple.yaml > > +++ b/Documentation/devicetree/bindings/arm/apple.yaml > > @@ -19,12 +19,14 @@ description: | > > - MacBook Air (M1, 2020) > > - iMac (24-inch, M1, 2021) > > > > - And devices based on the "M1 Pro" and "M1 Max" SoCs: > > + And devices based on the "M1 Pro", "M1 Max" and "M1 Ultra" SoCs: > > > > - MacBook Pro (14-inch, M1 Pro, 2021) > > - MacBook Pro (14-inch, M1 Max, 2021) > > - MacBook Pro (16-inch, M1 Pro, 2021) > > - MacBook Pro (16-inch, M1 Max, 2021) > > + - Mac Studio (M1 Max, 2022) > > + - Mac Studio (M1 Ultra, 2022) > > > > The compatible property should follow this format: > > > > @@ -79,8 +81,15 @@ properties: > > - enum: > > - apple,j314c # MacBook Pro (14-inch, M1 Max, 2021) > > - apple,j316c # MacBook Pro (16-inch, M1 Max, 2021) > > + - apple,j375c # Mac Studio (M1 Max, 2022) > > - const: apple,t6001 > > - const: apple,arm-platform > > Blank line. Added. The other entries in this list are not separated by blank lines. What would preferred to fix this? A whitespace only patch or can just add those additional blank lines in this change? > > + - description: Apple M1 Ultra SoC based platforms > > With this: > > > Acked-by: Krzysztof Kozlowski Thanks, Janne