From: Jonathan Cameron <jic23@kernel.org>
To: "Nuno Sá" <nuno.sa@analog.com>
Cc: <linux-iio@vger.kernel.org>, <devicetree@vger.kernel.org>,
Michael Hennerich <Michael.Hennerich@analog.com>,
Lars-Peter Clausen <lars@metafoo.de>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>
Subject: Re: [PATCH 3/3] dt-bindings: iio: adi,ad7923: add range-select property
Date: Sun, 11 Sep 2022 12:28:00 +0100 [thread overview]
Message-ID: <20220911122800.7af5224c@jic23-huawei> (raw)
In-Reply-To: <20220909151413.1164754-4-nuno.sa@analog.com>
On Fri, 9 Sep 2022 17:14:13 +0200
Nuno Sá <nuno.sa@analog.com> wrote:
> Document the new property to select the desired analog input range.
>
> Signed-off-by: Nuno Sá <nuno.sa@analog.com>
> ---
> Documentation/devicetree/bindings/iio/adc/adi,ad7923.yaml | 8 ++++++++
> 1 file changed, 8 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/iio/adc/adi,ad7923.yaml b/Documentation/devicetree/bindings/iio/adc/adi,ad7923.yaml
> index 40b0a887db57..9041020bdb81 100644
> --- a/Documentation/devicetree/bindings/iio/adc/adi,ad7923.yaml
> +++ b/Documentation/devicetree/bindings/iio/adc/adi,ad7923.yaml
> @@ -36,6 +36,14 @@ properties:
> description: |
> The regulator supply for ADC reference voltage.
>
> + adi,range-select:
> + description: Selects the analog input range.
> + 0 - 0 to 2xVREF
> + 1 - 0 to VREF
> + $ref: /schemas/types.yaml#/definitions/uint32
> + enum: [0, 1]
> + default: 1
> +
Would this be better as a flag / boolean called something like
adi,range-double?
> '#address-cells':
> const: 1
>
next prev parent reply other threads:[~2022-09-11 12:02 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-09 15:14 [PATCH 0/3] ad7923 fixes and full range support Nuno Sá
2022-09-09 15:14 ` [PATCH 1/3] iio: adc: ad7923: fix channel readings for some variants Nuno Sá
2022-09-11 11:26 ` Jonathan Cameron
2022-09-12 7:02 ` Nuno Sá
2022-09-09 15:14 ` [PATCH 2/3] iio: adc: ad7923: support extended range Nuno Sá
2022-09-09 15:14 ` [PATCH 3/3] dt-bindings: iio: adi,ad7923: add range-select property Nuno Sá
2022-09-11 11:28 ` Jonathan Cameron [this message]
2022-09-12 7:04 ` Nuno Sá
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220911122800.7af5224c@jic23-huawei \
--to=jic23@kernel.org \
--cc=Michael.Hennerich@analog.com \
--cc=devicetree@vger.kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=nuno.sa@analog.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).