From: Rob Herring <robh@kernel.org>
To: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Cc: Andy Gross <agross@kernel.org>,
linux-arm-msm@vger.kernel.org,
Konrad Dybcio <konrad.dybcio@somainline.org>,
Bjorn Andersson <andersson@kernel.org>,
Srinivas Kandagatla <srinivas.kandagatla@linaro.org>,
Rob Herring <robh+dt@kernel.org>, Mark Brown <broonie@kernel.org>,
linux-kernel@vger.kernel.org,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
alsa-devel@alsa-project.org,
Banajit Goswami <bgoswami@quicinc.com>,
devicetree@vger.kernel.org, Liam Girdwood <lgirdwood@gmail.com>
Subject: Re: [PATCH v3 09/14] ASoC: dt-bindings:: qcom,q6asm: convert to dtschema
Date: Mon, 12 Sep 2022 09:14:37 -0500 [thread overview]
Message-ID: <20220912141437.GA1164860-robh@kernel.org> (raw)
In-Reply-To: <20220908091946.44800-10-krzysztof.kozlowski@linaro.org>
On Thu, 08 Sep 2022 11:19:41 +0200, Krzysztof Kozlowski wrote:
> Convert Qualcomm Audio Stream Manager (Q6ASM) bindings to DT schema.
>
> The original bindings documented:
> 1. APR service node with compatibles: "qcom,q6asm" and
> "qcom,q6asm-v<MAJOR-NUMBER>.<MINOR-NUMBER>",
> 2. actual DAIs child node with compatible "qcom,q6asm-dais".
>
> The conversion entirely drops (1) because the compatible is already
> documented in bindings/soc/qcom/qcom,apr.yaml. The
> "qcom,q6asm-v<MAJOR-NUMBER>.<MINOR-NUMBER>" on the other hand is not
> used at all - neither in existing DTS, nor in downstream sources - so
> versions seems to be fully auto-detectable.
>
> Another change done in conversion is adding "iommus" property, which is
> already used in DTS and Linux driver.
>
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
>
> ---
>
> Expected warning because the qcom,apr.yaml is being fixed in next commit:
>
> Documentation/devicetree/bindings/sound/qcom,q6asm.example.dtb: apr: service@7: 'dais' does not match any of the regexes: '^.*@[0-9a-f]+$', 'pinctrl-[0-9]+'
> From schema: /home/krzk/dev/linux/linux/Documentation/devicetree/bindings/soc/qcom/qcom,apr.yaml
>
> Changes since v2:
> 1. Rename to qcom,q6asm-dais.yaml (Rob)
> 2. Extend commit msg.
>
> Changes since v1:
> 1. New patch.
> ---
> .../bindings/sound/qcom,q6asm-dais.yaml | 112 ++++++++++++++++++
> .../devicetree/bindings/sound/qcom,q6asm.txt | 70 -----------
> 2 files changed, 112 insertions(+), 70 deletions(-)
> create mode 100644 Documentation/devicetree/bindings/sound/qcom,q6asm-dais.yaml
> delete mode 100644 Documentation/devicetree/bindings/sound/qcom,q6asm.txt
>
Reviewed-by: Rob Herring <robh@kernel.org>
next prev parent reply other threads:[~2022-09-12 14:14 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-08 9:19 [PATCH v3 00/14] ASoC/qcom/arm64: Qualcomm ADSP DTS and binding fixes Krzysztof Kozlowski
2022-09-08 9:19 ` [PATCH v3 01/14] arm64: dts: qcom: sdm630: align APR services node names with dtschema Krzysztof Kozlowski
2022-09-08 9:19 ` [PATCH v3 02/14] arm64: dts: qcom: sdm845: " Krzysztof Kozlowski
2022-09-08 9:19 ` [PATCH v3 03/14] arm64: dts: qcom: sm8250: " Krzysztof Kozlowski
2022-09-08 9:19 ` [PATCH v3 04/14] arm64: dts: qcom: msm8996: fix APR services nodes Krzysztof Kozlowski
2022-09-08 9:19 ` [PATCH v3 05/14] arm64: dts: qcom: sdm845: align dai node names with dtschema Krzysztof Kozlowski
2022-09-08 9:19 ` [PATCH v3 06/14] arm64: dts: qcom: msm8996: " Krzysztof Kozlowski
2022-09-08 9:19 ` [PATCH v3 07/14] arm64: dts: qcom: qrb5165-rb5: " Krzysztof Kozlowski
2022-09-08 9:19 ` [PATCH v3 08/14] arm64: dts: qcom: sm8250: use generic name for LPASS clock controller Krzysztof Kozlowski
2022-09-08 9:19 ` [PATCH v3 09/14] ASoC: dt-bindings:: qcom,q6asm: convert to dtschema Krzysztof Kozlowski
2022-09-12 14:14 ` Rob Herring [this message]
2022-09-08 9:19 ` [PATCH v3 10/14] dt-bindings: soc: qcom: apr: correct service children Krzysztof Kozlowski
2022-09-08 9:19 ` [PATCH v3 11/14] ASoC: dt-bindings: qcom,q6dsp-lpass-ports: cleanup example Krzysztof Kozlowski
2022-09-08 9:19 ` [PATCH v3 12/14] ASoC: dt-bindings: qcom,q6dsp-lpass-clocks: " Krzysztof Kozlowski
2022-09-08 9:19 ` [PATCH v3 13/14] ASoC: dt-bindings: qcom,q6apm-dai: adjust indentation in example Krzysztof Kozlowski
2022-09-08 9:19 ` [PATCH v3 14/14] dt-bindings: soc: qcom: apr: add missing properties Krzysztof Kozlowski
2022-09-12 14:54 ` [PATCH v3 00/14] ASoC/qcom/arm64: Qualcomm ADSP DTS and binding fixes Mark Brown
2022-09-13 9:08 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220912141437.GA1164860-robh@kernel.org \
--to=robh@kernel.org \
--cc=agross@kernel.org \
--cc=alsa-devel@alsa-project.org \
--cc=andersson@kernel.org \
--cc=bgoswami@quicinc.com \
--cc=broonie@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=konrad.dybcio@somainline.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=krzysztof.kozlowski@linaro.org \
--cc=lgirdwood@gmail.com \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=srinivas.kandagatla@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).