From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id AC488C54EE9 for ; Tue, 13 Sep 2022 10:58:28 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231724AbiIMK61 (ORCPT ); Tue, 13 Sep 2022 06:58:27 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39128 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231924AbiIMK6G (ORCPT ); Tue, 13 Sep 2022 06:58:06 -0400 Received: from mail-pj1-x1031.google.com (mail-pj1-x1031.google.com [IPv6:2607:f8b0:4864:20::1031]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1161C5F9B8 for ; Tue, 13 Sep 2022 03:57:55 -0700 (PDT) Received: by mail-pj1-x1031.google.com with SMTP id x1-20020a17090ab00100b001fda21bbc90so15224872pjq.3 for ; Tue, 13 Sep 2022 03:57:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=user-agent:in-reply-to:content-disposition:mime-version:references :message-id:subject:cc:to:from:date:from:to:cc:subject:date; bh=oecofVMrcCfLyVCVWoV6+PgNwd31Jhh4K2JgKw6ALKM=; b=OU5BpUXJqwh+x0q2JoTTulUldi4JBs6zIF1xVeSxip7z3hA5lNh8JhLOKACWiot3MM NBR1IzVqsO4wAzVa3Pp6/RE1sRrrWqQFZnYm3fg/tJr2jdi2kxjreMsL1TX1wl9yxTRw rKF7Xvy96vhado2/ZPEOM1uItzyHiZx1OwvxKllFcDTkqD2/zCIm+ta/JkvVqkesf4Cc cav5Uro0qKwyjYRfTtyYlXT81COF6IHi4jGv1XKSqXCAmtYzKIh2D6Wa2uKQ3i4nVG8u FyYlUl2HT3ToQh2qFTH0JjkZWdpswOmSIFz9Gyw2p5mLoD6AsPclzh2eqok6Z4thjApY 8QMA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=user-agent:in-reply-to:content-disposition:mime-version:references :message-id:subject:cc:to:from:date:x-gm-message-state:from:to:cc :subject:date; bh=oecofVMrcCfLyVCVWoV6+PgNwd31Jhh4K2JgKw6ALKM=; b=ULsgkAjbH96d3U5aGiQNckBlalhXpyHUvLxGJe6Wy/0htjMrJatNK/XeKJd0lO/KtL NT2UAfhtB710CaOY9wl1nIfx5tkBbvPRKUJ9gKhc3Hym3DH0NJ+B5zWF7We/QFPAi4EK QrglZRShuN3Zqr5sx/uyUee76s6yz0VanfyF2jfBHClA97tOIqqataKgo0xbL3ASdtoa yzmkNxGEluT3i3ikSjZVExGRJJGAjf2wE3sbkuPTMNi6we82GEpi5utwXFbpNSpQd1hT 60HmuXoVxp2MrFhVwOb05rcL91rkiYIrkGd/Won79dsvmJr730ZMm9t0ETQ0GsgvpUpj KWCQ== X-Gm-Message-State: ACgBeo38uFQlzztU/3GibYokz4SedFLQ/donrs1fXHbw5yN88jr9Lxzp Q4CKFFmkbz9tx3fcBxW7czJ0 X-Google-Smtp-Source: AA6agR54HVbJgY27UAeqFdFj6GgyYH6g+KFP3wrsO5pAbNf0KTIemd7XibKY7hR/Tk//NhRD5prcxQ== X-Received: by 2002:a17:90b:380d:b0:202:56b2:4ef8 with SMTP id mq13-20020a17090b380d00b0020256b24ef8mr3508672pjb.2.1663066662120; Tue, 13 Sep 2022 03:57:42 -0700 (PDT) Received: from workstation ([117.202.184.122]) by smtp.gmail.com with ESMTPSA id c21-20020aa79535000000b0052dfe83e19csm7720788pfp.16.2022.09.13.03.57.37 (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Tue, 13 Sep 2022 03:57:39 -0700 (PDT) Date: Tue, 13 Sep 2022 16:27:34 +0530 From: Manivannan Sadhasivam To: Johan Hovold Cc: Bjorn Andersson , konrad.dybcio@somainline.org, krzysztof.kozlowski+dt@linaro.org, linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, johan+linaro@kernel.org, steev@kali.org Subject: Re: [PATCH] arm64: dts: qcom: thinkpad-x13s: Update firmware location Message-ID: <20220913105734.GD25849@workstation> References: <20220913054030.3234-1-manivannan.sadhasivam@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.9.4 (2018-02-28) Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On Tue, Sep 13, 2022 at 12:07:32PM +0200, Johan Hovold wrote: > [ Resend with Bjorn's address updated as the Linaro one now bounces. ] > > On Tue, Sep 13, 2022 at 11:10:30AM +0530, Manivannan Sadhasivam wrote: > > The firmware location in linux-firmware has been changed to include the > > SoC name. So use the updated location in Thinkpad devicetree. > > > > Signed-off-by: Manivannan Sadhasivam > > --- > > arch/arm64/boot/dts/qcom/sc8280xp-lenovo-thinkpad-x13s.dts | 4 ++-- > > 1 file changed, 2 insertions(+), 2 deletions(-) > > I guess we should pick a commit prefix that we stick to for changes to > this driver. > > arm64: dts: qcom: sc8280xp-lenovo-thinkpad-x13s: > > is arguably unnecessarily long even if it follows the pattern of some > other qcom dts. > > Shall we just use > > arm64: dts: qcom: sc8280xp-x13s: This looks looks better. I did look into the earlier commits but I found the prefix to be too long, so went with the last commit prefix. > > which matches sc8280xp-crd? Or stick "lenovo" in there as well? Or just > keep the whole thing unchanged? > > > diff --git a/arch/arm64/boot/dts/qcom/sc8280xp-lenovo-thinkpad-x13s.dts b/arch/arm64/boot/dts/qcom/sc8280xp-lenovo-thinkpad-x13s.dts > > index c379650e52b1..3b7943d6e164 100644 > > --- a/arch/arm64/boot/dts/qcom/sc8280xp-lenovo-thinkpad-x13s.dts > > +++ b/arch/arm64/boot/dts/qcom/sc8280xp-lenovo-thinkpad-x13s.dts > > @@ -554,13 +554,13 @@ keyboard@68 { > > }; > > > > &remoteproc_adsp { > > - firmware-name = "qcom/LENOVO/21BX/qcadsp8280.mbn"; > > + firmware-name = "qcom/sc8280xp/LENOVO/21BX/qcadsp8280.mbn"; > > > > status = "okay"; > > }; > > > > &remoteproc_nsp0 { > > - firmware-name = "qcom/LENOVO/21BX/qccdsp8280.mbn"; > > + firmware-name = "qcom/sc8280xp/LENOVO/21BX/qccdsp8280.mbn"; > > > > status = "okay"; > > }; > > Change itself looks good otherwise: > > Reviewed-by: Johan Hovold > Thanks! I will respin with the agreed prefix. Regards, Mani > Johan