From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id D1C41C6FA82 for ; Tue, 13 Sep 2022 13:02:43 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231794AbiIMNCm (ORCPT ); Tue, 13 Sep 2022 09:02:42 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53936 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231150AbiIMNCl (ORCPT ); Tue, 13 Sep 2022 09:02:41 -0400 Received: from mail-oa1-f53.google.com (mail-oa1-f53.google.com [209.85.160.53]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0436D43611; Tue, 13 Sep 2022 06:02:40 -0700 (PDT) Received: by mail-oa1-f53.google.com with SMTP id 586e51a60fabf-127f5411b9cso31872902fac.4; Tue, 13 Sep 2022 06:02:39 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date; bh=OgnINX3gYcstW1evxH4c9tGrrNpe5XBwb2TjVnDG0QI=; b=TIg9bPCaOXBH00VhQ4rUG5hbXBUqD+f6BsXKMFi6uBMRnyTbMgDyzbv54aHXcXBiWJ IM9hZjy0e2lfj1gEM+4qFmUNsgwUEI4jBYhE/sX8wk6SUFD4hdH4409gKp3vhjok9Szk J5VNuYk0JmKdctn/mmgGLiQ6FvL5rUcbtiS+nIZqic2ywzJMBq6kYXVHPJlPXQ3nsHaW noUq/iwU3tBDjkFZQL2lpllURS0Ac0EFsm1f/C0u5v6iACZNFNecAEzC07WIrNpYzdvo 3bgHlEWa7UhgDBkC+6X8fDcdIblw8wSqFRejsJmBJa5gKewehkiJ/v3tE1rKv40mnexn wCXw== X-Gm-Message-State: ACgBeo1vkK3lMoQP9WCB0IgDhYGUoJ8NYw+UJSf8YM2WWcbPkwKKU16L KCXVqHhQ+A1NSbcc3aVRhA== X-Google-Smtp-Source: AA6agR4uCX2BHaqbqlBF8DTJ9Smk5/pE3HR04TnTTDMAIDX38owBddvZg873IHTo02S2GViD1abMJQ== X-Received: by 2002:a05:6870:f721:b0:12b:f4bc:9ee3 with SMTP id ej33-20020a056870f72100b0012bf4bc9ee3mr900973oab.106.1663074159082; Tue, 13 Sep 2022 06:02:39 -0700 (PDT) Received: from robh.at.kernel.org (66-90-144-107.dyn.grandenetworks.net. [66.90.144.107]) by smtp.gmail.com with ESMTPSA id bl32-20020a05680830a000b0034d9042758fsm5168189oib.24.2022.09.13.06.02.38 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 13 Sep 2022 06:02:38 -0700 (PDT) Received: (nullmailer pid 3488951 invoked by uid 1000); Tue, 13 Sep 2022 13:02:37 -0000 Date: Tue, 13 Sep 2022 08:02:37 -0500 From: Rob Herring To: Yoshihiro Shimoda Cc: davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, krzysztof.kozlowski+dt@linaro.org, geert+renesas@glider.be, netdev@vger.kernel.org, devicetree@vger.kernel.org, linux-renesas-soc@vger.kernel.org Subject: Re: [PATCH 2/5] dt-bindings: net: renesas: Document Renesas Ethernet Switch Message-ID: <20220913130237.GA3475975-robh@kernel.org> References: <20220909132614.1967276-1-yoshihiro.shimoda.uh@renesas.com> <20220909132614.1967276-3-yoshihiro.shimoda.uh@renesas.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220909132614.1967276-3-yoshihiro.shimoda.uh@renesas.com> Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On Fri, Sep 09, 2022 at 10:26:11PM +0900, Yoshihiro Shimoda wrote: > Document Renesas Etherent Switch for R-Car S4-8 (r8a779f0). > > Signed-off-by: Yoshihiro Shimoda > --- > .../bindings/net/renesas,etherswitch.yaml | 252 ++++++++++++++++++ > 1 file changed, 252 insertions(+) > create mode 100644 Documentation/devicetree/bindings/net/renesas,etherswitch.yaml > > diff --git a/Documentation/devicetree/bindings/net/renesas,etherswitch.yaml b/Documentation/devicetree/bindings/net/renesas,etherswitch.yaml > new file mode 100644 > index 000000000000..1affbf208829 > --- /dev/null > +++ b/Documentation/devicetree/bindings/net/renesas,etherswitch.yaml > @@ -0,0 +1,252 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/net/renesas,etherswitch.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Renesas Ethernet Switch > + > +maintainers: > + - Yoshihiro Shimoda > + > +properties: > + compatible: > + const: renesas,r8a779f0-ether-switch > + > + reg: > + maxItems: 3 > + > + reg-names: > + items: > + - const: base > + - const: secure_base > + - const: serdes Is serdes really the same h/w block? Based on addresses, doesn't seem like it. > + > + interrupts: > + maxItems: 47 > + > + interrupt-names: > + items: > + - const: mfwd_error > + - const: race_error > + - const: coma_error > + - const: gwca0_error > + - const: gwca1_error > + - const: etha0_error > + - const: etha1_error > + - const: etha2_error > + - const: gptp0_status > + - const: gptp1_status > + - const: mfwd_status > + - const: race_status > + - const: coma_status > + - const: gwca0_status > + - const: gwca1_status > + - const: etha0_status > + - const: etha1_status > + - const: etha2_status > + - const: rmac0_status > + - const: rmac1_status > + - const: rmac2_status > + - const: gwca0_rxtx0 > + - const: gwca0_rxtx1 > + - const: gwca0_rxtx2 > + - const: gwca0_rxtx3 > + - const: gwca0_rxtx4 > + - const: gwca0_rxtx5 > + - const: gwca0_rxtx6 > + - const: gwca0_rxtx7 > + - const: gwca1_rxtx0 > + - const: gwca1_rxtx1 > + - const: gwca1_rxtx2 > + - const: gwca1_rxtx3 > + - const: gwca1_rxtx4 > + - const: gwca1_rxtx5 > + - const: gwca1_rxtx6 > + - const: gwca1_rxtx7 > + - const: gwca0_rxts0 > + - const: gwca0_rxts1 > + - const: gwca1_rxts0 > + - const: gwca1_rxts1 > + - const: rmac0_mdio > + - const: rmac1_mdio > + - const: rmac2_mdio > + - const: rmac0_phy > + - const: rmac1_phy > + - const: rmac2_phy > + > + clocks: > + maxItems: 2 > + > + clock-names: > + items: > + - const: fck > + - const: tsn > + > + resets: > + maxItems: 2 What is each one? > + > + iommus: > + maxItems: 16 > + > + power-domains: > + maxItems: 1 > + > + '#address-cells': > + description: Number of address cells for the MDIO bus. > + const: 1 > + > + '#size-cells': > + description: Number of size cells on the MDIO bus. > + const: 0 It's better if you put MDIO under an 'mdio' node. That also needs a ref to mdio.yaml. > + > + ports: > + type: object > + > + properties: > + '#address-cells': > + const: 1 > + '#size-cells': > + const: 0 > + > + additionalProperties: false > + > + patternProperties: > + "^port@[0-9a-f]+$": > + type: object > + > + $ref: "/schemas/net/ethernet-controller.yaml#" > + unevaluatedProperties: false > + > + properties: > + '#address-cells': > + const: 1 > + '#size-cells': > + const: 0 > + > + reg: > + description: > + Switch port number > + > + phy-handle: > + description: > + Phandle of an Ethernet PHY. > + > + phy-mode: > + description: > + This specifies the interface used by the Ethernet PHY. > + enum: > + - mii > + - sgmii > + - usxgmii > + > + required: > + - reg > + - phy-handle > + - phy-mode > + > +required: > + - compatible > + - reg > + - reg-names > + - interrupts > + - interrupt-names > + - clocks > + - clock-names > + - resets > + - power-domains > + - '#address-cells' > + - '#size-cells' > + > +additionalProperties: false > + > +examples: > + - | > + #include > + #include > + #include > + > + rswitch: ethernet@e6880000 { Drop unused labels. > + compatible = "renesas,r8a779f0-ether-switch"; > + reg = <0xe6880000 0x20000>, <0xe68c0000 0x20000>, > + <0xe6444000 0xc00>; > + reg-names = "base", "secure_base", "serdes"; > + interrupts = , > + , > + , > + , > + , > + , > + , > + , > + , > + , > + , > + , > + , > + , > + , > + , > + , > + , > + , > + , > + , > + , > + , > + , > + , > + , > + , > + , > + , > + , > + , > + , > + , > + , > + , > + , > + , > + , > + , > + , > + , > + , > + , > + , > + , > + , > + ; > + interrupt-names = "mfwd_error", "race_error", > + "coma_error", "gwca0_error", > + "gwca1_error", "etha0_error", > + "etha1_error", "etha2_error", > + "gptp0_status", "gptp1_status", > + "mfwd_status", "race_status", > + "coma_status", "gwca0_status", > + "gwca1_status", "etha0_status", > + "etha1_status", "etha2_status", > + "rmac0_status", "rmac1_status", > + "rmac2_status", > + "gwca0_rxtx0", "gwca0_rxtx1", > + "gwca0_rxtx2", "gwca0_rxtx3", > + "gwca0_rxtx4", "gwca0_rxtx5", > + "gwca0_rxtx6", "gwca0_rxtx7", > + "gwca1_rxtx0", "gwca1_rxtx1", > + "gwca1_rxtx2", "gwca1_rxtx3", > + "gwca1_rxtx4", "gwca1_rxtx5", > + "gwca1_rxtx6", "gwca1_rxtx7", > + "gwca0_rxts0", "gwca0_rxts1", > + "gwca1_rxts0", "gwca1_rxts1", > + "rmac0_mdio", "rmac1_mdio", > + "rmac2_mdio", > + "rmac0_phy", "rmac1_phy", > + "rmac2_phy"; > + #address-cells = <1>; > + #size-cells = <0>; > + clocks = <&cpg CPG_MOD 1506>, <&cpg CPG_MOD 1505>; > + clock-names = "fck", "tsn"; > + power-domains = <&sysc R8A779F0_PD_ALWAYS_ON>; > + resets = <&cpg 1506>, <&cpg 1505>; > + }; > -- > 2.25.1 > >