From: Bjorn Helgaas <helgaas@kernel.org>
To: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
Cc: lpieralisi@kernel.org, robh@kernel.org, andersson@kernel.org,
kw@linux.com, bhelgaas@google.com, linux-pci@vger.kernel.org,
linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org,
konrad.dybcio@somainline.org, robh+dt@kernel.org,
krzysztof.kozlowski+dt@linaro.org, devicetree@vger.kernel.org,
dmitry.baryshkov@linaro.org
Subject: Re: [PATCH v3 02/12] PCI: qcom-ep: Do not use hardcoded clks in driver
Date: Tue, 13 Sep 2022 15:12:56 -0500 [thread overview]
Message-ID: <20220913201256.GA620427@bhelgaas> (raw)
In-Reply-To: <20220910063045.16648-3-manivannan.sadhasivam@linaro.org>
On Sat, Sep 10, 2022 at 12:00:35PM +0530, Manivannan Sadhasivam wrote:
> Generally, device drivers should just rely on the platform data like
> devicetree to supply the clocks required for the functioning of the
> peripheral. There is no need to hardcode the clk info in the driver.
> So get rid of the static clk info and obtain the platform supplied
> clks.
Possibly reword the subject line to say what this does instead of what
it does not do? E.g., "Rely on devicetree 'clock-names' instead of
hard-coding" or whatever.
Bjorn
next prev parent reply other threads:[~2022-09-13 20:13 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-10 6:30 [PATCH v3 00/12] Improvements to the Qcom PCIe Endpoint driver Manivannan Sadhasivam
2022-09-10 6:30 ` [PATCH v3 01/12] PCI: qcom-ep: Add kernel-doc for qcom_pcie_ep structure Manivannan Sadhasivam
2022-09-10 6:30 ` [PATCH v3 02/12] PCI: qcom-ep: Do not use hardcoded clks in driver Manivannan Sadhasivam
2022-09-13 20:12 ` Bjorn Helgaas [this message]
2022-09-14 6:05 ` Manivannan Sadhasivam
2022-09-10 6:30 ` [PATCH v3 03/12] PCI: qcom-ep: Make use of the cached dev pointer Manivannan Sadhasivam
2022-09-10 6:30 ` [PATCH v3 04/12] PCI: qcom-ep: Disable IRQs during driver remove Manivannan Sadhasivam
2022-09-10 6:30 ` [PATCH v3 05/12] PCI: qcom-ep: Expose link transition counts via debugfs Manivannan Sadhasivam
2022-09-10 6:30 ` [PATCH v3 06/12] PCI: qcom-ep: Gate Master AXI clock to MHI bus during L1SS Manivannan Sadhasivam
2022-09-10 6:30 ` [PATCH v3 07/12] PCI: qcom-ep: Disable Master AXI Clock when there is no PCIe traffic Manivannan Sadhasivam
2022-09-10 6:30 ` [PATCH v3 08/12] dt-bindings: PCI: qcom-ep: Make PERST separation optional Manivannan Sadhasivam
2022-09-10 6:30 ` [PATCH v3 09/12] " Manivannan Sadhasivam
2022-09-10 6:30 ` [PATCH v3 10/12] dt-bindings: PCI: qcom-ep: Define clocks per platform Manivannan Sadhasivam
2022-09-11 13:38 ` Krzysztof Kozlowski
2022-09-10 6:30 ` [PATCH v3 11/12] dt-bindings: PCI: qcom-ep: Add support for SM8450 SoC Manivannan Sadhasivam
2022-09-10 14:53 ` Rob Herring
2022-09-11 13:45 ` Krzysztof Kozlowski
2022-09-13 14:44 ` Rob Herring
2022-09-10 6:30 ` [PATCH v3 12/12] " Manivannan Sadhasivam
2022-09-13 16:44 ` [PATCH v3 00/12] Improvements to the Qcom PCIe Endpoint driver Manivannan Sadhasivam
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220913201256.GA620427@bhelgaas \
--to=helgaas@kernel.org \
--cc=andersson@kernel.org \
--cc=bhelgaas@google.com \
--cc=devicetree@vger.kernel.org \
--cc=dmitry.baryshkov@linaro.org \
--cc=konrad.dybcio@somainline.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=kw@linux.com \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=lpieralisi@kernel.org \
--cc=manivannan.sadhasivam@linaro.org \
--cc=robh+dt@kernel.org \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).