* [PATCH] arm64: dts: qcom: thinkpad-x13s: Update firmware location
@ 2022-09-13 5:40 Manivannan Sadhasivam
2022-09-13 10:00 ` Johan Hovold
` (2 more replies)
0 siblings, 3 replies; 6+ messages in thread
From: Manivannan Sadhasivam @ 2022-09-13 5:40 UTC (permalink / raw)
To: bjorn.andersson
Cc: konrad.dybcio, krzysztof.kozlowski+dt, linux-arm-msm, devicetree,
linux-kernel, johan+linaro, steev, Manivannan Sadhasivam
The firmware location in linux-firmware has been changed to include the
SoC name. So use the updated location in Thinkpad devicetree.
Signed-off-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
---
arch/arm64/boot/dts/qcom/sc8280xp-lenovo-thinkpad-x13s.dts | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/arch/arm64/boot/dts/qcom/sc8280xp-lenovo-thinkpad-x13s.dts b/arch/arm64/boot/dts/qcom/sc8280xp-lenovo-thinkpad-x13s.dts
index c379650e52b1..3b7943d6e164 100644
--- a/arch/arm64/boot/dts/qcom/sc8280xp-lenovo-thinkpad-x13s.dts
+++ b/arch/arm64/boot/dts/qcom/sc8280xp-lenovo-thinkpad-x13s.dts
@@ -554,13 +554,13 @@ keyboard@68 {
};
&remoteproc_adsp {
- firmware-name = "qcom/LENOVO/21BX/qcadsp8280.mbn";
+ firmware-name = "qcom/sc8280xp/LENOVO/21BX/qcadsp8280.mbn";
status = "okay";
};
&remoteproc_nsp0 {
- firmware-name = "qcom/LENOVO/21BX/qccdsp8280.mbn";
+ firmware-name = "qcom/sc8280xp/LENOVO/21BX/qccdsp8280.mbn";
status = "okay";
};
--
2.30.2
^ permalink raw reply related [flat|nested] 6+ messages in thread* Re: [PATCH] arm64: dts: qcom: thinkpad-x13s: Update firmware location
2022-09-13 5:40 [PATCH] arm64: dts: qcom: thinkpad-x13s: Update firmware location Manivannan Sadhasivam
@ 2022-09-13 10:00 ` Johan Hovold
2022-09-13 10:07 ` Johan Hovold
2022-09-13 20:27 ` Steev Klimaszewski
2 siblings, 0 replies; 6+ messages in thread
From: Johan Hovold @ 2022-09-13 10:00 UTC (permalink / raw)
To: Manivannan Sadhasivam
Cc: bjorn.andersson, konrad.dybcio, krzysztof.kozlowski+dt,
linux-arm-msm, devicetree, linux-kernel, johan+linaro, steev
On Tue, Sep 13, 2022 at 11:10:30AM +0530, Manivannan Sadhasivam wrote:
> The firmware location in linux-firmware has been changed to include the
> SoC name. So use the updated location in Thinkpad devicetree.
>
> Signed-off-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
> ---
> arch/arm64/boot/dts/qcom/sc8280xp-lenovo-thinkpad-x13s.dts | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
I guess we should pick a commit prefix that we stick to for changes to
this driver.
arm64: dts: qcom: sc8280xp-lenovo-thinkpad-x13s:
is arguably unnecessarily long even if it follows the pattern of some
other qcom dts.
Shall we just use
arm64: dts: qcom: sc8280xp-x13s:
which matches sc8280xp-crd? Or stick "lenovo" in there as well? Or just
keep the whole thing unchanged?
> diff --git a/arch/arm64/boot/dts/qcom/sc8280xp-lenovo-thinkpad-x13s.dts b/arch/arm64/boot/dts/qcom/sc8280xp-lenovo-thinkpad-x13s.dts
> index c379650e52b1..3b7943d6e164 100644
> --- a/arch/arm64/boot/dts/qcom/sc8280xp-lenovo-thinkpad-x13s.dts
> +++ b/arch/arm64/boot/dts/qcom/sc8280xp-lenovo-thinkpad-x13s.dts
> @@ -554,13 +554,13 @@ keyboard@68 {
> };
>
> &remoteproc_adsp {
> - firmware-name = "qcom/LENOVO/21BX/qcadsp8280.mbn";
> + firmware-name = "qcom/sc8280xp/LENOVO/21BX/qcadsp8280.mbn";
>
> status = "okay";
> };
>
> &remoteproc_nsp0 {
> - firmware-name = "qcom/LENOVO/21BX/qccdsp8280.mbn";
> + firmware-name = "qcom/sc8280xp/LENOVO/21BX/qccdsp8280.mbn";
>
> status = "okay";
> };
Change itself looks good otherwise:
Reviewed-by: Johan Hovold <johan+linaro@kernel.org>
Johan
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH] arm64: dts: qcom: thinkpad-x13s: Update firmware location
2022-09-13 5:40 [PATCH] arm64: dts: qcom: thinkpad-x13s: Update firmware location Manivannan Sadhasivam
2022-09-13 10:00 ` Johan Hovold
@ 2022-09-13 10:07 ` Johan Hovold
2022-09-13 10:57 ` Manivannan Sadhasivam
2022-09-13 20:27 ` Steev Klimaszewski
2 siblings, 1 reply; 6+ messages in thread
From: Johan Hovold @ 2022-09-13 10:07 UTC (permalink / raw)
To: Manivannan Sadhasivam, Bjorn Andersson
Cc: konrad.dybcio, krzysztof.kozlowski+dt, linux-arm-msm, devicetree,
linux-kernel, johan+linaro, steev
[ Resend with Bjorn's address updated as the Linaro one now bounces. ]
On Tue, Sep 13, 2022 at 11:10:30AM +0530, Manivannan Sadhasivam wrote:
> The firmware location in linux-firmware has been changed to include the
> SoC name. So use the updated location in Thinkpad devicetree.
>
> Signed-off-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
> ---
> arch/arm64/boot/dts/qcom/sc8280xp-lenovo-thinkpad-x13s.dts | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
I guess we should pick a commit prefix that we stick to for changes to
this driver.
arm64: dts: qcom: sc8280xp-lenovo-thinkpad-x13s:
is arguably unnecessarily long even if it follows the pattern of some
other qcom dts.
Shall we just use
arm64: dts: qcom: sc8280xp-x13s:
which matches sc8280xp-crd? Or stick "lenovo" in there as well? Or just
keep the whole thing unchanged?
> diff --git a/arch/arm64/boot/dts/qcom/sc8280xp-lenovo-thinkpad-x13s.dts b/arch/arm64/boot/dts/qcom/sc8280xp-lenovo-thinkpad-x13s.dts
> index c379650e52b1..3b7943d6e164 100644
> --- a/arch/arm64/boot/dts/qcom/sc8280xp-lenovo-thinkpad-x13s.dts
> +++ b/arch/arm64/boot/dts/qcom/sc8280xp-lenovo-thinkpad-x13s.dts
> @@ -554,13 +554,13 @@ keyboard@68 {
> };
>
> &remoteproc_adsp {
> - firmware-name = "qcom/LENOVO/21BX/qcadsp8280.mbn";
> + firmware-name = "qcom/sc8280xp/LENOVO/21BX/qcadsp8280.mbn";
>
> status = "okay";
> };
>
> &remoteproc_nsp0 {
> - firmware-name = "qcom/LENOVO/21BX/qccdsp8280.mbn";
> + firmware-name = "qcom/sc8280xp/LENOVO/21BX/qccdsp8280.mbn";
>
> status = "okay";
> };
Change itself looks good otherwise:
Reviewed-by: Johan Hovold <johan+linaro@kernel.org>
Johan
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH] arm64: dts: qcom: thinkpad-x13s: Update firmware location
2022-09-13 10:07 ` Johan Hovold
@ 2022-09-13 10:57 ` Manivannan Sadhasivam
2022-09-13 20:13 ` Bjorn Andersson
0 siblings, 1 reply; 6+ messages in thread
From: Manivannan Sadhasivam @ 2022-09-13 10:57 UTC (permalink / raw)
To: Johan Hovold
Cc: Bjorn Andersson, konrad.dybcio, krzysztof.kozlowski+dt,
linux-arm-msm, devicetree, linux-kernel, johan+linaro, steev
On Tue, Sep 13, 2022 at 12:07:32PM +0200, Johan Hovold wrote:
> [ Resend with Bjorn's address updated as the Linaro one now bounces. ]
>
> On Tue, Sep 13, 2022 at 11:10:30AM +0530, Manivannan Sadhasivam wrote:
> > The firmware location in linux-firmware has been changed to include the
> > SoC name. So use the updated location in Thinkpad devicetree.
> >
> > Signed-off-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
> > ---
> > arch/arm64/boot/dts/qcom/sc8280xp-lenovo-thinkpad-x13s.dts | 4 ++--
> > 1 file changed, 2 insertions(+), 2 deletions(-)
>
> I guess we should pick a commit prefix that we stick to for changes to
> this driver.
>
> arm64: dts: qcom: sc8280xp-lenovo-thinkpad-x13s:
>
> is arguably unnecessarily long even if it follows the pattern of some
> other qcom dts.
>
> Shall we just use
>
> arm64: dts: qcom: sc8280xp-x13s:
This looks looks better. I did look into the earlier commits but I found
the prefix to be too long, so went with the last commit prefix.
>
> which matches sc8280xp-crd? Or stick "lenovo" in there as well? Or just
> keep the whole thing unchanged?
>
> > diff --git a/arch/arm64/boot/dts/qcom/sc8280xp-lenovo-thinkpad-x13s.dts b/arch/arm64/boot/dts/qcom/sc8280xp-lenovo-thinkpad-x13s.dts
> > index c379650e52b1..3b7943d6e164 100644
> > --- a/arch/arm64/boot/dts/qcom/sc8280xp-lenovo-thinkpad-x13s.dts
> > +++ b/arch/arm64/boot/dts/qcom/sc8280xp-lenovo-thinkpad-x13s.dts
> > @@ -554,13 +554,13 @@ keyboard@68 {
> > };
> >
> > &remoteproc_adsp {
> > - firmware-name = "qcom/LENOVO/21BX/qcadsp8280.mbn";
> > + firmware-name = "qcom/sc8280xp/LENOVO/21BX/qcadsp8280.mbn";
> >
> > status = "okay";
> > };
> >
> > &remoteproc_nsp0 {
> > - firmware-name = "qcom/LENOVO/21BX/qccdsp8280.mbn";
> > + firmware-name = "qcom/sc8280xp/LENOVO/21BX/qccdsp8280.mbn";
> >
> > status = "okay";
> > };
>
> Change itself looks good otherwise:
>
> Reviewed-by: Johan Hovold <johan+linaro@kernel.org>
>
Thanks! I will respin with the agreed prefix.
Regards,
Mani
> Johan
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH] arm64: dts: qcom: thinkpad-x13s: Update firmware location
2022-09-13 10:57 ` Manivannan Sadhasivam
@ 2022-09-13 20:13 ` Bjorn Andersson
0 siblings, 0 replies; 6+ messages in thread
From: Bjorn Andersson @ 2022-09-13 20:13 UTC (permalink / raw)
To: Manivannan Sadhasivam
Cc: Johan Hovold, konrad.dybcio, krzysztof.kozlowski+dt,
linux-arm-msm, devicetree, linux-kernel, johan+linaro, steev
On Tue, Sep 13, 2022 at 04:27:34PM +0530, Manivannan Sadhasivam wrote:
> On Tue, Sep 13, 2022 at 12:07:32PM +0200, Johan Hovold wrote:
> > [ Resend with Bjorn's address updated as the Linaro one now bounces. ]
> >
> > On Tue, Sep 13, 2022 at 11:10:30AM +0530, Manivannan Sadhasivam wrote:
> > > The firmware location in linux-firmware has been changed to include the
> > > SoC name. So use the updated location in Thinkpad devicetree.
> > >
> > > Signed-off-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
> > > ---
> > > arch/arm64/boot/dts/qcom/sc8280xp-lenovo-thinkpad-x13s.dts | 4 ++--
> > > 1 file changed, 2 insertions(+), 2 deletions(-)
> >
> > I guess we should pick a commit prefix that we stick to for changes to
> > this driver.
> >
> > arm64: dts: qcom: sc8280xp-lenovo-thinkpad-x13s:
> >
> > is arguably unnecessarily long even if it follows the pattern of some
> > other qcom dts.
> >
> > Shall we just use
> >
> > arm64: dts: qcom: sc8280xp-x13s:
>
> This looks looks better. I did look into the earlier commits but I found
> the prefix to be too long, so went with the last commit prefix.
>
+1
> >
> > which matches sc8280xp-crd? Or stick "lenovo" in there as well? Or just
> > keep the whole thing unchanged?
> >
> > > diff --git a/arch/arm64/boot/dts/qcom/sc8280xp-lenovo-thinkpad-x13s.dts b/arch/arm64/boot/dts/qcom/sc8280xp-lenovo-thinkpad-x13s.dts
> > > index c379650e52b1..3b7943d6e164 100644
> > > --- a/arch/arm64/boot/dts/qcom/sc8280xp-lenovo-thinkpad-x13s.dts
> > > +++ b/arch/arm64/boot/dts/qcom/sc8280xp-lenovo-thinkpad-x13s.dts
> > > @@ -554,13 +554,13 @@ keyboard@68 {
> > > };
> > >
> > > &remoteproc_adsp {
> > > - firmware-name = "qcom/LENOVO/21BX/qcadsp8280.mbn";
> > > + firmware-name = "qcom/sc8280xp/LENOVO/21BX/qcadsp8280.mbn";
> > >
> > > status = "okay";
> > > };
> > >
> > > &remoteproc_nsp0 {
> > > - firmware-name = "qcom/LENOVO/21BX/qccdsp8280.mbn";
> > > + firmware-name = "qcom/sc8280xp/LENOVO/21BX/qccdsp8280.mbn";
> > >
> > > status = "okay";
> > > };
> >
> > Change itself looks good otherwise:
> >
> > Reviewed-by: Johan Hovold <johan+linaro@kernel.org>
> >
>
> Thanks! I will respin with the agreed prefix.
>
> Regards,
> Mani
>
> > Johan
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] arm64: dts: qcom: thinkpad-x13s: Update firmware location
2022-09-13 5:40 [PATCH] arm64: dts: qcom: thinkpad-x13s: Update firmware location Manivannan Sadhasivam
2022-09-13 10:00 ` Johan Hovold
2022-09-13 10:07 ` Johan Hovold
@ 2022-09-13 20:27 ` Steev Klimaszewski
2 siblings, 0 replies; 6+ messages in thread
From: Steev Klimaszewski @ 2022-09-13 20:27 UTC (permalink / raw)
To: Manivannan Sadhasivam, bjorn.andersson
Cc: konrad.dybcio, krzysztof.kozlowski+dt, linux-arm-msm, devicetree,
linux-kernel, johan+linaro
On 9/13/22 12:40 AM, Manivannan Sadhasivam wrote:
> The firmware location in linux-firmware has been changed to include the
> SoC name. So use the updated location in Thinkpad devicetree.
>
> Signed-off-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
> ---
> arch/arm64/boot/dts/qcom/sc8280xp-lenovo-thinkpad-x13s.dts | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/arch/arm64/boot/dts/qcom/sc8280xp-lenovo-thinkpad-x13s.dts b/arch/arm64/boot/dts/qcom/sc8280xp-lenovo-thinkpad-x13s.dts
> index c379650e52b1..3b7943d6e164 100644
> --- a/arch/arm64/boot/dts/qcom/sc8280xp-lenovo-thinkpad-x13s.dts
> +++ b/arch/arm64/boot/dts/qcom/sc8280xp-lenovo-thinkpad-x13s.dts
> @@ -554,13 +554,13 @@ keyboard@68 {
> };
>
> &remoteproc_adsp {
> - firmware-name = "qcom/LENOVO/21BX/qcadsp8280.mbn";
> + firmware-name = "qcom/sc8280xp/LENOVO/21BX/qcadsp8280.mbn";
>
> status = "okay";
> };
>
> &remoteproc_nsp0 {
> - firmware-name = "qcom/LENOVO/21BX/qccdsp8280.mbn";
> + firmware-name = "qcom/sc8280xp/LENOVO/21BX/qccdsp8280.mbn";
>
> status = "okay";
> };
Tested-by: Steev Klimaszewski <steev@kali.org>
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2022-09-13 20:27 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-09-13 5:40 [PATCH] arm64: dts: qcom: thinkpad-x13s: Update firmware location Manivannan Sadhasivam
2022-09-13 10:00 ` Johan Hovold
2022-09-13 10:07 ` Johan Hovold
2022-09-13 10:57 ` Manivannan Sadhasivam
2022-09-13 20:13 ` Bjorn Andersson
2022-09-13 20:27 ` Steev Klimaszewski
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).