[PATCH v5 0/2] spmi: pmic-arb: Add support for PMIC v7

[PATCH v5 0/2] spmi: pmic-arb: Add support for PMIC v7

[Vinod Koul]

Hello,

The is version 5 of support for PMIC v7. I have added a new property
qcom,bus-id for supporting v7 and then add driver changes for v7

Changes since v4:
 - Fix David name and email
 - remove trailing line in binding

Changes since v3:
 - rebase on spmi/next

David Collins (1):
  spmi: pmic-arb: Add support for PMIC v7

Vinod Koul (1):
  dt-bindings: spmi: Add qcom,bus-id

 .../bindings/spmi/qcom,spmi-pmic-arb.yaml     |  10 +
 drivers/spmi/spmi-pmic-arb.c                  | 242 ++++++++++++++++--
 2 files changed, 231 insertions(+), 21 deletions(-)


base-commit: 18c42f8d23426d3f4048df89523aa47203c3493a
-- 
2.37.3

[PATCH v5 1/2] dt-bindings: spmi: Add qcom,bus-id

[Vinod Koul]

For PMIC arbiter version 7 and beyond we need to define if we are using
primary or secondary bus, so add a new property of qcom,bus-id

Signed-off-by: Vinod Koul <vkoul@kernel.org>
Acked-by: Rob Herring <robh@kernel.org>
---
 .../devicetree/bindings/spmi/qcom,spmi-pmic-arb.yaml   | 10 ++++++++++
 1 file changed, 10 insertions(+)

diff --git a/Documentation/devicetree/bindings/spmi/qcom,spmi-pmic-arb.yaml b/Documentation/devicetree/bindings/spmi/qcom,spmi-pmic-arb.yaml
index fee4f0eb4665..f983b4af6db9 100644
--- a/Documentation/devicetree/bindings/spmi/qcom,spmi-pmic-arb.yaml
+++ b/Documentation/devicetree/bindings/spmi/qcom,spmi-pmic-arb.yaml
@@ -85,6 +85,14 @@ properties:
     description: >
       which of the PMIC Arb provided channels to use for accesses
 
+  qcom,bus-id:
+    $ref: /schemas/types.yaml#/definitions/uint32
+    minimum: 0
+    maximum: 1
+    description: >
+      SPMI bus instance. only applicable to PMIC arbiter version 7 and beyond.
+      Supported values, 0 = primary bus, 1 = secondary bus
+
 required:
   - compatible
   - reg-names
@@ -113,5 +121,7 @@ examples:
 
         interrupt-controller;
         #interrupt-cells = <4>;
+
+        qcom,bus-id = <0>;
     };
 
-- 
2.37.3

Re: [PATCH v5 1/2] dt-bindings: spmi: Add qcom,bus-id

[Krzysztof Kozlowski]

On Wed, 14 Sep 2022 22:22:11 +0530, Vinod Koul wrote:
> For PMIC arbiter version 7 and beyond we need to define if we are using
> primary or secondary bus, so add a new property of qcom,bus-id
> 
> Signed-off-by: Vinod Koul <vkoul@kernel.org>
> Acked-by: Rob Herring <robh@kernel.org>
> ---
>  .../devicetree/bindings/spmi/qcom,spmi-pmic-arb.yaml   | 10 ++++++++++
>  1 file changed, 10 insertions(+)
> 

My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check'
on your patch (DT_CHECKER_FLAGS is new in v5.13):

yamllint warnings/errors:

dtschema/dtc warnings/errors:
/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/dma/st,stm32-dmamux.example.dtb: dma-router@40020800: dma-masters:0: [4294967295, 4294967295] is too long
	From schema: /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/dma/st,stm32-dmamux.yaml
/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/dma/st,stm32-dmamux.example.dtb: dma-router@40020800: Unevaluated properties are not allowed ('dma-channels', 'dma-masters', 'dma-requests' were unexpected)
	From schema: /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/dma/st,stm32-dmamux.yaml
/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/dma/st,stm32-dmamux.example.dtb: dma-router@40020800: dma-masters:0: [4294967295, 4294967295] is too long
	From schema: /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/dma/dma-router.yaml
/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/dma/renesas,rzn1-dmamux.example.dtb: dma-router@a0: dma-masters:0: [4294967295, 4294967295] is too long
	From schema: /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/dma/dma-router.yaml
/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/dma/renesas,rzn1-dmamux.example.dtb: dma-router@a0: dma-masters:0: [4294967295, 4294967295] is too long
	From schema: /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/dma/renesas,rzn1-dmamux.yaml

doc reference errors (make refcheckdocs):

See https://patchwork.ozlabs.org/patch/

This check can fail if there are any dependencies. The base for a patch
series is generally the most recent rc1.

If you already ran 'make dt_binding_check' and didn't see the above
error(s), then make sure 'yamllint' is installed and dt-schema is up to
date:

pip3 install dtschema --upgrade

Please check and re-submit.

Re: [PATCH v5 1/2] dt-bindings: spmi: Add qcom,bus-id

[Rob Herring]

On Thu, Sep 15, 2022 at 10:51:03AM +0100, Krzysztof Kozlowski wrote:
> On Wed, 14 Sep 2022 22:22:11 +0530, Vinod Koul wrote:
> > For PMIC arbiter version 7 and beyond we need to define if we are using
> > primary or secondary bus, so add a new property of qcom,bus-id
> > 
> > Signed-off-by: Vinod Koul <vkoul@kernel.org>
> > Acked-by: Rob Herring <robh@kernel.org>
> > ---
> >  .../devicetree/bindings/spmi/qcom,spmi-pmic-arb.yaml   | 10 ++++++++++
> >  1 file changed, 10 insertions(+)
> > 
> 
> My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check'
> on your patch (DT_CHECKER_FLAGS is new in v5.13):
> 
> yamllint warnings/errors:
> 
> dtschema/dtc warnings/errors:
> /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/dma/st,stm32-dmamux.example.dtb: dma-router@40020800: dma-masters:0: [4294967295, 4294967295] is too long
> 	From schema: /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/dma/st,stm32-dmamux.yaml
> /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/dma/st,stm32-dmamux.example.dtb: dma-router@40020800: Unevaluated properties are not allowed ('dma-channels', 'dma-masters', 'dma-requests' were unexpected)
> 	From schema: /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/dma/st,stm32-dmamux.yaml
> /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/dma/st,stm32-dmamux.example.dtb: dma-router@40020800: dma-masters:0: [4294967295, 4294967295] is too long
> 	From schema: /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/dma/dma-router.yaml
> /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/dma/renesas,rzn1-dmamux.example.dtb: dma-router@a0: dma-masters:0: [4294967295, 4294967295] is too long
> 	From schema: /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/dma/dma-router.yaml
> /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/dma/renesas,rzn1-dmamux.example.dtb: dma-router@a0: dma-masters:0: [4294967295, 4294967295] is too long
> 	From schema: /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/dma/renesas,rzn1-dmamux.yaml

Ignore this. Unrelated.

Rob

Re: [PATCH v5 1/2] dt-bindings: spmi: Add qcom,bus-id

[Vinod Koul]

On 15-09-22, 06:59, Rob Herring wrote:
> On Thu, Sep 15, 2022 at 10:51:03AM +0100, Krzysztof Kozlowski wrote:
> > On Wed, 14 Sep 2022 22:22:11 +0530, Vinod Koul wrote:
> > > For PMIC arbiter version 7 and beyond we need to define if we are using
> > > primary or secondary bus, so add a new property of qcom,bus-id
> > > 
> > > Signed-off-by: Vinod Koul <vkoul@kernel.org>
> > > Acked-by: Rob Herring <robh@kernel.org>
> > > ---
> > >  .../devicetree/bindings/spmi/qcom,spmi-pmic-arb.yaml   | 10 ++++++++++
> > >  1 file changed, 10 insertions(+)
> > > 
> > 
> > My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check'
> > on your patch (DT_CHECKER_FLAGS is new in v5.13):
> > 
> > yamllint warnings/errors:
> > 
> > dtschema/dtc warnings/errors:
> > /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/dma/st,stm32-dmamux.example.dtb: dma-router@40020800: dma-masters:0: [4294967295, 4294967295] is too long
> > 	From schema: /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/dma/st,stm32-dmamux.yaml
> > /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/dma/st,stm32-dmamux.example.dtb: dma-router@40020800: Unevaluated properties are not allowed ('dma-channels', 'dma-masters', 'dma-requests' were unexpected)
> > 	From schema: /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/dma/st,stm32-dmamux.yaml
> > /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/dma/st,stm32-dmamux.example.dtb: dma-router@40020800: dma-masters:0: [4294967295, 4294967295] is too long
> > 	From schema: /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/dma/dma-router.yaml
> > /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/dma/renesas,rzn1-dmamux.example.dtb: dma-router@a0: dma-masters:0: [4294967295, 4294967295] is too long
> > 	From schema: /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/dma/dma-router.yaml
> > /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/dma/renesas,rzn1-dmamux.example.dtb: dma-router@a0: dma-masters:0: [4294967295, 4294967295] is too long
> > 	From schema: /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/dma/renesas,rzn1-dmamux.yaml
> 
> Ignore this. Unrelated.

Right!

-- 
~Vinod

Re: [PATCH v5 1/2] dt-bindings: spmi: Add qcom,bus-id

[Bjorn Andersson]

On Wed, Sep 14, 2022 at 10:22:11PM +0530, Vinod Koul wrote:
> For PMIC arbiter version 7 and beyond we need to define if we are using
> primary or secondary bus, so add a new property of qcom,bus-id
> 
> Signed-off-by: Vinod Koul <vkoul@kernel.org>
> Acked-by: Rob Herring <robh@kernel.org>

Reviewed-by: Bjorn Andersson <andersson@kernel.org>

> ---
>  .../devicetree/bindings/spmi/qcom,spmi-pmic-arb.yaml   | 10 ++++++++++
>  1 file changed, 10 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/spmi/qcom,spmi-pmic-arb.yaml b/Documentation/devicetree/bindings/spmi/qcom,spmi-pmic-arb.yaml
> index fee4f0eb4665..f983b4af6db9 100644
> --- a/Documentation/devicetree/bindings/spmi/qcom,spmi-pmic-arb.yaml
> +++ b/Documentation/devicetree/bindings/spmi/qcom,spmi-pmic-arb.yaml
> @@ -85,6 +85,14 @@ properties:
>      description: >
>        which of the PMIC Arb provided channels to use for accesses
>  
> +  qcom,bus-id:
> +    $ref: /schemas/types.yaml#/definitions/uint32
> +    minimum: 0
> +    maximum: 1
> +    description: >
> +      SPMI bus instance. only applicable to PMIC arbiter version 7 and beyond.
> +      Supported values, 0 = primary bus, 1 = secondary bus
> +
>  required:
>    - compatible
>    - reg-names
> @@ -113,5 +121,7 @@ examples:
>  
>          interrupt-controller;
>          #interrupt-cells = <4>;
> +
> +        qcom,bus-id = <0>;
>      };
>  
> -- 
> 2.37.3
> 

Re: [PATCH v5 0/2] spmi: pmic-arb: Add support for PMIC v7

[Vinod Koul]

On 14-09-22, 22:22, Vinod Koul wrote:
> Hello,
> 
> The is version 5 of support for PMIC v7. I have added a new property
> qcom,bus-id for supporting v7 and then add driver changes for v7

Steve,

Can you please get this in for v6.1 ?

> 
> Changes since v4:
>  - Fix David name and email
>  - remove trailing line in binding
> 
> Changes since v3:
>  - rebase on spmi/next
> 
> David Collins (1):
>   spmi: pmic-arb: Add support for PMIC v7
> 
> Vinod Koul (1):
>   dt-bindings: spmi: Add qcom,bus-id
> 
>  .../bindings/spmi/qcom,spmi-pmic-arb.yaml     |  10 +
>  drivers/spmi/spmi-pmic-arb.c                  | 242 ++++++++++++++++--
>  2 files changed, 231 insertions(+), 21 deletions(-)
> 
> 
> base-commit: 18c42f8d23426d3f4048df89523aa47203c3493a
> -- 
> 2.37.3

-- 
~Vinod

Re: [PATCH v5 0/2] spmi: pmic-arb: Add support for PMIC v7

[Vinod Koul]

On 21-09-22, 20:45, Vinod Koul wrote:
> On 14-09-22, 22:22, Vinod Koul wrote:
> > Hello,
> > 
> > The is version 5 of support for PMIC v7. I have added a new property
> > qcom,bus-id for supporting v7 and then add driver changes for v7
> 
> Steve,
> 
> Can you please get this in for v6.1 ?

I dont know what I can do now to get this patch in... looks like 6.1 is
missed too!

> 
> > 
> > Changes since v4:
> >  - Fix David name and email
> >  - remove trailing line in binding
> > 
> > Changes since v3:
> >  - rebase on spmi/next
> > 
> > David Collins (1):
> >   spmi: pmic-arb: Add support for PMIC v7
> > 
> > Vinod Koul (1):
> >   dt-bindings: spmi: Add qcom,bus-id
> > 
> >  .../bindings/spmi/qcom,spmi-pmic-arb.yaml     |  10 +
> >  drivers/spmi/spmi-pmic-arb.c                  | 242 ++++++++++++++++--
> >  2 files changed, 231 insertions(+), 21 deletions(-)
> > 
> > 
> > base-commit: 18c42f8d23426d3f4048df89523aa47203c3493a
> > -- 
> > 2.37.3
> 
> -- 
> ~Vinod

-- 
~Vinod

Re: [PATCH v5 0/2] spmi: pmic-arb: Add support for PMIC v7

[Vinod Koul]

On 14-09-22, 22:22, Vinod Koul wrote:
> Hello,
> 
> The is version 5 of support for PMIC v7. I have added a new property
> qcom,bus-id for supporting v7 and then add driver changes for v7

Stephen,

Can you pick this? It has been so long...

> 
> Changes since v4:
>  - Fix David name and email
>  - remove trailing line in binding
> 
> Changes since v3:
>  - rebase on spmi/next
> 
> David Collins (1):
>   spmi: pmic-arb: Add support for PMIC v7
> 
> Vinod Koul (1):
>   dt-bindings: spmi: Add qcom,bus-id
> 
>  .../bindings/spmi/qcom,spmi-pmic-arb.yaml     |  10 +
>  drivers/spmi/spmi-pmic-arb.c                  | 242 ++++++++++++++++--
>  2 files changed, 231 insertions(+), 21 deletions(-)
> 
> 
> base-commit: 18c42f8d23426d3f4048df89523aa47203c3493a
> -- 
> 2.37.3

-- 
~Vinod

Re: [PATCH v5 0/2] spmi: pmic-arb: Add support for PMIC v7

[Melody Olvera]

On 11/3/2022 9:27 AM, Vinod Koul wrote:
> On 14-09-22, 22:22, Vinod Koul wrote:
>> Hello,
>>
>> The is version 5 of support for PMIC v7. I have added a new property
>> qcom,bus-id for supporting v7 and then add driver changes for v7
> Stephen,
>
> Can you pick this? It has been so long...

Hi Stephen,

Do you mind looking at this? I've got some patches that depend on functionality here...
https://lore.kernel.org/all/20221118192241.29384-1-quic_molvera@quicinc.com/

Thanks,
Melody

>> Changes since v4:
>>  - Fix David name and email
>>  - remove trailing line in binding
>>
>> Changes since v3:
>>  - rebase on spmi/next
>>
>> David Collins (1):
>>   spmi: pmic-arb: Add support for PMIC v7
>>
>> Vinod Koul (1):
>>   dt-bindings: spmi: Add qcom,bus-id
>>
>>  .../bindings/spmi/qcom,spmi-pmic-arb.yaml     |  10 +
>>  drivers/spmi/spmi-pmic-arb.c                  | 242 ++++++++++++++++--
>>  2 files changed, 231 insertions(+), 21 deletions(-)
>>
>>
>> base-commit: 18c42f8d23426d3f4048df89523aa47203c3493a
>> -- 
>> 2.37.3

Re: [PATCH v5 0/2] spmi: pmic-arb: Add support for PMIC v7

[Krzysztof Kozlowski]

On 18/11/2022 20:24, Melody Olvera wrote:
> 
> 
> On 11/3/2022 9:27 AM, Vinod Koul wrote:
>> On 14-09-22, 22:22, Vinod Koul wrote:
>>> Hello,
>>>
>>> The is version 5 of support for PMIC v7. I have added a new property
>>> qcom,bus-id for supporting v7 and then add driver changes for v7
>> Stephen,
>>
>> Can you pick this? It has been so long...
> 
> Hi Stephen,
> 
> Do you mind looking at this? I've got some patches that depend on functionality here...
> https://lore.kernel.org/all/20221118192241.29384-1-quic_molvera@quicinc.com/

This was merged.

Best regards,
Krzysztof