From: Rob Herring <robh@kernel.org>
To: Julius Werner <jwerner@chromium.org>
Cc: Jian-Jia Su <jjsu@google.com>, Dmitry Osipenko <digetx@gmail.com>,
Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
Rob Herring <robh+dt@kernel.org>,
linux-kernel@vger.kernel.org, devicetree@vger.kernel.org,
Doug Anderson <dianders@chromium.org>
Subject: Re: [PATCH 2/4 v4] dt-bindings: memory: Add numeric LPDDR compatible string variant
Date: Thu, 15 Sep 2022 08:44:12 -0500 [thread overview]
Message-ID: <20220915134412.GB1168889-robh@kernel.org> (raw)
In-Reply-To: <20220915003222.1296421-2-jwerner@chromium.org>
On Wed, 14 Sep 2022 17:32:20 -0700, Julius Werner wrote:
> This patch allows a new kind of compatible string for LPDDR parts in the
> device tree bindings, in addition to the existing hardcoded
> <vendor>,<part-number> strings. The new format contains manufacturer and
> part (revision) information in numerical form, such as lpddr3-ff,0201
> for an LPDDR3 part with manufacturer ID ff and revision ID 0201. This
> helps cases where LPDDR parts are probed at runtime by boot firmware and
> cannot be matched to hardcoded part numbers, such as the firmware on the
> qcom/sc7280-herobrine boards does (which supports 4 different memory
> configurations at the moment, and more are expected to be added later at
> a point where the boot firmware can no longer be updated to specifically
> accomodate them).
>
> Signed-off-by: Julius Werner <jwerner@chromium.org>
> ---
> .../memory-controllers/ddr/jedec,lpddr-props.yaml | 10 ++++++++++
> .../memory-controllers/ddr/jedec,lpddr2.yaml | 8 +++++---
> .../memory-controllers/ddr/jedec,lpddr3.yaml | 12 ++++++++----
> 3 files changed, 23 insertions(+), 7 deletions(-)
>
> Changelog:
>
> - v2
> - Updated commit message to describe intended use case as an example
> - v3
> - no changes
> - v4
> - no changes
>
Please add Acked-by/Reviewed-by tags when posting new versions. However,
there's no need to repost patches *only* to add the tags. The upstream
maintainer will do that for acks received on the version they apply.
If a tag was not added on purpose, please state why and what changed.
next prev parent reply other threads:[~2022-09-15 13:45 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-15 0:32 [PATCH 1/4 v4] dt-bindings: memory: Factor out common properties of LPDDR bindings Julius Werner
2022-09-15 0:32 ` [PATCH 2/4 v4] dt-bindings: memory: Add numeric LPDDR compatible string variant Julius Werner
2022-09-15 13:44 ` Rob Herring [this message]
2022-09-15 0:32 ` [PATCH 3/4 v4] dt-bindings: memory: Add jedec,lpddr4 and jedec,lpddr5 bindings Julius Werner
2022-09-16 19:31 ` Rob Herring
2022-09-15 0:32 ` [PATCH 4/4 v4] dt-bindings: memory: Add jedec,lpddrX-channel binding Julius Werner
2022-09-15 13:44 ` [PATCH 1/4 v4] dt-bindings: memory: Factor out common properties of LPDDR bindings Rob Herring
2022-09-30 1:00 ` Julius Werner
2022-09-30 6:51 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220915134412.GB1168889-robh@kernel.org \
--to=robh@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dianders@chromium.org \
--cc=digetx@gmail.com \
--cc=jjsu@google.com \
--cc=jwerner@chromium.org \
--cc=krzysztof.kozlowski@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).