From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5253EC6FA86 for ; Fri, 16 Sep 2022 13:15:58 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230389AbiIPNP5 (ORCPT ); Fri, 16 Sep 2022 09:15:57 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43392 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231304AbiIPNPx (ORCPT ); Fri, 16 Sep 2022 09:15:53 -0400 Received: from mail-wr1-x436.google.com (mail-wr1-x436.google.com [IPv6:2a00:1450:4864:20::436]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id CDC3DA3D44 for ; Fri, 16 Sep 2022 06:15:48 -0700 (PDT) Received: by mail-wr1-x436.google.com with SMTP id d2so428364wrq.2 for ; Fri, 16 Sep 2022 06:15:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amarulasolutions.com; s=google; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date; bh=i4mPbdPGjHv0um90MutjKinuU1Lx+BVJ0wJv3GWLz84=; b=C++7rBhy/Dx+3AP2+vmvjlVXg+zma5e3vfULL2ktwdZCFhIHFUGHTnjuL9vVgLaEvp yE0AMK2SVLXMSG80lVSBxNOluZWNVPjCpFnPQfxOnzKkXq0UDHNyhIK69dWwakWdSYrs S1zZ9PCbqpPPVY6tXT7B7Mz4fOW1mcu9c2R4o= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date; bh=i4mPbdPGjHv0um90MutjKinuU1Lx+BVJ0wJv3GWLz84=; b=FTlCAD74bJcCieeBf13/d4xGEZDLflzZDwRl6UJ4i9J6kN1eNKsMrQYOa1g3Mc0xDH ry8eVKGp4ddOoobFOx7VJ4XbiQCnOpOpzeewhB0P53YvtXOfxsZjUqxUWhkUhcKL/qLR bCla1qpXau7yzZOZ91AgbLsO1U+3WCTCjBnOIypeEvi20KYpfVlGCOiPjfDSeAWhSjlJ ICNW/4fn9LFPfvgyzfzOWaKgII7+SO0S2miEghV7EAP5gQgE+FRuX/fVGfxBh1+LO16g joogIKfbARYTRHCR+NNTjxWOgUtEYsYPJq1rhNzR9DZpUYi3D5DLzgjmaTditQ6tVhFj Km0g== X-Gm-Message-State: ACrzQf0Yc+WIL7AYo9msLkVKNxQRGFp7z4TxfpVHVohNlunzAQOwmFKZ uNE7QPKdKlvWRK7oUE8d7P2zJw== X-Google-Smtp-Source: AMsMyM5IvmfdOa/MgpEJ8io6Vb6oRbSe9R4KKpn2BCjc/bvFyBBZEN6kUYYkmGlP7fEneUa8vF+LuA== X-Received: by 2002:a5d:6488:0:b0:225:f99:338b with SMTP id o8-20020a5d6488000000b002250f99338bmr2911254wri.638.1663334147257; Fri, 16 Sep 2022 06:15:47 -0700 (PDT) Received: from tom-ThinkPad-T14s-Gen-2i ([89.101.193.68]) by smtp.gmail.com with ESMTPSA id m6-20020a05600c4f4600b003b47581979bsm2344450wmq.33.2022.09.16.06.15.45 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 16 Sep 2022 06:15:46 -0700 (PDT) Date: Fri, 16 Sep 2022 15:15:44 +0200 From: Tommaso Merciai To: Mikhail Rudenko Cc: Mauro Carvalho Chehab , Rob Herring , Krzysztof Kozlowski , Sakari Ailus , Hans Verkuil , Jacopo Mondi , Shawn Tu , Christian Hemp , Arec Kao , Arnd Bergmann , Laurent Pinchart , Daniel Scally , Jimmy Su , linux-media@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 1/2] media: dt-bindings: media: i2c: document OV4689 DT bindings Message-ID: <20220916131544.GA2701@tom-ThinkPad-T14s-Gen-2i> References: <20220911200147.375198-1-mike.rudenko@gmail.com> <20220911200147.375198-2-mike.rudenko@gmail.com> <20220913140553.GA2735@tom-ThinkPad-T14s-Gen-2i> <87sfkspa6b.fsf@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <87sfkspa6b.fsf@gmail.com> Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org Hi Mikhail, On Thu, Sep 15, 2022 at 11:11:57PM +0300, Mikhail Rudenko wrote: > > Hi Tommaso, > > On 2022-09-13 at 16:05 +02, Tommaso Merciai wrote: > > Hi Mikhail, > > > > On Sun, Sep 11, 2022 at 11:01:34PM +0300, Mikhail Rudenko wrote: > >> Add device-tree binding documentation for OV4689 image sensor driver, > >> and the relevant MAINTAINERS entries. > >> > >> Signed-off-by: Mikhail Rudenko > >> --- > >> .../bindings/media/i2c/ovti,ov4689.yaml | 141 ++++++++++++++++++ > >> MAINTAINERS | 7 + > >> 2 files changed, 148 insertions(+) > >> create mode 100644 Documentation/devicetree/bindings/media/i2c/ovti,ov4689.yaml > >> > >> diff --git a/Documentation/devicetree/bindings/media/i2c/ovti,ov4689.yaml b/Documentation/devicetree/bindings/media/i2c/ovti,ov4689.yaml > >> new file mode 100644 > >> index 000000000000..376330b5572a > >> --- /dev/null > >> +++ b/Documentation/devicetree/bindings/media/i2c/ovti,ov4689.yaml > >> @@ -0,0 +1,141 @@ > >> +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause) > >> +%YAML 1.2 > >> +--- > >> +$id: http://devicetree.org/schemas/media/i2c/ovti,ov4689.yaml# > >> +$schema: http://devicetree.org/meta-schemas/core.yaml# > >> + > >> +title: Omnivision OV4689 CMOS > >> + > >> +maintainers: > >> + - Mikhail Rudenko > >> + > >> +description: | > >> + The Omnivision OV4689 is a high performance, 1/3-inch, 4 megapixel > >> + image sensor. Ihis chip supports high frame rate speeds up to 90 fps > >> + at 2688x1520 resolution. It is programmable through an I2C > >> + interface, and sensor output is sent via 1/2/4 lane MIPI CSI-2 > >> + connection. > >> + > >> +allOf: > >> + - $ref: /schemas/media/video-interface-devices.yaml# > >> + > >> +properties: > >> + compatible: > >> + const: ovti,ov4689 > >> + > >> + reg: > >> + maxItems: 1 > >> + > >> + clocks: > >> + description: > >> + External clock (XVCLK) for the sensor, 6-64 MHz > >> + maxItems: 1 > >> + > >> + clock-names: true > >> + > >> + dovdd-supply: > >> + description: > >> + Digital I/O voltage supply, 1.7-3.0 V > >> + > >> + avdd-supply: > >> + description: > >> + Analog voltage supply, 2.6-3.0 V > >> + > >> + dvdd-supply: > >> + description: > >> + Digital core voltage supply, 1.1-1.3 V > >> + > >> + powerdown-gpios: > >> + maxItems: 1 > >> + description: > >> + GPIO connected to the powerdown pin (active low) > >> + > >> + reset-gpios: > >> + maxItems: 1 > >> + description: > >> + GPIO connected to the reset pin (active low) > >> + > >> + orientation: true > >> + > >> + rotation: true > >> + > >> + port: > >> + $ref: /schemas/graph.yaml#/$defs/port-base > >> + additionalProperties: false > >> + description: > >> + Output port node, single endpoint describing the CSI-2 transmitter > >> + > >> + properties: > >> + endpoint: > >> + $ref: /schemas/media/video-interfaces.yaml# > >> + unevaluatedProperties: false > >> + > >> + properties: > >> + data-lanes: > >> + oneOf: > >> + - items: > >> + - const: 1 > >> + - const: 2 > >> + - const: 3 > >> + - const: 4 > >> + - items: > >> + - const: 1 > >> + - const: 2 > >> + - items: > >> + - const: 1 > >> + link-frequencies: true > >> + > >> + required: > >> + - data-lanes > >> + - link-frequencies > >> + > >> +required: > >> + - compatible > >> + - reg > >> + - clocks > >> + - clock-names > >> + - dovdd-supply > >> + - avdd-supply > >> + - dvdd-supply > >> + - powerdown-gpios > >> + - reset-gpios > >> + - port > > > > I think we don't need all of these entries as required. > > The only let me say "really" required are: > > > > - compatible > > - reg > > - clocks > > - port > > Thanks for the review! I agree that the driver may be modified to work > without powerdown and reset gpios and they are not required for sensor > operation. On contrary, supplies are obviously required. Of course, linux > provides dummy regulators if supplies are missing from device tree, but > I though the intention was to document hardware, not implementation > details. What do think of this? We have already discuss on this on the following thread sometimes ago :) https://www.patchwork.linux-fancy.com/project/linux-fancy/patch/20220630134835.592521-6-tommaso.merciai@amarulasolutions.com/ Take a look and let me know. Thanks, Tommaso > > > Regards, > > Tommaso > > -- > Best regards, > Mikhail Rudenko -- Tommaso Merciai Embedded Linux Engineer tommaso.merciai@amarulasolutions.com __________________________________ Amarula Solutions SRL Via Le Canevare 30, 31100 Treviso, Veneto, IT T. +39 042 243 5310 info@amarulasolutions.com www.amarulasolutions.com