From: Marco Felsch <m.felsch@pengutronix.de>
To: mchehab@kernel.org, robh+dt@kernel.org,
krzysztof.kozlowski+dt@linaro.org, kishon@ti.com,
vkoul@kernel.org, sakari.ailus@linux.intel.com,
hverkuil@xs4all.nl, jacopo@jmondi.org,
laurent.pinchart+renesas@ideasonboard.com
Cc: kieran.bingham+renesas@ideasonboard.com,
linux-media@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-phy@lists.infradead.org,
kernel@pengutronix.de
Subject: [PATCH v2 2/4] phy: dphy: add support to calculate the timing based on hs_clk_rate
Date: Fri, 16 Sep 2022 15:45:33 +0200 [thread overview]
Message-ID: <20220916134535.128131-3-m.felsch@pengutronix.de> (raw)
In-Reply-To: <20220916134535.128131-1-m.felsch@pengutronix.de>
For MIPI-CSI sender use-case it is common to specify the allowed
link-frequencies which should be used for the MIPI link and is
half the hs-clock rate.
This commit adds a helper to calculate the D-PHY timing based on the
hs-clock rate so we don't need to calculate the timings within the
driver.
Signed-off-by: Marco Felsch <m.felsch@pengutronix.de>
Acked-by: Vinod Koul <vkoul@kernel.org>
---
Changelog:
v2:
- added Vinod Koul a-b
drivers/phy/phy-core-mipi-dphy.c | 22 ++++++++++++++++++----
include/linux/phy/phy-mipi-dphy.h | 3 +++
2 files changed, 21 insertions(+), 4 deletions(-)
diff --git a/drivers/phy/phy-core-mipi-dphy.c b/drivers/phy/phy-core-mipi-dphy.c
index ba365bc77407..f4956a417a47 100644
--- a/drivers/phy/phy-core-mipi-dphy.c
+++ b/drivers/phy/phy-core-mipi-dphy.c
@@ -20,16 +20,18 @@
static int phy_mipi_dphy_calc_config(unsigned long pixel_clock,
unsigned int bpp,
unsigned int lanes,
+ unsigned long long hs_clk_rate,
struct phy_configure_opts_mipi_dphy *cfg)
{
- unsigned long long hs_clk_rate;
unsigned long long ui;
if (!cfg)
return -EINVAL;
- hs_clk_rate = pixel_clock * bpp;
- do_div(hs_clk_rate, lanes);
+ if (!hs_clk_rate) {
+ hs_clk_rate = pixel_clock * bpp;
+ do_div(hs_clk_rate, lanes);
+ }
ui = ALIGN(PSEC_PER_SEC, hs_clk_rate);
do_div(ui, hs_clk_rate);
@@ -81,11 +83,23 @@ int phy_mipi_dphy_get_default_config(unsigned long pixel_clock,
unsigned int lanes,
struct phy_configure_opts_mipi_dphy *cfg)
{
- return phy_mipi_dphy_calc_config(pixel_clock, bpp, lanes, cfg);
+ return phy_mipi_dphy_calc_config(pixel_clock, bpp, lanes, 0, cfg);
}
EXPORT_SYMBOL(phy_mipi_dphy_get_default_config);
+int phy_mipi_dphy_get_default_config_for_hsclk(unsigned long long hs_clk_rate,
+ unsigned int lanes,
+ struct phy_configure_opts_mipi_dphy *cfg)
+{
+ if (!hs_clk_rate)
+ return -EINVAL;
+
+ return phy_mipi_dphy_calc_config(0, 0, lanes, hs_clk_rate, cfg);
+
+}
+EXPORT_SYMBOL(phy_mipi_dphy_get_default_config_for_hsclk);
+
/*
* Validate D-PHY configuration according to MIPI D-PHY specification
* (v1.2, Section Section 6.9 "Global Operation Timing Parameters").
diff --git a/include/linux/phy/phy-mipi-dphy.h b/include/linux/phy/phy-mipi-dphy.h
index a877ffee845d..1ac128d78dfe 100644
--- a/include/linux/phy/phy-mipi-dphy.h
+++ b/include/linux/phy/phy-mipi-dphy.h
@@ -279,6 +279,9 @@ int phy_mipi_dphy_get_default_config(unsigned long pixel_clock,
unsigned int bpp,
unsigned int lanes,
struct phy_configure_opts_mipi_dphy *cfg);
+int phy_mipi_dphy_get_default_config_for_hsclk(unsigned long long hs_clk_rate,
+ unsigned int lanes,
+ struct phy_configure_opts_mipi_dphy *cfg);
int phy_mipi_dphy_config_validate(struct phy_configure_opts_mipi_dphy *cfg);
#endif /* __PHY_MIPI_DPHY_H_ */
--
2.30.2
next prev parent reply other threads:[~2022-09-16 13:46 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-16 13:45 [PATCH v2 0/4] Add support for Toshiba TC358746 Marco Felsch
2022-09-16 13:45 ` [PATCH v2 1/4] phy: dphy: refactor get_default_config Marco Felsch
2022-09-16 13:45 ` Marco Felsch [this message]
2022-09-16 13:45 ` [PATCH v2 3/4] media: dt-bindings: add bindings for Toshiba TC358746 Marco Felsch
2022-09-17 23:06 ` Laurent Pinchart
2022-09-19 10:08 ` Marco Felsch
2022-09-19 10:23 ` Sakari Ailus
2022-09-19 10:55 ` Laurent Pinchart
2022-09-20 15:26 ` Marco Felsch
2022-09-20 17:32 ` Laurent Pinchart
2022-09-21 7:24 ` Krzysztof Kozlowski
2022-09-21 8:35 ` Marco Felsch
2022-09-21 8:59 ` Krzysztof Kozlowski
2022-09-22 11:01 ` Marco Felsch
2022-09-22 12:09 ` Krzysztof Kozlowski
2022-09-16 13:45 ` [PATCH v2 4/4] media: tc358746: add Toshiba TC358746 Parallel to CSI-2 bridge driver Marco Felsch
2022-09-17 1:28 ` kernel test robot
2022-09-19 12:39 ` Sakari Ailus
2022-09-19 12:49 ` Laurent Pinchart
2022-09-19 13:03 ` Sakari Ailus
2022-09-20 11:35 ` Marco Felsch
2022-09-19 12:46 ` Laurent Pinchart
2022-09-19 17:11 ` Marco Felsch
2022-09-19 17:37 ` Laurent Pinchart
2022-09-19 19:54 ` Sakari Ailus
2022-09-20 8:39 ` Marco Felsch
2022-09-20 8:53 ` Sakari Ailus
2022-09-20 10:48 ` Marco Felsch
2022-09-20 11:14 ` Laurent Pinchart
2022-09-20 11:53 ` Marco Felsch
2022-09-20 12:02 ` Dave Stevenson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220916134535.128131-3-m.felsch@pengutronix.de \
--to=m.felsch@pengutronix.de \
--cc=devicetree@vger.kernel.org \
--cc=hverkuil@xs4all.nl \
--cc=jacopo@jmondi.org \
--cc=kernel@pengutronix.de \
--cc=kieran.bingham+renesas@ideasonboard.com \
--cc=kishon@ti.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=laurent.pinchart+renesas@ideasonboard.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-phy@lists.infradead.org \
--cc=mchehab@kernel.org \
--cc=robh+dt@kernel.org \
--cc=sakari.ailus@linux.intel.com \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).