From: Rob Herring <robh@kernel.org>
To: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Cc: Manivannan Sadhasivam <mani@kernel.org>,
Andy Gross <agross@kernel.org>,
Bjorn Andersson <andersson@kernel.org>,
Konrad Dybcio <konrad.dybcio@somainline.org>,
Bjorn Helgaas <bhelgaas@google.com>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
linux-pci@vger.kernel.org, linux-arm-msm@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
Subject: Re: [PATCH] dt-bindings: pci: qcom,pcie-ep: correct qcom,perst-regs
Date: Fri, 16 Sep 2022 13:47:41 -0500 [thread overview]
Message-ID: <20220916184741.GA1057850-robh@kernel.org> (raw)
In-Reply-To: <20220914014701.GA853152-robh@kernel.org>
On Tue, Sep 13, 2022 at 08:47:01PM -0500, Rob Herring wrote:
> On Tue, Sep 13, 2022 at 06:25:49PM +0200, Krzysztof Kozlowski wrote:
> > On 13/09/2022 17:20, Rob Herring wrote:
> > > On Sun, Sep 11, 2022 at 04:14:54PM +0200, Krzysztof Kozlowski wrote:
> > >> On 11/09/2022 15:55, Krzysztof Kozlowski wrote:
> > >>> qcom,perst-regs is an phandle array of one item with a phandle and its
> > >>> arguments.
> > >>>
> > >>> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> > >>> ---
> > >>> Documentation/devicetree/bindings/pci/qcom,pcie-ep.yaml | 6 ++++--
> > >>> 1 file changed, 4 insertions(+), 2 deletions(-)
> > >>>
> > >>> diff --git a/Documentation/devicetree/bindings/pci/qcom,pcie-ep.yaml b/Documentation/devicetree/bindings/pci/qcom,pcie-ep.yaml
> > >>> index 3d23599e5e91..077e002b07d3 100644
> > >>> --- a/Documentation/devicetree/bindings/pci/qcom,pcie-ep.yaml
> > >>> +++ b/Documentation/devicetree/bindings/pci/qcom,pcie-ep.yaml
> > >>> @@ -60,8 +60,10 @@ properties:
> > >>> enable registers
> > >>> $ref: "/schemas/types.yaml#/definitions/phandle-array"
> > >>> items:
> > >>> - minItems: 3
> > >>> - maxItems: 3
> > >>> + - items:
> > >>> + - description: Syscon to TCSR system registers
> > >>> + - description: Perst enable offset
> > >>> + - description: Perst separateion enable offset
> > >>
> > >> Unfortunately this still complains:
> > >>
> > >> qcom-sdx55-t55.dtb: pcie-ep@40000000: qcom,perst-regs:0: [28] is too short
> > >>
> > >>
> > >> where 28 is the phandle...
> > >
> > > Meaning the dt is wrong or there's a tooling issue?
> >
> > I think tooling issue. I looked at this many times and code (schema and
> > DTS) seems to be correct, but tool doesn't like it.
>
> Okay, I found the issue. Will test it a bit more and apply it tomorrow.
This and some other cases are now fixed. There's a new release,
v2022.09.
Rob
next prev parent reply other threads:[~2022-09-16 18:47 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-11 13:55 [PATCH] dt-bindings: pci: qcom,pcie-ep: correct qcom,perst-regs Krzysztof Kozlowski
2022-09-11 14:14 ` Krzysztof Kozlowski
2022-09-13 15:20 ` Rob Herring
2022-09-13 16:25 ` Krzysztof Kozlowski
2022-09-14 1:47 ` Rob Herring
2022-09-16 18:47 ` Rob Herring [this message]
2022-09-14 12:25 ` Manivannan Sadhasivam
2022-09-16 18:48 ` Rob Herring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220916184741.GA1057850-robh@kernel.org \
--to=robh@kernel.org \
--cc=agross@kernel.org \
--cc=andersson@kernel.org \
--cc=bhelgaas@google.com \
--cc=devicetree@vger.kernel.org \
--cc=konrad.dybcio@somainline.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=krzysztof.kozlowski@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=mani@kernel.org \
--cc=manivannan.sadhasivam@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).