Re: [PATCH v2] dt-bindings: phy: renesas,rcar-gen2-usb-phy: Convert to json-schema

[Rob Herring <robh@kernel.org>]

On Thu, 15 Sep 2022 12:12:48 +0100, Geert Uytterhoeven wrote:
> Hi Krzysztof,
> 
> On Thu, Sep 15, 2022 at 10:35 AM Krzysztof Kozlowski
> <krzysztof.kozlowski@linaro.org> wrote:>
> > On Wed, 14 Sep 2022 16:17:37 +0200, Geert Uytterhoeven wrote:
> > > Convert the Renesas R-Car Gen2 USB PHY Device Tree binding documentation
> > > to json-schema.
> > >
> > > Add missing properties.
> > > Rename the device node from "usb-phy" to "usb-phy-controller", as it
> > > does not represent a USB PHY itself, and thus does not have a
> > > "#phy-cells" property.
> > > Rename the child nodes from "usb-channel" to "usb-phy", as these do
> > > represent USB PHYs.
> > > Drop the second example, as it doesn't add any value.
> > >
> > > Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
> > > ---
> > > v2:
> > >   - Rename nodes to fix "'#phy-cells' is a required property".
> > >
> > > This is the final conversion to json-schema of DT bindings for Renesas
> > > ARM SoCs, hurray!
> > >
> > > Note that there are still a few plain text bindings left for Renesas IP
> > > cores that are present on non-Renesas SoCs (nbpfaxi and usdhi6rol0).
> > > ---
> > >  .../devicetree/bindings/phy/rcar-gen2-phy.txt | 112 ----------------
> > >  .../phy/renesas,rcar-gen2-usb-phy.yaml        | 123 ++++++++++++++++++
> > >  2 files changed, 123 insertions(+), 112 deletions(-)
> > >  delete mode 100644 Documentation/devicetree/bindings/phy/rcar-gen2-phy.txt
> > >  create mode 100644 Documentation/devicetree/bindings/phy/renesas,rcar-gen2-usb-phy.yaml
> > >
> >
> > Running 'make dtbs_check' with the schema in this patch gives the
> > following warnings. Consider if they are expected or the schema is
> > incorrect. These may not be new warnings.
> 
> These should be fixed by the DTS counterpart
> "[PATCH] ARM: dts: renesas: Fix USB PHY device and child node names"
> https://lore.kernel.org/all/6442b4042e26537abc8632c4772f8201685f1f1f.1663165098.git.geert+renesas@glider.be/>
> 
> In hindsight, I should have cross-linked the patches in both
> directions, not just in one direction. Sorry for that.
> 
> Gr{oetje,eeting}s,
> 
>                         Geert
> 
> --
> Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
> 
> In personal conversations with technical people, I call myself a hacker. But
> when I'm talking to journalists I just say "programmer" or something like that.
>                                 -- Linus Torvalds
> 
> 
> From git@z Thu Jan  1 00:00:00 1970
> Return-Path: <devicetree-owner@kernel.org>
> X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on
> 	aws-us-west-2-korg-lkml-1.web.codeaurora.org
> Received: from vger.kernel.org (vger.kernel.org [23.128.96.18])
> 	by smtp.lore.kernel.org (Postfix) with ESMTP id 70230C6FA82
> 	for <linux-devicetree@archiver.kernel.org>;
>  Wed, 14 Sep 2022 14:33:50 +0000 (UTC)
> Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
>         id S230107AbiINOds (ORCPT
>         <rfc822;linux-devicetree@archiver.kernel.org>);
>         Wed, 14 Sep 2022 10:33:48 -0400
> Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57100 "EHLO
>         lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
>         with ESMTP id S230095AbiINOdr (ORCPT
>         <rfc822;devicetree@vger.kernel.org>); Wed, 14 Sep 2022 10:33:47 -0400
> Received: from andre.telenet-ops.be (andre.telenet-ops.be
>  [IPv6:2a02:1800:120:4::f00:15])
>         by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D62BE2C125
>         for <devicetree@vger.kernel.org>;
>  Wed, 14 Sep 2022 07:33:45 -0700 (PDT)
> Received: from ramsan.of.borg ([IPv6:2a02:1810:ac12:ed50:e925:8cbe:2e99:b03b])
>         by andre.telenet-ops.be with bizsmtp
>         id KqZi2800x3vs4GX01qZilT; Wed, 14 Sep 2022 16:33:43 +0200
> Received: from rox.of.borg ([192.168.97.57])
>         by ramsan.of.borg with esmtps  (TLS1.3) tls
>  TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384
>         (Exim 4.93)
>         (envelope-from <geert@linux-m68k.org>)
>         id 1oYTSQ-005B5L-8B; Wed, 14 Sep 2022 16:33:42 +0200
> Received: from geert by rox.of.borg with local (Exim 4.93)
>         (envelope-from <geert@linux-m68k.org>)
>         id 1oYTD1-000z8A-UK; Wed, 14 Sep 2022 16:17:47 +0200
> From: Geert Uytterhoeven <geert+renesas@glider.be>
> To: Kishon Vijay Abraham I <kishon@ti.com>,
>         Vinod Koul <vkoul@kernel.org>,
>         Rob Herring <robh+dt@kernel.org>,
>         Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
>         Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>
> Cc: linux-phy@lists.infradead.org, devicetree@vger.kernel.org,
>         linux-renesas-soc@vger.kernel.org,
>         Geert Uytterhoeven <geert+renesas@glider.be>
> Subject: [PATCH v2] dt-bindings: phy: renesas,rcar-gen2-usb-phy: Convert to
>  json-schema
> Date: Wed, 14 Sep 2022 16:17:37 +0200
> Message-Id:
>  <dbdcffd009302734fe2fb895ce04b72fa1ea4355.1663165000.git.geert+renesas@glider.be>
> X-Mailer: git-send-email 2.25.1
> MIME-Version: 1.0
> Content-Transfer-Encoding: 8bit
> Precedence: bulk
> List-ID: <devicetree.vger.kernel.org>
> X-Mailing-List: devicetree@vger.kernel.org
> 
> Convert the Renesas R-Car Gen2 USB PHY Device Tree binding documentation
> to json-schema.
> 
> Add missing properties.
> Rename the device node from "usb-phy" to "usb-phy-controller", as it
> does not represent a USB PHY itself, and thus does not have a
> "#phy-cells" property.
> Rename the child nodes from "usb-channel" to "usb-phy", as these do
> represent USB PHYs.
> Drop the second example, as it doesn't add any value.
> 
> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
> ---
> v2:
>   - Rename nodes to fix "'#phy-cells' is a required property".
> 
> This is the final conversion to json-schema of DT bindings for Renesas
> ARM SoCs, hurray!
> 
> Note that there are still a few plain text bindings left for Renesas IP
> cores that are present on non-Renesas SoCs (nbpfaxi and usdhi6rol0).
> ---
>  .../devicetree/bindings/phy/rcar-gen2-phy.txt | 112 ----------------
>  .../phy/renesas,rcar-gen2-usb-phy.yaml        | 123 ++++++++++++++++++
>  2 files changed, 123 insertions(+), 112 deletions(-)
>  delete mode 100644 Documentation/devicetree/bindings/phy/rcar-gen2-phy.txt
>  create mode 100644 Documentation/devicetree/bindings/phy/renesas,rcar-gen2-usb-phy.yaml
> 

Reviewed-by: Rob Herring <robh@kernel.org>