From: Daniel Walker <danielwa@cisco.com>
To: Frank Rowand <frowand.list@gmail.com>
Cc: Pantelis Antoniou <pantelis.antoniou@konsulko.com>,
Rob Herring <robh+dt@kernel.org>,
xe-linux-external@cisco.com, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] driver: of: overlay: demote message to warning
Date: Fri, 16 Sep 2022 20:26:10 -0700 [thread overview]
Message-ID: <20220917032610.GM4320@zorba> (raw)
In-Reply-To: <b6a43df4-e5d8-06d2-a6b9-3626f2677161@gmail.com>
On Fri, Sep 16, 2022 at 09:47:19PM -0500, Frank Rowand wrote:
> On 9/16/22 17:56, Daniel Walker wrote:
> > On Fri, Sep 16, 2022 at 05:47:54PM -0500, Frank Rowand wrote:
> >>>
> >>> Maybe you could add a flag or other indicator which would indicate the overlay will never be
> >>> removed. Then your code could rely on this property to inform on if the author
> >>> has consider the removal issues related to overlays.
> >>
> >> No. I guess I wasn't clear enough above, where I said:
> >>
> >> "And I will not accept a
> >> change that suppresses the message if there is no expectation to remove the
> >> overlay."
> >>
> >> There are multiple reasons for this, but the most fundamental is that if a
> >> new overlay is not removable, then any overlay already applied can not be
> >> removed (because overlays must be removed in the reverse order that they
> >> are applied). It would be incredibly bad architecture to allow an overlay
> >> to block another overlay from being removed.
> >
> > So how about an option to turn off removable overlays entirely? As far as I can
> > tell it's not used currently by the tiny number of implementation I've seen.
> >
> > Cisco doesn't need it, and we could have a smaller kernel without it.
> >
> > The issue is that the error log on blast is log level abuse in my opinion. If
> > there's no way to fix it, it should not be an error.
>
> The way to fix it is to not have a construct in the overlay that triggers the
> message. In other words, do not add a property to a pre-existing node. (At
> least I think that is what is the underlying cause, if I recall correctly.)
>
> -Frank
Here's the check,
if (!of_node_check_flag(target->np, OF_OVERLAY))
If the print shows when the modifications is made to a non-overlay, I'm not
sure how you could construct a device tree where you only modify other overlays.
It seems like this should print on the vast majority of overlays.
Daniel
next prev parent reply other threads:[~2022-09-17 3:26 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-07 23:07 [PATCH] driver: of: overlay: demote message to warning Daniel Walker
2022-09-07 23:54 ` Frank Rowand
2022-09-08 0:35 ` Daniel Walker
2022-09-08 17:55 ` Frank Rowand
2022-09-12 6:45 ` Frank Rowand
2022-09-12 17:05 ` Daniel Walker
2022-09-12 20:32 ` Frank Rowand
2022-09-13 0:51 ` Daniel Walker
2022-09-16 22:47 ` Frank Rowand
2022-09-16 22:56 ` Daniel Walker
2022-09-17 2:47 ` Frank Rowand
2022-09-17 3:26 ` Daniel Walker [this message]
2022-09-26 22:29 ` Rob Herring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220917032610.GM4320@zorba \
--to=danielwa@cisco.com \
--cc=devicetree@vger.kernel.org \
--cc=frowand.list@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=pantelis.antoniou@konsulko.com \
--cc=robh+dt@kernel.org \
--cc=xe-linux-external@cisco.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).