From: Asmaa Mnebhi <asmaa@nvidia.com>
To: Wolfram Sang <wsa+renesas@sang-engineering.com>,
robh@kernel.org, linux-i2c@vger.kernel.org,
linux-kernel@vger.kernel.org, devicetree@vger.kernel.org
Cc: Asmaa Mnebhi <asmaa@nvidia.com>, Khalil Blaiech <kblaiech@nvidia.com>
Subject: [PATCH v4 8/8] i2c: i2c-mlxbf.c: Update binding devicetree
Date: Mon, 19 Sep 2022 17:34:31 -0400 [thread overview]
Message-ID: <20220919213431.8045-9-asmaa@nvidia.com> (raw)
In-Reply-To: <20220919213431.8045-1-asmaa@nvidia.com>
In the latest version of the i2c-mlxbf.c driver, the "Smbus block"
resource was broken down to 3 separate resources "Smbus timer",
"Smbus master" and "Smbus slave" to accommodate for BlueField-3
SoC registers' changes.
Reviewed-by: Khalil Blaiech <kblaiech@nvidia.com>
Signed-off-by: Asmaa Mnebhi <asmaa@nvidia.com>
---
.../bindings/i2c/mellanox,i2c-mlxbf.yaml | 49 ++++++++++++++-----
1 file changed, 37 insertions(+), 12 deletions(-)
diff --git a/Documentation/devicetree/bindings/i2c/mellanox,i2c-mlxbf.yaml b/Documentation/devicetree/bindings/i2c/mellanox,i2c-mlxbf.yaml
index 93198d5d43a6..12dbe7e7967e 100644
--- a/Documentation/devicetree/bindings/i2c/mellanox,i2c-mlxbf.yaml
+++ b/Documentation/devicetree/bindings/i2c/mellanox,i2c-mlxbf.yaml
@@ -8,6 +8,7 @@ title: Mellanox I2C SMBus on BlueField SoCs
maintainers:
- Khalil Blaiech <kblaiech@nvidia.com>
+ - Asmaa Mnebhi <asmaa@nvidia.com>
allOf:
- $ref: /schemas/i2c/i2c-controller.yaml#
@@ -17,14 +18,19 @@ properties:
enum:
- mellanox,i2c-mlxbf1
- mellanox,i2c-mlxbf2
+ - mellanox,i2c-mlxbf3
reg:
minItems: 3
+ maxItems: 6
items:
- description: Smbus block registers
- description: Cause master registers
- description: Cause slave registers
- description: Cause coalesce registers
+ - description: Smbus timer registers
+ - description: Smbus master registers
+ - description: Smbus slave registers
interrupts:
maxItems: 1
@@ -35,6 +41,13 @@ properties:
bus frequency used to configure timing registers;
The frequency is expressed in Hz. Default is 100000.
+ resource_version:
+ enum: [ 0, 1 ]
+ description:
+ Version of the device tree. resource_version = 0 when the driver uses
+ Smbus block resource. resource_version = 1 when the driver uses Smbus
+ timer, Smbus master and Smbus slave resources.
+
required:
- compatible
- reg
@@ -42,18 +55,6 @@ required:
unevaluatedProperties: false
-if:
- properties:
- compatible:
- contains:
- enum:
- - mellanox,i2c-mlxbf1
-
-then:
- properties:
- reg:
- maxItems: 3
-
examples:
- |
i2c@2804000 {
@@ -61,8 +62,13 @@ examples:
reg = <0x02804000 0x800>,
<0x02801200 0x020>,
<0x02801260 0x020>;
+ <0x00000001 0x1>;
+ <0x02804000 0x40>,
+ <0x02804200 0x200>,
+ <0x02804400 0x200>,
interrupts = <57>;
clock-frequency = <100000>;
+ resource_version = <1>;
};
- |
@@ -72,6 +78,25 @@ examples:
<0x02808e00 0x020>,
<0x02808e20 0x020>,
<0x02808e40 0x010>;
+ <0x02808800 0x040>;
+ <0x02808a00 0x200>,
+ <0x02808c00 0x200>,
interrupts = <57>;
clock-frequency = <400000>;
+ resource_version = <1>;
+ };
+
+ - |
+ i2c@2808800 {
+ compatible = "mellanox,i2c-mlxbf3";
+ reg = <0x00000001 0x1>,
+ <0x13404400 0x020>,
+ <0x13404420 0x020>,
+ <0x13404440 0x010>;
+ <0x13404480 0x40>,
+ <0x13404200 0x200>,
+ <0x13404000 0x200>,
+ interrupts = <35>;
+ clock-frequency = <400000>;
+ resource_version = <1>;
};
--
2.30.1
next prev parent reply other threads:[~2022-09-19 21:41 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-19 21:34 [PATCH v4 0/8] i2c: i2c-mlxbf.c: bug fixes and new feature support Asmaa Mnebhi
2022-09-19 21:34 ` Asmaa Mnebhi [this message]
2022-09-20 8:18 ` [PATCH v4 8/8] i2c: i2c-mlxbf.c: Update binding devicetree Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220919213431.8045-9-asmaa@nvidia.com \
--to=asmaa@nvidia.com \
--cc=devicetree@vger.kernel.org \
--cc=kblaiech@nvidia.com \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh@kernel.org \
--cc=wsa+renesas@sang-engineering.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).