* [PATCH 0/2] SDM670 RPMh Clocks (real)
@ 2022-09-20 2:37 Richard Acayan
2022-09-20 2:37 ` [PATCH 1/2] dt-bindings: clock: add rpmhcc bindings for sdm670 Richard Acayan
2022-09-20 2:37 ` [PATCH 2/2] clk: qcom: rpmhcc: add sdm670 clocks Richard Acayan
0 siblings, 2 replies; 6+ messages in thread
From: Richard Acayan @ 2022-09-20 2:37 UTC (permalink / raw)
To: linux-arm-msm
Cc: Bjorn Andersson, Andy Gross, Konrad Dybcio, Michael Turquette,
Stephen Boyd, Rob Herring, Krzysztof Kozlowski, Taniya Das,
linux-clk, devicetree
This patch series adds clocks controlled by RPMh for Snapdragon 670.
Note that these patches add the actual clocks, and is not a duplicate of
the regulators series which I mislabeled by accident.
.../devicetree/bindings/clock/qcom,rpmhcc.yaml | 1 +
drivers/clk/qcom/clk-rpmh.c | 21 +++++++++++++++++++++
2 files changed, 22 insertions(+)
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH 1/2] dt-bindings: clock: add rpmhcc bindings for sdm670
2022-09-20 2:37 [PATCH 0/2] SDM670 RPMh Clocks (real) Richard Acayan
@ 2022-09-20 2:37 ` Richard Acayan
2022-09-20 8:29 ` Krzysztof Kozlowski
2022-09-20 2:37 ` [PATCH 2/2] clk: qcom: rpmhcc: add sdm670 clocks Richard Acayan
1 sibling, 1 reply; 6+ messages in thread
From: Richard Acayan @ 2022-09-20 2:37 UTC (permalink / raw)
To: linux-arm-msm
Cc: Bjorn Andersson, Andy Gross, Konrad Dybcio, Michael Turquette,
Stephen Boyd, Rob Herring, Krzysztof Kozlowski, Taniya Das,
linux-clk, devicetree
The Snapdragon 670 uses the RPMh mailbox for some clocks. Document its
support.
Signed-off-by: Richard Acayan <mailingradian@gmail.com>
---
Documentation/devicetree/bindings/clock/qcom,rpmhcc.yaml | 1 +
1 file changed, 1 insertion(+)
diff --git a/Documentation/devicetree/bindings/clock/qcom,rpmhcc.yaml b/Documentation/devicetree/bindings/clock/qcom,rpmhcc.yaml
index 8fcaf418f84a..437a34b930e3 100644
--- a/Documentation/devicetree/bindings/clock/qcom,rpmhcc.yaml
+++ b/Documentation/devicetree/bindings/clock/qcom,rpmhcc.yaml
@@ -21,6 +21,7 @@ properties:
- qcom,sc7280-rpmh-clk
- qcom,sc8180x-rpmh-clk
- qcom,sc8280xp-rpmh-clk
+ - qcom,sdm670-rpmh-clk
- qcom,sdm845-rpmh-clk
- qcom,sdx55-rpmh-clk
- qcom,sdx65-rpmh-clk
--
2.37.3
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [PATCH 2/2] clk: qcom: rpmhcc: add sdm670 clocks
2022-09-20 2:37 [PATCH 0/2] SDM670 RPMh Clocks (real) Richard Acayan
2022-09-20 2:37 ` [PATCH 1/2] dt-bindings: clock: add rpmhcc bindings for sdm670 Richard Acayan
@ 2022-09-20 2:37 ` Richard Acayan
2022-09-20 8:29 ` Krzysztof Kozlowski
2022-09-20 22:51 ` Konrad Dybcio
1 sibling, 2 replies; 6+ messages in thread
From: Richard Acayan @ 2022-09-20 2:37 UTC (permalink / raw)
To: linux-arm-msm
Cc: Bjorn Andersson, Andy Gross, Konrad Dybcio, Michael Turquette,
Stephen Boyd, Rob Herring, Krzysztof Kozlowski, Taniya Das,
linux-clk, devicetree
The Snapdragon 670 uses the RPMh mailbox for most of the clocks used in
SDM845 but omits two. Add clock data for SDM670 so the driver doesn't fail
to resolve a clock.
Link: https://android.googlesource.com/kernel/msm/+/444bd8d6e2cf54698234c752e6de97b4b8a528bd%5E%21/#F7
Signed-off-by: Richard Acayan <mailingradian@gmail.com>
---
drivers/clk/qcom/clk-rpmh.c | 21 +++++++++++++++++++++
1 file changed, 21 insertions(+)
diff --git a/drivers/clk/qcom/clk-rpmh.c b/drivers/clk/qcom/clk-rpmh.c
index 9739aab0fe82..0471bab82464 100644
--- a/drivers/clk/qcom/clk-rpmh.c
+++ b/drivers/clk/qcom/clk-rpmh.c
@@ -378,6 +378,26 @@ static const struct clk_rpmh_desc clk_rpmh_sdm845 = {
.num_clks = ARRAY_SIZE(sdm845_rpmh_clocks),
};
+static struct clk_hw *sdm670_rpmh_clocks[] = {
+ [RPMH_CXO_CLK] = &sdm845_bi_tcxo.hw,
+ [RPMH_CXO_CLK_A] = &sdm845_bi_tcxo_ao.hw,
+ [RPMH_LN_BB_CLK2] = &sdm845_ln_bb_clk2.hw,
+ [RPMH_LN_BB_CLK2_A] = &sdm845_ln_bb_clk2_ao.hw,
+ [RPMH_LN_BB_CLK3] = &sdm845_ln_bb_clk3.hw,
+ [RPMH_LN_BB_CLK3_A] = &sdm845_ln_bb_clk3_ao.hw,
+ [RPMH_RF_CLK1] = &sdm845_rf_clk1.hw,
+ [RPMH_RF_CLK1_A] = &sdm845_rf_clk1_ao.hw,
+ [RPMH_RF_CLK2] = &sdm845_rf_clk2.hw,
+ [RPMH_RF_CLK2_A] = &sdm845_rf_clk2_ao.hw,
+ [RPMH_IPA_CLK] = &sdm845_ipa.hw,
+ [RPMH_CE_CLK] = &sdm845_ce.hw,
+};
+
+static const struct clk_rpmh_desc clk_rpmh_sdm670 = {
+ .clks = sdm670_rpmh_clocks,
+ .num_clks = ARRAY_SIZE(sdm670_rpmh_clocks),
+};
+
DEFINE_CLK_RPMH_VRM(sdx55, rf_clk1, rf_clk1_ao, "rfclkd1", 1);
DEFINE_CLK_RPMH_VRM(sdx55, rf_clk2, rf_clk2_ao, "rfclkd2", 1);
DEFINE_CLK_RPMH_BCM(sdx55, qpic_clk, "QP0");
@@ -711,6 +731,7 @@ static const struct of_device_id clk_rpmh_match_table[] = {
{ .compatible = "qcom,sc8180x-rpmh-clk", .data = &clk_rpmh_sc8180x},
{ .compatible = "qcom,sc8280xp-rpmh-clk", .data = &clk_rpmh_sc8280xp},
{ .compatible = "qcom,sdm845-rpmh-clk", .data = &clk_rpmh_sdm845},
+ { .compatible = "qcom,sdm670-rpmh-clk", .data = &clk_rpmh_sdm670},
{ .compatible = "qcom,sdx55-rpmh-clk", .data = &clk_rpmh_sdx55},
{ .compatible = "qcom,sdx65-rpmh-clk", .data = &clk_rpmh_sdx65},
{ .compatible = "qcom,sm6350-rpmh-clk", .data = &clk_rpmh_sm6350},
--
2.37.3
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH 1/2] dt-bindings: clock: add rpmhcc bindings for sdm670
2022-09-20 2:37 ` [PATCH 1/2] dt-bindings: clock: add rpmhcc bindings for sdm670 Richard Acayan
@ 2022-09-20 8:29 ` Krzysztof Kozlowski
0 siblings, 0 replies; 6+ messages in thread
From: Krzysztof Kozlowski @ 2022-09-20 8:29 UTC (permalink / raw)
To: Richard Acayan, linux-arm-msm
Cc: Bjorn Andersson, Andy Gross, Konrad Dybcio, Michael Turquette,
Stephen Boyd, Rob Herring, Krzysztof Kozlowski, Taniya Das,
linux-clk, devicetree
On 20/09/2022 04:37, Richard Acayan wrote:
> The Snapdragon 670 uses the RPMh mailbox for some clocks. Document its
> support.
>
> Signed-off-by: Richard Acayan <mailingradian@gmail.com>
> ---
> Documentation/devicetree/bindings/clock/qcom,rpmhcc.yaml | 1 +
Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH 2/2] clk: qcom: rpmhcc: add sdm670 clocks
2022-09-20 2:37 ` [PATCH 2/2] clk: qcom: rpmhcc: add sdm670 clocks Richard Acayan
@ 2022-09-20 8:29 ` Krzysztof Kozlowski
2022-09-20 22:51 ` Konrad Dybcio
1 sibling, 0 replies; 6+ messages in thread
From: Krzysztof Kozlowski @ 2022-09-20 8:29 UTC (permalink / raw)
To: Richard Acayan, linux-arm-msm
Cc: Bjorn Andersson, Andy Gross, Konrad Dybcio, Michael Turquette,
Stephen Boyd, Rob Herring, Krzysztof Kozlowski, Taniya Das,
linux-clk, devicetree
On 20/09/2022 04:37, Richard Acayan wrote:
> The Snapdragon 670 uses the RPMh mailbox for most of the clocks used in
> SDM845 but omits two. Add clock data for SDM670 so the driver doesn't fail
> to resolve a clock.
>
> Link: https://android.googlesource.com/kernel/msm/+/444bd8d6e2cf54698234c752e6de97b4b8a528bd%5E%21/#F7
NOT_FOUND: Requested entity was not found
Do not add non-working links.
> Signed-off-by: Richard Acayan <mailingradian@gmail.com>
> ---
> drivers/clk/qcom/clk-rpmh.c | 21 +++++++++++++++++++++
> 1 file changed, 21 insertions(+)
>
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH 2/2] clk: qcom: rpmhcc: add sdm670 clocks
2022-09-20 2:37 ` [PATCH 2/2] clk: qcom: rpmhcc: add sdm670 clocks Richard Acayan
2022-09-20 8:29 ` Krzysztof Kozlowski
@ 2022-09-20 22:51 ` Konrad Dybcio
1 sibling, 0 replies; 6+ messages in thread
From: Konrad Dybcio @ 2022-09-20 22:51 UTC (permalink / raw)
To: Richard Acayan, linux-arm-msm
Cc: Bjorn Andersson, Andy Gross, Michael Turquette, Stephen Boyd,
Rob Herring, Krzysztof Kozlowski, Taniya Das, linux-clk,
devicetree
On 20.09.2022 04:37, Richard Acayan wrote:
> The Snapdragon 670 uses the RPMh mailbox for most of the clocks used in
> SDM845 but omits two. Add clock data for SDM670 so the driver doesn't fail
> to resolve a clock.
>
> Link: https://android.googlesource.com/kernel/msm/+/444bd8d6e2cf54698234c752e6de97b4b8a528bd%5E%21/#F7
> Signed-off-by: Richard Acayan <mailingradian@gmail.com>
> ---
Reviewed-by: Konrad Dybcio <konrad.dybcio@somainline.org>
Konrad
> drivers/clk/qcom/clk-rpmh.c | 21 +++++++++++++++++++++
> 1 file changed, 21 insertions(+)
>
> diff --git a/drivers/clk/qcom/clk-rpmh.c b/drivers/clk/qcom/clk-rpmh.c
> index 9739aab0fe82..0471bab82464 100644
> --- a/drivers/clk/qcom/clk-rpmh.c
> +++ b/drivers/clk/qcom/clk-rpmh.c
> @@ -378,6 +378,26 @@ static const struct clk_rpmh_desc clk_rpmh_sdm845 = {
> .num_clks = ARRAY_SIZE(sdm845_rpmh_clocks),
> };
>
> +static struct clk_hw *sdm670_rpmh_clocks[] = {
> + [RPMH_CXO_CLK] = &sdm845_bi_tcxo.hw,
> + [RPMH_CXO_CLK_A] = &sdm845_bi_tcxo_ao.hw,
> + [RPMH_LN_BB_CLK2] = &sdm845_ln_bb_clk2.hw,
> + [RPMH_LN_BB_CLK2_A] = &sdm845_ln_bb_clk2_ao.hw,
> + [RPMH_LN_BB_CLK3] = &sdm845_ln_bb_clk3.hw,
> + [RPMH_LN_BB_CLK3_A] = &sdm845_ln_bb_clk3_ao.hw,
> + [RPMH_RF_CLK1] = &sdm845_rf_clk1.hw,
> + [RPMH_RF_CLK1_A] = &sdm845_rf_clk1_ao.hw,
> + [RPMH_RF_CLK2] = &sdm845_rf_clk2.hw,
> + [RPMH_RF_CLK2_A] = &sdm845_rf_clk2_ao.hw,
> + [RPMH_IPA_CLK] = &sdm845_ipa.hw,
> + [RPMH_CE_CLK] = &sdm845_ce.hw,
> +};
> +
> +static const struct clk_rpmh_desc clk_rpmh_sdm670 = {
> + .clks = sdm670_rpmh_clocks,
> + .num_clks = ARRAY_SIZE(sdm670_rpmh_clocks),
> +};
> +
> DEFINE_CLK_RPMH_VRM(sdx55, rf_clk1, rf_clk1_ao, "rfclkd1", 1);
> DEFINE_CLK_RPMH_VRM(sdx55, rf_clk2, rf_clk2_ao, "rfclkd2", 1);
> DEFINE_CLK_RPMH_BCM(sdx55, qpic_clk, "QP0");
> @@ -711,6 +731,7 @@ static const struct of_device_id clk_rpmh_match_table[] = {
> { .compatible = "qcom,sc8180x-rpmh-clk", .data = &clk_rpmh_sc8180x},
> { .compatible = "qcom,sc8280xp-rpmh-clk", .data = &clk_rpmh_sc8280xp},
> { .compatible = "qcom,sdm845-rpmh-clk", .data = &clk_rpmh_sdm845},
> + { .compatible = "qcom,sdm670-rpmh-clk", .data = &clk_rpmh_sdm670},
> { .compatible = "qcom,sdx55-rpmh-clk", .data = &clk_rpmh_sdx55},
> { .compatible = "qcom,sdx65-rpmh-clk", .data = &clk_rpmh_sdx65},
> { .compatible = "qcom,sm6350-rpmh-clk", .data = &clk_rpmh_sm6350},
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2022-09-20 22:51 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-09-20 2:37 [PATCH 0/2] SDM670 RPMh Clocks (real) Richard Acayan
2022-09-20 2:37 ` [PATCH 1/2] dt-bindings: clock: add rpmhcc bindings for sdm670 Richard Acayan
2022-09-20 8:29 ` Krzysztof Kozlowski
2022-09-20 2:37 ` [PATCH 2/2] clk: qcom: rpmhcc: add sdm670 clocks Richard Acayan
2022-09-20 8:29 ` Krzysztof Kozlowski
2022-09-20 22:51 ` Konrad Dybcio
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).