From: Jakub Kicinski <kuba@kernel.org>
To: andrei.tachici@stud.acs.upb.ro
Cc: linux-kernel@vger.kernel.org, andrew@lunn.ch,
hkallweit1@gmail.com, linux@armlinux.org.uk, davem@davemloft.net,
edumazet@google.com, pabeni@redhat.com, netdev@vger.kernel.org,
vegard.nossum@oracle.com, joel@jms.id.au, l.stelmach@samsung.com,
robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org,
devicetree@vger.kernel.org
Subject: Re: [net-next v8 2/3] net: ethernet: adi: Add ADIN1110 support
Date: Tue, 20 Sep 2022 08:29:05 -0700 [thread overview]
Message-ID: <20220920082905.63adec9a@kernel.org> (raw)
In-Reply-To: <20220913122629.124546-3-andrei.tachici@stud.acs.upb.ro>
On Tue, 13 Sep 2022 15:26:28 +0300 andrei.tachici@stud.acs.upb.ro wrote:
> +static int adin1110_port_get_port_parent_id(struct net_device *dev,
> + struct netdev_phys_item_id *ppid)
> +{
> + struct adin1110_port_priv *port_priv = netdev_priv(dev);
> + struct adin1110_priv *priv = port_priv->priv;
> +
> + ppid->id_len = strnlen(priv->mii_bus_name, MII_BUS_ID_SIZE);
> + memcpy(ppid->id, priv->mii_bus_name, ppid->id_len);
gcc 8.5 complains about overflow here, MII_BUS_ID_SIZE is larger
than MAX_PHYS_ITEM_ID_LEN, i.e. the length of ppid->id.
Please fix this up, the build bots are gonna get angry.
next prev parent reply other threads:[~2022-09-20 15:29 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-13 12:26 [net-next v8 0/3] net: ethernet: adi: Add ADIN1110 support andrei.tachici
2022-09-13 12:26 ` [net-next v8 1/3] net: phy: adin1100: add PHY IDs of adin1110/adin2111 andrei.tachici
2022-09-13 12:26 ` [net-next v8 2/3] net: ethernet: adi: Add ADIN1110 support andrei.tachici
2022-09-20 15:29 ` Jakub Kicinski [this message]
2022-09-13 12:26 ` [net-next v8 3/3] dt-bindings: net: adin1110: Add docs andrei.tachici
2022-09-20 13:20 ` [net-next v8 0/3] net: ethernet: adi: Add ADIN1110 support patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220920082905.63adec9a@kernel.org \
--to=kuba@kernel.org \
--cc=andrei.tachici@stud.acs.upb.ro \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=edumazet@google.com \
--cc=hkallweit1@gmail.com \
--cc=joel@jms.id.au \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=l.stelmach@samsung.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=robh+dt@kernel.org \
--cc=vegard.nossum@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).