* [PATCH v2 0/2] Mediatek ethernet patches for mt8188
@ 2022-09-20 8:36 Jianguo Zhang
2022-09-20 8:36 ` [PATCH 1/2] dt-bindings: net: mediatek-dwmac: add support " Jianguo Zhang
2022-09-20 8:36 ` [PATCH 2/2] dt-bindings: net: snps,dwmac: add clk_csr property Jianguo Zhang
0 siblings, 2 replies; 7+ messages in thread
From: Jianguo Zhang @ 2022-09-20 8:36 UTC (permalink / raw)
To: David S . Miller, Rob Herring, Krzysztof Kozlowski
Cc: Eric Dumazet, Jakub Kicinski, Paolo Abeni, Giuseppe Cavallaro,
Alexandre Torgue, Jose Abreu, Maxime Coquelin, Matthias Brugger,
Biao Huang, netdev, devicetree, linux-kernel, linux-stm32,
linux-arm-kernel, linux-mediatek, Jianguo Zhang
Changes in v2:
v2:
1) Delete patch 'stmmac: dwmac-mediatek: add support for mt8188' as
Krzysztof Kozlowski's comment.
2) Update patch 'dt-bindings: net: mediatek-dwmac: add support for
mt8188' as Krzysztof Kozlowski's comment.
3) Add clk_csr property to fix warning ('clk_csr' was unexpected)
reported by running 'make dtbs_check'.
v1:
1) Add ethernet driver entry for mt8188.
2) Add binding document for ethernet on mt8188.
^ permalink raw reply [flat|nested] 7+ messages in thread* [PATCH 1/2] dt-bindings: net: mediatek-dwmac: add support for mt8188 2022-09-20 8:36 [PATCH v2 0/2] Mediatek ethernet patches for mt8188 Jianguo Zhang @ 2022-09-20 8:36 ` Jianguo Zhang 2022-09-20 13:22 ` AngeloGioacchino Del Regno 2022-09-20 15:26 ` Krzysztof Kozlowski 2022-09-20 8:36 ` [PATCH 2/2] dt-bindings: net: snps,dwmac: add clk_csr property Jianguo Zhang 1 sibling, 2 replies; 7+ messages in thread From: Jianguo Zhang @ 2022-09-20 8:36 UTC (permalink / raw) To: David S . Miller, Rob Herring, Krzysztof Kozlowski Cc: Eric Dumazet, Jakub Kicinski, Paolo Abeni, Giuseppe Cavallaro, Alexandre Torgue, Jose Abreu, Maxime Coquelin, Matthias Brugger, Biao Huang, netdev, devicetree, linux-kernel, linux-stm32, linux-arm-kernel, linux-mediatek, Jianguo Zhang Add binding document for the ethernet on mt8188 Signed-off-by: Jianguo Zhang <jianguo.zhang@mediatek.com> --- .../devicetree/bindings/net/mediatek-dwmac.yaml | 10 ++++++++-- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/Documentation/devicetree/bindings/net/mediatek-dwmac.yaml b/Documentation/devicetree/bindings/net/mediatek-dwmac.yaml index 61b2fb9e141b..eaf7e8d53432 100644 --- a/Documentation/devicetree/bindings/net/mediatek-dwmac.yaml +++ b/Documentation/devicetree/bindings/net/mediatek-dwmac.yaml @@ -20,6 +20,7 @@ select: enum: - mediatek,mt2712-gmac - mediatek,mt8195-gmac + - mediatek,mt8188-gmac required: - compatible @@ -37,6 +38,11 @@ properties: - enum: - mediatek,mt8195-gmac - const: snps,dwmac-5.10a + - items: + - enum: + - mediatek,mt8188-gmac + - const: mediatek,mt8195-gmac + - const: snps,dwmac-5.10a clocks: minItems: 5 @@ -74,7 +80,7 @@ properties: or will round down. Range 0~31*170. For MT2712 RMII/MII interface, Allowed value need to be a multiple of 550, or will round down. Range 0~31*550. - For MT8195 RGMII/RMII/MII interface, Allowed value need to be a multiple of 290, + For MT8195/MT8188 RGMII/RMII/MII interface, Allowed value need to be a multiple of 290, or will round down. Range 0~31*290. mediatek,rx-delay-ps: @@ -84,7 +90,7 @@ properties: or will round down. Range 0~31*170. For MT2712 RMII/MII interface, Allowed value need to be a multiple of 550, or will round down. Range 0~31*550. - For MT8195 RGMII/RMII/MII interface, Allowed value need to be a multiple + For MT8195/MT8188 RGMII/RMII/MII interface, Allowed value need to be a multiple of 290, or will round down. Range 0~31*290. mediatek,rmii-rxc: -- 2.25.1 ^ permalink raw reply related [flat|nested] 7+ messages in thread
* Re: [PATCH 1/2] dt-bindings: net: mediatek-dwmac: add support for mt8188 2022-09-20 8:36 ` [PATCH 1/2] dt-bindings: net: mediatek-dwmac: add support " Jianguo Zhang @ 2022-09-20 13:22 ` AngeloGioacchino Del Regno 2022-09-21 1:14 ` Jianguo Zhang 2022-09-20 15:26 ` Krzysztof Kozlowski 1 sibling, 1 reply; 7+ messages in thread From: AngeloGioacchino Del Regno @ 2022-09-20 13:22 UTC (permalink / raw) To: Jianguo Zhang, David S . Miller, Rob Herring, Krzysztof Kozlowski Cc: Eric Dumazet, Jakub Kicinski, Paolo Abeni, Giuseppe Cavallaro, Alexandre Torgue, Jose Abreu, Maxime Coquelin, Matthias Brugger, Biao Huang, netdev, devicetree, linux-kernel, linux-stm32, linux-arm-kernel, linux-mediatek Il 20/09/22 10:36, Jianguo Zhang ha scritto: > Add binding document for the ethernet on mt8188 > > Signed-off-by: Jianguo Zhang <jianguo.zhang@mediatek.com> > --- > .../devicetree/bindings/net/mediatek-dwmac.yaml | 10 ++++++++-- > 1 file changed, 8 insertions(+), 2 deletions(-) > > diff --git a/Documentation/devicetree/bindings/net/mediatek-dwmac.yaml b/Documentation/devicetree/bindings/net/mediatek-dwmac.yaml > index 61b2fb9e141b..eaf7e8d53432 100644 > --- a/Documentation/devicetree/bindings/net/mediatek-dwmac.yaml > +++ b/Documentation/devicetree/bindings/net/mediatek-dwmac.yaml > @@ -20,6 +20,7 @@ select: > enum: > - mediatek,mt2712-gmac Please keep the list ordered by name. MT8188 goes before 8195. > - mediatek,mt8195-gmac > + - mediatek,mt8188-gmac > required: > - compatible > > @@ -37,6 +38,11 @@ properties: > - enum: > - mediatek,mt8195-gmac > - const: snps,dwmac-5.10a > + - items: > + - enum: > + - mediatek,mt8188-gmac > + - const: mediatek,mt8195-gmac > + - const: snps,dwmac-5.10a > > clocks: > minItems: 5 > @@ -74,7 +80,7 @@ properties: > or will round down. Range 0~31*170. > For MT2712 RMII/MII interface, Allowed value need to be a multiple of 550, > or will round down. Range 0~31*550. > - For MT8195 RGMII/RMII/MII interface, Allowed value need to be a multiple of 290, > + For MT8195/MT8188 RGMII/RMII/MII interface, Allowed value need to be a multiple of 290, For MT8188/MT8195 > or will round down. Range 0~31*290. > > mediatek,rx-delay-ps: > @@ -84,7 +90,7 @@ properties: > or will round down. Range 0~31*170. > For MT2712 RMII/MII interface, Allowed value need to be a multiple of 550, > or will round down. Range 0~31*550. > - For MT8195 RGMII/RMII/MII interface, Allowed value need to be a multiple > + For MT8195/MT8188 RGMII/RMII/MII interface, Allowed value need to be a multiple For MT8188/MT8195 > of 290, or will round down. Range 0~31*290. > > mediatek,rmii-rxc: ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH 1/2] dt-bindings: net: mediatek-dwmac: add support for mt8188 2022-09-20 13:22 ` AngeloGioacchino Del Regno @ 2022-09-21 1:14 ` Jianguo Zhang 0 siblings, 0 replies; 7+ messages in thread From: Jianguo Zhang @ 2022-09-21 1:14 UTC (permalink / raw) To: AngeloGioacchino Del Regno, David S . Miller, Rob Herring, Krzysztof Kozlowski Cc: Eric Dumazet, Jakub Kicinski, Paolo Abeni, Giuseppe Cavallaro, Alexandre Torgue, Jose Abreu, Maxime Coquelin, Matthias Brugger, Biao Huang, netdev, devicetree, linux-kernel, linux-stm32, linux-arm-kernel, linux-mediatek Dear AngeloGioacchino Thanks for your comment. On Tue, 2022-09-20 at 15:22 +0200, AngeloGioacchino Del Regno wrote: > Il 20/09/22 10:36, Jianguo Zhang ha scritto: > > Add binding document for the ethernet on mt8188 > > > > Signed-off-by: Jianguo Zhang <jianguo.zhang@mediatek.com> > > --- > > .../devicetree/bindings/net/mediatek-dwmac.yaml | 10 > > ++++++++-- > > 1 file changed, 8 insertions(+), 2 deletions(-) > > > > diff --git a/Documentation/devicetree/bindings/net/mediatek- > > dwmac.yaml b/Documentation/devicetree/bindings/net/mediatek- > > dwmac.yaml > > index 61b2fb9e141b..eaf7e8d53432 100644 > > --- a/Documentation/devicetree/bindings/net/mediatek-dwmac.yaml > > +++ b/Documentation/devicetree/bindings/net/mediatek-dwmac.yaml > > @@ -20,6 +20,7 @@ select: > > enum: > > - mediatek,mt2712-gmac > > Please keep the list ordered by name. MT8188 goes before 8195. > We will adjust the order in next version patches. > > - mediatek,mt8195-gmac > > + - mediatek,mt8188-gmac > > required: > > - compatible > > > > @@ -37,6 +38,11 @@ properties: > > - enum: > > - mediatek,mt8195-gmac > > - const: snps,dwmac-5.10a > > + - items: > > + - enum: > > + - mediatek,mt8188-gmac > > + - const: mediatek,mt8195-gmac > > + - const: snps,dwmac-5.10a > > > > clocks: > > minItems: 5 > > @@ -74,7 +80,7 @@ properties: > > or will round down. Range 0~31*170. > > For MT2712 RMII/MII interface, Allowed value need to be a > > multiple of 550, > > or will round down. Range 0~31*550. > > - For MT8195 RGMII/RMII/MII interface, Allowed value need to > > be a multiple of 290, > > + For MT8195/MT8188 RGMII/RMII/MII interface, Allowed value > > need to be a multiple of 290, > > For MT8188/MT8195 > We will adjust the order in next version patches. > > or will round down. Range 0~31*290. > > > > mediatek,rx-delay-ps: > > @@ -84,7 +90,7 @@ properties: > > or will round down. Range 0~31*170. > > For MT2712 RMII/MII interface, Allowed value need to be a > > multiple of 550, > > or will round down. Range 0~31*550. > > - For MT8195 RGMII/RMII/MII interface, Allowed value need to > > be a multiple > > + For MT8195/MT8188 RGMII/RMII/MII interface, Allowed value > > need to be a multiple > > For MT8188/MT8195 > We will adjust the order in next version patches. > > of 290, or will round down. Range 0~31*290. > > > > mediatek,rmii-rxc: > > BRS Jianguo ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH 1/2] dt-bindings: net: mediatek-dwmac: add support for mt8188 2022-09-20 8:36 ` [PATCH 1/2] dt-bindings: net: mediatek-dwmac: add support " Jianguo Zhang 2022-09-20 13:22 ` AngeloGioacchino Del Regno @ 2022-09-20 15:26 ` Krzysztof Kozlowski 2022-09-21 1:17 ` Jianguo Zhang 1 sibling, 1 reply; 7+ messages in thread From: Krzysztof Kozlowski @ 2022-09-20 15:26 UTC (permalink / raw) To: Jianguo Zhang, David S . Miller, Rob Herring, Krzysztof Kozlowski Cc: Eric Dumazet, Jakub Kicinski, Paolo Abeni, Giuseppe Cavallaro, Alexandre Torgue, Jose Abreu, Maxime Coquelin, Matthias Brugger, Biao Huang, netdev, devicetree, linux-kernel, linux-stm32, linux-arm-kernel, linux-mediatek On 20/09/2022 10:36, Jianguo Zhang wrote: > Add binding document for the ethernet on mt8188 > > Signed-off-by: Jianguo Zhang <jianguo.zhang@mediatek.com> Please version your patches. git format-patch can do it for you. Best regards, Krzysztof ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH 1/2] dt-bindings: net: mediatek-dwmac: add support for mt8188 2022-09-20 15:26 ` Krzysztof Kozlowski @ 2022-09-21 1:17 ` Jianguo Zhang 0 siblings, 0 replies; 7+ messages in thread From: Jianguo Zhang @ 2022-09-21 1:17 UTC (permalink / raw) To: Krzysztof Kozlowski, David S . Miller, Rob Herring, Krzysztof Kozlowski Cc: Eric Dumazet, Jakub Kicinski, Paolo Abeni, Giuseppe Cavallaro, Alexandre Torgue, Jose Abreu, Maxime Coquelin, Matthias Brugger, Biao Huang, netdev, devicetree, linux-kernel, linux-stm32, linux-arm-kernel, linux-mediatek Dear Krzysztof, Thanks for your comment. On Tue, 2022-09-20 at 17:26 +0200, Krzysztof Kozlowski wrote: > On 20/09/2022 10:36, Jianguo Zhang wrote: > > Add binding document for the ethernet on mt8188 > > > > Signed-off-by: Jianguo Zhang <jianguo.zhang@mediatek.com> > > Please version your patches. git format-patch can do it for you. > We will add version info in next version patches. > Best regards, > Krzysztof BRS Jianguo ^ permalink raw reply [flat|nested] 7+ messages in thread
* [PATCH 2/2] dt-bindings: net: snps,dwmac: add clk_csr property 2022-09-20 8:36 [PATCH v2 0/2] Mediatek ethernet patches for mt8188 Jianguo Zhang 2022-09-20 8:36 ` [PATCH 1/2] dt-bindings: net: mediatek-dwmac: add support " Jianguo Zhang @ 2022-09-20 8:36 ` Jianguo Zhang 1 sibling, 0 replies; 7+ messages in thread From: Jianguo Zhang @ 2022-09-20 8:36 UTC (permalink / raw) To: David S . Miller, Rob Herring, Krzysztof Kozlowski Cc: Eric Dumazet, Jakub Kicinski, Paolo Abeni, Giuseppe Cavallaro, Alexandre Torgue, Jose Abreu, Maxime Coquelin, Matthias Brugger, Biao Huang, netdev, devicetree, linux-kernel, linux-stm32, linux-arm-kernel, linux-mediatek, Jianguo Zhang Add clk_csr property for snps,dwmac Signed-off-by: Jianguo Zhang <jianguo.zhang@mediatek.com> --- Documentation/devicetree/bindings/net/snps,dwmac.yaml | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/Documentation/devicetree/bindings/net/snps,dwmac.yaml b/Documentation/devicetree/bindings/net/snps,dwmac.yaml index 491597c02edf..8cff30a8125d 100644 --- a/Documentation/devicetree/bindings/net/snps,dwmac.yaml +++ b/Documentation/devicetree/bindings/net/snps,dwmac.yaml @@ -288,6 +288,11 @@ properties: is supported. For example, this is used in case of SGMII and MAC2MAC connection. + clk_csr: + $ref: /schemas/types.yaml#/definitions/uint32 + description: + Frequency division factor for MDC clock. + mdio: $ref: mdio.yaml# unevaluatedProperties: false -- 2.25.1 ^ permalink raw reply related [flat|nested] 7+ messages in thread
end of thread, other threads:[~2022-09-21 1:17 UTC | newest] Thread overview: 7+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2022-09-20 8:36 [PATCH v2 0/2] Mediatek ethernet patches for mt8188 Jianguo Zhang 2022-09-20 8:36 ` [PATCH 1/2] dt-bindings: net: mediatek-dwmac: add support " Jianguo Zhang 2022-09-20 13:22 ` AngeloGioacchino Del Regno 2022-09-21 1:14 ` Jianguo Zhang 2022-09-20 15:26 ` Krzysztof Kozlowski 2022-09-21 1:17 ` Jianguo Zhang 2022-09-20 8:36 ` [PATCH 2/2] dt-bindings: net: snps,dwmac: add clk_csr property Jianguo Zhang
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).