From: Bhupesh Sharma <bhupesh.sharma@linaro.org>
To: linux-crypto@vger.kernel.org, devicetree@vger.kernel.org
Cc: agross@kernel.org, herbert@gondor.apana.org.au,
linux-kernel@vger.kernel.org, robh+dt@kernel.org,
linux-arm-msm@vger.kernel.org, thara.gopinath@gmail.com,
robh@kernel.org, krzysztof.kozlowski@linaro.org,
andersson@kernel.org, bhupesh.sharma@linaro.org,
bhupesh.linux@gmail.com, davem@davemloft.net,
Jordan Crouse <jorcrous@amazon.com>
Subject: [PATCH v7 5/9] crypto: qce: core: Add support to initialize interconnect path
Date: Tue, 20 Sep 2022 17:10:47 +0530 [thread overview]
Message-ID: <20220920114051.1116441-6-bhupesh.sharma@linaro.org> (raw)
In-Reply-To: <20220920114051.1116441-1-bhupesh.sharma@linaro.org>
From: Thara Gopinath <thara.gopinath@gmail.com>
Crypto engine on certain Snapdragon processors like sm8150, sm8250, sm8350
etc. requires interconnect path between the engine and memory to be
explicitly enabled and bandwidth set prior to any operations. Add support
in the qce core to enable the interconnect path appropriately.
Cc: Bjorn Andersson <andersson@kernel.org>
Cc: Rob Herring <robh@kernel.org>
Cc: herbert@gondor.apana.org.au
Tested-by: Jordan Crouse <jorcrous@amazon.com>
Signed-off-by: Thara Gopinath <thara.gopinath@gmail.com>
Signed-off-by: Bhupesh Sharma <bhupesh.sharma@linaro.org>
[Bhupesh: Make header file inclusion alphabetical and use devm_of_icc_get()]
---
drivers/crypto/qce/core.c | 16 +++++++++++++++-
drivers/crypto/qce/core.h | 1 +
2 files changed, 16 insertions(+), 1 deletion(-)
diff --git a/drivers/crypto/qce/core.c b/drivers/crypto/qce/core.c
index d3780be44a76..63be06df5519 100644
--- a/drivers/crypto/qce/core.c
+++ b/drivers/crypto/qce/core.c
@@ -5,6 +5,7 @@
#include <linux/clk.h>
#include <linux/dma-mapping.h>
+#include <linux/interconnect.h>
#include <linux/interrupt.h>
#include <linux/module.h>
#include <linux/mod_devicetable.h>
@@ -22,6 +23,8 @@
#define QCE_MAJOR_VERSION5 0x05
#define QCE_QUEUE_LENGTH 1
+#define QCE_DEFAULT_MEM_BANDWIDTH 393600
+
static const struct qce_algo_ops *qce_ops[] = {
#ifdef CONFIG_CRYPTO_DEV_QCE_SKCIPHER
&skcipher_ops,
@@ -206,6 +209,10 @@ static int qce_crypto_probe(struct platform_device *pdev)
if (ret < 0)
return ret;
+ qce->mem_path = devm_of_icc_get(qce->dev, "memory");
+ if (IS_ERR(qce->mem_path))
+ return PTR_ERR(qce->mem_path);
+
qce->core = devm_clk_get(qce->dev, "core");
if (IS_ERR(qce->core))
return PTR_ERR(qce->core);
@@ -218,10 +225,14 @@ static int qce_crypto_probe(struct platform_device *pdev)
if (IS_ERR(qce->bus))
return PTR_ERR(qce->bus);
- ret = clk_prepare_enable(qce->core);
+ ret = icc_set_bw(qce->mem_path, QCE_DEFAULT_MEM_BANDWIDTH, QCE_DEFAULT_MEM_BANDWIDTH);
if (ret)
return ret;
+ ret = clk_prepare_enable(qce->core);
+ if (ret)
+ goto err_mem_path_disable;
+
ret = clk_prepare_enable(qce->iface);
if (ret)
goto err_clks_core;
@@ -260,6 +271,9 @@ static int qce_crypto_probe(struct platform_device *pdev)
clk_disable_unprepare(qce->iface);
err_clks_core:
clk_disable_unprepare(qce->core);
+err_mem_path_disable:
+ icc_set_bw(qce->mem_path, 0, 0);
+
return ret;
}
diff --git a/drivers/crypto/qce/core.h b/drivers/crypto/qce/core.h
index 085774cdf641..228fcd69ec51 100644
--- a/drivers/crypto/qce/core.h
+++ b/drivers/crypto/qce/core.h
@@ -35,6 +35,7 @@ struct qce_device {
void __iomem *base;
struct device *dev;
struct clk *core, *iface, *bus;
+ struct icc_path *mem_path;
struct qce_dma_data dma;
int burst_size;
unsigned int pipe_pair_id;
--
2.37.1
next prev parent reply other threads:[~2022-09-20 11:42 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-20 11:40 [PATCH v7 0/9] crypto: qcom-qce: Add YAML bindings & support for newer SoCs Bhupesh Sharma
2022-09-20 11:40 ` [PATCH v7 1/9] dt-bindings: qcom-qce: Convert bindings to yaml Bhupesh Sharma
2022-09-20 11:40 ` [PATCH v7 2/9] dt-bindings: qcom-qce: Add 'interconnects' and 'interconnect-names' Bhupesh Sharma
2022-09-20 11:40 ` [PATCH v7 3/9] dt-bindings: qcom-qce: Add 'iommus' to optional properties Bhupesh Sharma
2022-09-20 11:40 ` [PATCH v7 4/9] dt-bindings: qcom-qce: Add new SoC compatible strings for qcom-qce Bhupesh Sharma
2022-09-20 15:10 ` Krzysztof Kozlowski
2022-09-21 6:00 ` Bhupesh Sharma
2022-09-20 11:40 ` Bhupesh Sharma [this message]
2022-09-20 11:40 ` [PATCH v7 6/9] crypto: qce: core: Add new compatibles for qce crypto driver Bhupesh Sharma
2022-09-20 15:12 ` Krzysztof Kozlowski
2022-09-21 6:16 ` Bhupesh Sharma
2022-09-21 6:27 ` Krzysztof Kozlowski
2022-09-21 6:52 ` Bhupesh Sharma
2022-11-07 3:43 ` Bjorn Andersson
2022-11-07 9:07 ` Krzysztof Kozlowski
2022-09-20 11:40 ` [PATCH v7 7/9] crypto: qce: core: Make clocks optional Bhupesh Sharma
2022-09-20 11:40 ` [PATCH v7 8/9] MAINTAINERS: Add qcom-qce dt-binding file to QUALCOMM CRYPTO DRIVERS section Bhupesh Sharma
2022-09-20 11:40 ` [PATCH v7 9/9] MAINTAINERS: Add myself as a co-maintainer for Qualcomm Crypto Drivers Bhupesh Sharma
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220920114051.1116441-6-bhupesh.sharma@linaro.org \
--to=bhupesh.sharma@linaro.org \
--cc=agross@kernel.org \
--cc=andersson@kernel.org \
--cc=bhupesh.linux@gmail.com \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=herbert@gondor.apana.org.au \
--cc=jorcrous@amazon.com \
--cc=krzysztof.kozlowski@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=robh@kernel.org \
--cc=thara.gopinath@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).