devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Bhupesh Sharma <bhupesh.sharma@linaro.org>
To: linux-crypto@vger.kernel.org, devicetree@vger.kernel.org
Cc: agross@kernel.org, herbert@gondor.apana.org.au,
	linux-kernel@vger.kernel.org, robh+dt@kernel.org,
	linux-arm-msm@vger.kernel.org, thara.gopinath@gmail.com,
	robh@kernel.org, krzysztof.kozlowski@linaro.org,
	andersson@kernel.org, bhupesh.sharma@linaro.org,
	bhupesh.linux@gmail.com, davem@davemloft.net,
	Jordan Crouse <jorcrous@amazon.com>
Subject: [PATCH v7 7/9] crypto: qce: core: Make clocks optional
Date: Tue, 20 Sep 2022 17:10:49 +0530	[thread overview]
Message-ID: <20220920114051.1116441-8-bhupesh.sharma@linaro.org> (raw)
In-Reply-To: <20220920114051.1116441-1-bhupesh.sharma@linaro.org>

From: Thara Gopinath <thara.gopinath@gmail.com>

On certain Snapdragon processors, the crypto engine clocks are enabled by
default by security firmware and the driver need not/ should not handle the
clocks. Make acquiring of all the clocks optional in crypto engine driver
so that the driver initializes properly even if no clocks are specified in
the dt.

Cc: Bjorn Andersson <andersson@kernel.org>
Cc: Rob Herring <robh@kernel.org>
Cc: herbert@gondor.apana.org.au
Tested-by: Jordan Crouse <jorcrous@amazon.com>
Signed-off-by: Thara Gopinath <thara.gopinath@gmail.com>
Signed-off-by: Bhupesh Sharma <bhupesh.sharma@linaro.org>
[Bhupesh: Massage the commit log]
---
 drivers/crypto/qce/core.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/drivers/crypto/qce/core.c b/drivers/crypto/qce/core.c
index 99ed540611ab..ef774f6edb5a 100644
--- a/drivers/crypto/qce/core.c
+++ b/drivers/crypto/qce/core.c
@@ -213,15 +213,15 @@ static int qce_crypto_probe(struct platform_device *pdev)
 	if (IS_ERR(qce->mem_path))
 		return PTR_ERR(qce->mem_path);
 
-	qce->core = devm_clk_get(qce->dev, "core");
+	qce->core = devm_clk_get_optional(qce->dev, "core");
 	if (IS_ERR(qce->core))
 		return PTR_ERR(qce->core);
 
-	qce->iface = devm_clk_get(qce->dev, "iface");
+	qce->iface = devm_clk_get_optional(qce->dev, "iface");
 	if (IS_ERR(qce->iface))
 		return PTR_ERR(qce->iface);
 
-	qce->bus = devm_clk_get(qce->dev, "bus");
+	qce->bus = devm_clk_get_optional(qce->dev, "bus");
 	if (IS_ERR(qce->bus))
 		return PTR_ERR(qce->bus);
 
-- 
2.37.1


  parent reply	other threads:[~2022-09-20 11:42 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-09-20 11:40 [PATCH v7 0/9] crypto: qcom-qce: Add YAML bindings & support for newer SoCs Bhupesh Sharma
2022-09-20 11:40 ` [PATCH v7 1/9] dt-bindings: qcom-qce: Convert bindings to yaml Bhupesh Sharma
2022-09-20 11:40 ` [PATCH v7 2/9] dt-bindings: qcom-qce: Add 'interconnects' and 'interconnect-names' Bhupesh Sharma
2022-09-20 11:40 ` [PATCH v7 3/9] dt-bindings: qcom-qce: Add 'iommus' to optional properties Bhupesh Sharma
2022-09-20 11:40 ` [PATCH v7 4/9] dt-bindings: qcom-qce: Add new SoC compatible strings for qcom-qce Bhupesh Sharma
2022-09-20 15:10   ` Krzysztof Kozlowski
2022-09-21  6:00     ` Bhupesh Sharma
2022-09-20 11:40 ` [PATCH v7 5/9] crypto: qce: core: Add support to initialize interconnect path Bhupesh Sharma
2022-09-20 11:40 ` [PATCH v7 6/9] crypto: qce: core: Add new compatibles for qce crypto driver Bhupesh Sharma
2022-09-20 15:12   ` Krzysztof Kozlowski
2022-09-21  6:16     ` Bhupesh Sharma
2022-09-21  6:27       ` Krzysztof Kozlowski
2022-09-21  6:52         ` Bhupesh Sharma
2022-11-07  3:43           ` Bjorn Andersson
2022-11-07  9:07             ` Krzysztof Kozlowski
2022-09-20 11:40 ` Bhupesh Sharma [this message]
2022-09-20 11:40 ` [PATCH v7 8/9] MAINTAINERS: Add qcom-qce dt-binding file to QUALCOMM CRYPTO DRIVERS section Bhupesh Sharma
2022-09-20 11:40 ` [PATCH v7 9/9] MAINTAINERS: Add myself as a co-maintainer for Qualcomm Crypto Drivers Bhupesh Sharma

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220920114051.1116441-8-bhupesh.sharma@linaro.org \
    --to=bhupesh.sharma@linaro.org \
    --cc=agross@kernel.org \
    --cc=andersson@kernel.org \
    --cc=bhupesh.linux@gmail.com \
    --cc=davem@davemloft.net \
    --cc=devicetree@vger.kernel.org \
    --cc=herbert@gondor.apana.org.au \
    --cc=jorcrous@amazon.com \
    --cc=krzysztof.kozlowski@linaro.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-crypto@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=robh+dt@kernel.org \
    --cc=robh@kernel.org \
    --cc=thara.gopinath@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).