* [PATCH 1/3] dt-bindings: phy: qcom,qusb2: document sdm670 compatible
2022-09-20 22:43 [PATCH 0/3] SDM670 USB 2.0 support Richard Acayan
@ 2022-09-20 22:43 ` Richard Acayan
2022-09-21 7:32 ` Krzysztof Kozlowski
2022-09-20 22:43 ` [PATCH 2/3] dt-bindings: usb: dwc3: add " Richard Acayan
2022-09-20 22:43 ` [PATCH 3/3] usb: dwc3: qcom: " Richard Acayan
2 siblings, 1 reply; 9+ messages in thread
From: Richard Acayan @ 2022-09-20 22:43 UTC (permalink / raw)
To: linux-arm-msm
Cc: Andy Gross, Bjorn Andersson, Konrad Dybcio,
Kishon Vijay Abraham I, Vinod Koul, Rob Herring,
Krzysztof Kozlowski, Greg Kroah-Hartman, Felipe Balbi,
Wesley Cheng, linux-phy, devicetree, linux-usb, Richard Acayan
The Snapdragon 670 uses the QUSB driver for USB 2.0. Document the
compatible used in the device tree.
Signed-off-by: Richard Acayan <mailingradian@gmail.com>
---
Documentation/devicetree/bindings/phy/qcom,qusb2-phy.yaml | 1 +
1 file changed, 1 insertion(+)
diff --git a/Documentation/devicetree/bindings/phy/qcom,qusb2-phy.yaml b/Documentation/devicetree/bindings/phy/qcom,qusb2-phy.yaml
index d68ab49345b8..636ea430fbff 100644
--- a/Documentation/devicetree/bindings/phy/qcom,qusb2-phy.yaml
+++ b/Documentation/devicetree/bindings/phy/qcom,qusb2-phy.yaml
@@ -30,6 +30,7 @@ properties:
- items:
- enum:
- qcom,sc7180-qusb2-phy
+ - qcom,sdm670-qusb2-phy
- qcom,sdm845-qusb2-phy
- qcom,sm6350-qusb2-phy
- const: qcom,qusb2-v2-phy
--
2.37.3
^ permalink raw reply related [flat|nested] 9+ messages in thread* Re: [PATCH 1/3] dt-bindings: phy: qcom,qusb2: document sdm670 compatible
2022-09-20 22:43 ` [PATCH 1/3] dt-bindings: phy: qcom,qusb2: document sdm670 compatible Richard Acayan
@ 2022-09-21 7:32 ` Krzysztof Kozlowski
0 siblings, 0 replies; 9+ messages in thread
From: Krzysztof Kozlowski @ 2022-09-21 7:32 UTC (permalink / raw)
To: Richard Acayan, linux-arm-msm
Cc: Andy Gross, Bjorn Andersson, Konrad Dybcio,
Kishon Vijay Abraham I, Vinod Koul, Rob Herring,
Krzysztof Kozlowski, Greg Kroah-Hartman, Felipe Balbi,
Wesley Cheng, linux-phy, devicetree, linux-usb
On 21/09/2022 00:43, Richard Acayan wrote:
> The Snapdragon 670 uses the QUSB driver for USB 2.0. Document the
> compatible used in the device tree.
>
> Signed-off-by: Richard Acayan <mailingradian@gmail.com>
Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 9+ messages in thread
* [PATCH 2/3] dt-bindings: usb: dwc3: add sdm670 compatible
2022-09-20 22:43 [PATCH 0/3] SDM670 USB 2.0 support Richard Acayan
2022-09-20 22:43 ` [PATCH 1/3] dt-bindings: phy: qcom,qusb2: document sdm670 compatible Richard Acayan
@ 2022-09-20 22:43 ` Richard Acayan
2022-09-21 7:32 ` Krzysztof Kozlowski
2022-09-20 22:43 ` [PATCH 3/3] usb: dwc3: qcom: " Richard Acayan
2 siblings, 1 reply; 9+ messages in thread
From: Richard Acayan @ 2022-09-20 22:43 UTC (permalink / raw)
To: linux-arm-msm
Cc: Andy Gross, Bjorn Andersson, Konrad Dybcio,
Kishon Vijay Abraham I, Vinod Koul, Rob Herring,
Krzysztof Kozlowski, Greg Kroah-Hartman, Felipe Balbi,
Wesley Cheng, linux-phy, devicetree, linux-usb, Richard Acayan
The Snapdragon 670 has DWC3 USB support. Add a compatible to reflect
that.
Signed-off-by: Richard Acayan <mailingradian@gmail.com>
---
Documentation/devicetree/bindings/usb/qcom,dwc3.yaml | 1 +
1 file changed, 1 insertion(+)
diff --git a/Documentation/devicetree/bindings/usb/qcom,dwc3.yaml b/Documentation/devicetree/bindings/usb/qcom,dwc3.yaml
index cd2f7cb6745a..021bd9ba4261 100644
--- a/Documentation/devicetree/bindings/usb/qcom,dwc3.yaml
+++ b/Documentation/devicetree/bindings/usb/qcom,dwc3.yaml
@@ -26,6 +26,7 @@ properties:
- qcom,sc7280-dwc3
- qcom,sc8280xp-dwc3
- qcom,sdm660-dwc3
+ - qcom,sdm670-dwc3
- qcom,sdm845-dwc3
- qcom,sdx55-dwc3
- qcom,sdx65-dwc3
--
2.37.3
^ permalink raw reply related [flat|nested] 9+ messages in thread* Re: [PATCH 2/3] dt-bindings: usb: dwc3: add sdm670 compatible
2022-09-20 22:43 ` [PATCH 2/3] dt-bindings: usb: dwc3: add " Richard Acayan
@ 2022-09-21 7:32 ` Krzysztof Kozlowski
2022-09-22 2:42 ` Richard Acayan
0 siblings, 1 reply; 9+ messages in thread
From: Krzysztof Kozlowski @ 2022-09-21 7:32 UTC (permalink / raw)
To: Richard Acayan, linux-arm-msm
Cc: Andy Gross, Bjorn Andersson, Konrad Dybcio,
Kishon Vijay Abraham I, Vinod Koul, Rob Herring,
Krzysztof Kozlowski, Greg Kroah-Hartman, Felipe Balbi,
Wesley Cheng, linux-phy, devicetree, linux-usb
On 21/09/2022 00:43, Richard Acayan wrote:
> The Snapdragon 670 has DWC3 USB support. Add a compatible to reflect
> that.
>
> Signed-off-by: Richard Acayan <mailingradian@gmail.com>
> ---
Missing changes in allOf?
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH 2/3] dt-bindings: usb: dwc3: add sdm670 compatible
2022-09-21 7:32 ` Krzysztof Kozlowski
@ 2022-09-22 2:42 ` Richard Acayan
0 siblings, 0 replies; 9+ messages in thread
From: Richard Acayan @ 2022-09-22 2:42 UTC (permalink / raw)
To: Krzysztof Kozlowski
Cc: Andy Gross, Bjorn Andersson, Konrad Dybcio,
Kishon Vijay Abraham I, Vinod Koul, Rob Herring,
Greg Kroah-Hartman, Felipe Balbi, Wesley Cheng, linux-phy,
devicetree, linux-usb, Richard Acayan
> On 21/09/2022 00:43, Richard Acayan wrote:
> > The Snapdragon 670 has DWC3 USB support. Add a compatible to reflect
> > that.
> >
> > Signed-off-by: Richard Acayan <mailingradian@gmail.com>
> > ---
>
> Missing changes in allOf?
Oh, I didn't see that. Nice catch!
>
>
> Best regards,
> Krzysztof
^ permalink raw reply [flat|nested] 9+ messages in thread
* [PATCH 3/3] usb: dwc3: qcom: add sdm670 compatible
2022-09-20 22:43 [PATCH 0/3] SDM670 USB 2.0 support Richard Acayan
2022-09-20 22:43 ` [PATCH 1/3] dt-bindings: phy: qcom,qusb2: document sdm670 compatible Richard Acayan
2022-09-20 22:43 ` [PATCH 2/3] dt-bindings: usb: dwc3: add " Richard Acayan
@ 2022-09-20 22:43 ` Richard Acayan
2022-09-20 23:44 ` Konrad Dybcio
2022-09-21 7:33 ` Krzysztof Kozlowski
2 siblings, 2 replies; 9+ messages in thread
From: Richard Acayan @ 2022-09-20 22:43 UTC (permalink / raw)
To: linux-arm-msm
Cc: Andy Gross, Bjorn Andersson, Konrad Dybcio,
Kishon Vijay Abraham I, Vinod Koul, Rob Herring,
Krzysztof Kozlowski, Greg Kroah-Hartman, Felipe Balbi,
Wesley Cheng, linux-phy, devicetree, linux-usb, Richard Acayan
The Snapdragon 670 has DWC3 USB support. Add a compatible for device tree
semantics.
Signed-off-by: Richard Acayan <mailingradian@gmail.com>
---
drivers/usb/dwc3/dwc3-qcom.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/usb/dwc3/dwc3-qcom.c b/drivers/usb/dwc3/dwc3-qcom.c
index 9a94b1ab8f7a..34b70c3c2f70 100644
--- a/drivers/usb/dwc3/dwc3-qcom.c
+++ b/drivers/usb/dwc3/dwc3-qcom.c
@@ -1010,6 +1010,7 @@ static const struct of_device_id dwc3_qcom_of_match[] = {
{ .compatible = "qcom,msm8996-dwc3" },
{ .compatible = "qcom,msm8998-dwc3" },
{ .compatible = "qcom,sdm660-dwc3" },
+ { .compatible = "qcom,sdm670-dwc3" },
{ .compatible = "qcom,sdm845-dwc3" },
{ }
};
--
2.37.3
^ permalink raw reply related [flat|nested] 9+ messages in thread* Re: [PATCH 3/3] usb: dwc3: qcom: add sdm670 compatible
2022-09-20 22:43 ` [PATCH 3/3] usb: dwc3: qcom: " Richard Acayan
@ 2022-09-20 23:44 ` Konrad Dybcio
2022-09-21 7:33 ` Krzysztof Kozlowski
1 sibling, 0 replies; 9+ messages in thread
From: Konrad Dybcio @ 2022-09-20 23:44 UTC (permalink / raw)
To: Richard Acayan, linux-arm-msm
Cc: Andy Gross, Bjorn Andersson, Kishon Vijay Abraham I, Vinod Koul,
Rob Herring, Krzysztof Kozlowski, Greg Kroah-Hartman,
Felipe Balbi, Wesley Cheng, linux-phy, devicetree, linux-usb
On 21.09.2022 00:43, Richard Acayan wrote:
> The Snapdragon 670 has DWC3 USB support. Add a compatible for device tree
> semantics.
>
> Signed-off-by: Richard Acayan <mailingradian@gmail.com>
> ---
Reviewed-by: Konrad Dybcio <konrad.dybcio@somainline.org>
Konrad
> drivers/usb/dwc3/dwc3-qcom.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/usb/dwc3/dwc3-qcom.c b/drivers/usb/dwc3/dwc3-qcom.c
> index 9a94b1ab8f7a..34b70c3c2f70 100644
> --- a/drivers/usb/dwc3/dwc3-qcom.c
> +++ b/drivers/usb/dwc3/dwc3-qcom.c
> @@ -1010,6 +1010,7 @@ static const struct of_device_id dwc3_qcom_of_match[] = {
> { .compatible = "qcom,msm8996-dwc3" },
> { .compatible = "qcom,msm8998-dwc3" },
> { .compatible = "qcom,sdm660-dwc3" },
> + { .compatible = "qcom,sdm670-dwc3" },
> { .compatible = "qcom,sdm845-dwc3" },
> { }
> };
^ permalink raw reply [flat|nested] 9+ messages in thread* Re: [PATCH 3/3] usb: dwc3: qcom: add sdm670 compatible
2022-09-20 22:43 ` [PATCH 3/3] usb: dwc3: qcom: " Richard Acayan
2022-09-20 23:44 ` Konrad Dybcio
@ 2022-09-21 7:33 ` Krzysztof Kozlowski
1 sibling, 0 replies; 9+ messages in thread
From: Krzysztof Kozlowski @ 2022-09-21 7:33 UTC (permalink / raw)
To: Richard Acayan, linux-arm-msm
Cc: Andy Gross, Bjorn Andersson, Konrad Dybcio,
Kishon Vijay Abraham I, Vinod Koul, Rob Herring,
Krzysztof Kozlowski, Greg Kroah-Hartman, Felipe Balbi,
Wesley Cheng, linux-phy, devicetree, linux-usb
On 21/09/2022 00:43, Richard Acayan wrote:
> The Snapdragon 670 has DWC3 USB support. Add a compatible for device tree
> semantics.
>
> Signed-off-by: Richard Acayan <mailingradian@gmail.com>
> ---
> drivers/usb/dwc3/dwc3-qcom.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/usb/dwc3/dwc3-qcom.c b/drivers/usb/dwc3/dwc3-qcom.c
> index 9a94b1ab8f7a..34b70c3c2f70 100644
> --- a/drivers/usb/dwc3/dwc3-qcom.c
> +++ b/drivers/usb/dwc3/dwc3-qcom.c
> @@ -1010,6 +1010,7 @@ static const struct of_device_id dwc3_qcom_of_match[] = {
> { .compatible = "qcom,msm8996-dwc3" },
> { .compatible = "qcom,msm8998-dwc3" },
> { .compatible = "qcom,sdm660-dwc3" },
> + { .compatible = "qcom,sdm670-dwc3" },
> { .compatible = "qcom,sdm845-dwc3" },
No. This does not make sense. You already have fallback.
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 9+ messages in thread