From: Jakub Kicinski <kuba@kernel.org>
To: Gerhard Engleder <gerhard@engleder-embedded.com>
Cc: davem@davemloft.net, robh+dt@kernel.org, netdev@vger.kernel.org,
devicetree@vger.kernel.org
Subject: Re: [PATCH net-next 5/7] tsnep: Add EtherType RX flow classification support
Date: Wed, 21 Sep 2022 18:00:42 -0700 [thread overview]
Message-ID: <20220921180042.440a8b65@kernel.org> (raw)
In-Reply-To: <20220915203638.42917-6-gerhard@engleder-embedded.com>
On Thu, 15 Sep 2022 22:36:35 +0200 Gerhard Engleder wrote:
> +static int tsnep_add_rule(struct tsnep_adapter *adapter,
> + struct tsnep_rxnfc_rule *rule)
> +{
> + struct tsnep_rxnfc_rule *pred, *cur;
> +
> + tsnep_enable_rule(adapter, rule);
> +
> + pred = NULL;
> + list_for_each_entry(cur, &adapter->rxnfc_rules, list) {
> + if (cur->location >= rule->location)
> + break;
> + pred = cur;
> + }
> +
> + list_add(&rule->list, pred ? &pred->list : &adapter->rxnfc_rules);
> + adapter->rxnfc_count++;
> +
> + return 0;
This never fails, perhaps the return code is unnecessary
next prev parent reply other threads:[~2022-09-22 1:00 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-15 20:36 [PATCH net-next 0/7] tsnep: multi queue support and some other improvements Gerhard Engleder
2022-09-15 20:36 ` [PATCH net-next 1/7] dt-bindings: net: tsnep: Allow dma-coherent Gerhard Engleder
2022-09-15 20:36 ` [PATCH net-next 2/7] dt-bindings: net: tsnep: Allow additional interrupts Gerhard Engleder
2022-09-22 0:42 ` Jakub Kicinski
2022-09-23 11:32 ` Krzysztof Kozlowski
2022-09-23 19:22 ` Gerhard Engleder
2022-09-15 20:36 ` [PATCH net-next 3/7] tsnep: Move interrupt from device to queue Gerhard Engleder
2022-09-22 0:57 ` Jakub Kicinski
2022-09-23 19:23 ` Gerhard Engleder
2022-09-15 20:36 ` [PATCH net-next 4/7] tsnep: Support multiple TX/RX queue pairs Gerhard Engleder
2022-09-15 20:36 ` [PATCH net-next 5/7] tsnep: Add EtherType RX flow classification support Gerhard Engleder
2022-09-22 0:59 ` Jakub Kicinski
2022-09-23 19:29 ` Gerhard Engleder
2022-09-22 1:00 ` Jakub Kicinski [this message]
2022-09-23 19:24 ` Gerhard Engleder
2022-09-15 20:36 ` [PATCH net-next 6/7] tsnep: Use page pool for RX Gerhard Engleder
2022-09-15 20:36 ` [PATCH net-next 7/7] tsnep: Rework RX buffer allocation Gerhard Engleder
2022-09-22 1:01 ` Jakub Kicinski
2022-09-23 19:33 ` Gerhard Engleder
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220921180042.440a8b65@kernel.org \
--to=kuba@kernel.org \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=gerhard@engleder-embedded.com \
--cc=netdev@vger.kernel.org \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).