From: Michael Walle <michael@walle.cc>
To: marcus.carlberg@axis.com
Cc: andrew@lunn.ch, davem@davemloft.net, devicetree@vger.kernel.org,
edumazet@google.com, hkallweit1@gmail.com, kernel@axis.com,
kuba@kernel.org, linux-kernel@vger.kernel.org,
linux@armlinux.org.uk, lxu@maxlinear.com, netdev@vger.kernel.org,
pabeni@redhat.com, Michael Walle <michael@walle.cc>
Subject: Re: [PATCH net-next 0/2] net: phy: mxl-gpy: Add mode for 2 leds
Date: Thu, 22 Sep 2022 10:05:29 +0200 [thread overview]
Message-ID: <20220922080529.928823-1-michael@walle.cc> (raw)
In-Reply-To: <20220920151411.12523-1-marcus.carlberg@axis.com>
Hi,
> GPY211 phy default to using all four led pins.
> Hardwares using only two leds where led0 is used as the high
> network speed led and led1 the low network speed led will not
> get the correct behaviour since 1Gbit and 2.5Gbit will not be
> represented at all in the existing leds.
I might be wrong, but PHY LED bindings should be integrated with/using
the LED subsystem. Although I didn't see any development regarding this
for a long time.
That being said, it seems you are adding a new (DT) property which
just matches your particular hardware design, no?
-michael
next prev parent reply other threads:[~2022-09-22 8:06 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-20 15:14 [PATCH net-next 0/2] net: phy: mxl-gpy: Add mode for 2 leds Marcus Carlberg
2022-09-20 15:14 ` [PATCH net-next 1/2] dt-bindings: net: Add mxl,gpy Marcus Carlberg
2022-09-25 23:27 ` kernel test robot
2022-09-20 15:14 ` [PATCH net-next 2/2] net: phy: mxl-gpy: Add mode for 2 leds Marcus Carlberg
2022-09-22 8:05 ` Michael Walle [this message]
2022-09-22 12:00 ` [PATCH net-next 0/2] " Andrew Lunn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220922080529.928823-1-michael@walle.cc \
--to=michael@walle.cc \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=edumazet@google.com \
--cc=hkallweit1@gmail.com \
--cc=kernel@axis.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=lxu@maxlinear.com \
--cc=marcus.carlberg@axis.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).